chore: ensure https on fsfe link text #1477

nico.rikken · 2020-07-02T05:34:24Z

nico.rikken commented

2020-07-02 05:34:24 +00:00

This PR ensures https:// on fsfe links (as link or in text) and removes the www. subdomain. Relates to issue #1378

Executed commands:

find . -iname '*.xhtml'  -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \;
find . -iname '*.xml'  -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \;
find . -iname '*.svg'  -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \;
find . -iname '*.php'  -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \;
find . -iname '*.txt'  -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \;

This PR ensures `https://` on fsfe links (as link or in text) and removes the `www.` subdomain. Relates to issue #1378 Executed commands: ``` find . -iname '*.xhtml' -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \; find . -iname '*.xml' -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \; find . -iname '*.svg' -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \; find . -iname '*.php' -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \; find . -iname '*.txt' -exec perl -pi -e 's/http:\/\/(www\.)?fsfe\.org/https:\/\/fsfe\.org/g' {} \; ```

max.mehl commented

2020-07-02 08:59:46 +00:00

Could you please rebase? There are some conflicts due to the merge of #1464

nico.rikken commented

2020-07-03 05:03:39 +00:00

Thanks, no problem. I've rebased it. All these changes are starting to show its effect, less and less issues in the codebase 😄

Thanks, no problem. I've rebased it. All these changes are starting to show its effect, less and less issues in the codebase :smile:

nico.rikken commented

2020-07-03 05:57:06 +00:00

I've now included other filetypes that seem harmless. I can do the same replacement on the .pl and .xsl files, but that might have unintended consequences so I've decided to not do that yet.

I've now included other filetypes that seem harmless. I can do the same replacement on the `.pl` and `.xsl` files, but that might have unintended consequences so I've decided to not do that yet.

max.mehl commented

2020-07-03 09:35:57 +00:00

Thanks! I couldn't think of a scenario in which pl and xsl actually would create problems, but as you say in German: "the devil is a squirrel" :D

FSFE closed this pull request

2020-07-03 09:36:15 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1477