#1378 Many pages contain absolute links with fsfe.org

Open
opened 3 months ago by reinhard · 35 comments

Even though it has always been the rule that links within fsfe.org should be relative, there are many many links written as absolute links - some pointing to https://fsfe.org, some to http://fsfe.org, some to http://www.fsfe.org/, and some even to www.fsfeurope.org.

Unfortunately I don’t think that this can be fixed with a global search and replace, because there might be occasions where an URL is written in a text, purposedly including the servername (but potentially having to be updated from a former version to https://fsfe.org).

Even though it has always been the rule that links within fsfe.org should be relative, there are many many links written as absolute links - some pointing to https://fsfe.org, some to http://fsfe.org, some to http://www.fsfe.org/, and some even to www.fsfeurope.org. Unfortunately I don't think that this can be fixed with a global search and replace, because there might be occasions where an URL is written in a text, purposedly including the servername (but potentially having to be updated from a former version to https://fsfe.org).
reinhard commented 3 months ago
Poster

To avoid misunderstandings: it’s about whether the link should contain protocol and server (“https://fsfe.org”), not whether the path is absolute or relative. So a link to “/foo/bar.html” is perfectly okay, but “https://fsfe.org/foo/bar.html” should be changed into “/foo/bar.html”.

To avoid misunderstandings: it's about whether the link should contain protocol and server ("https://fsfe.org"), not whether the path is absolute or relative. So a link to "/foo/bar.html" is perfectly okay, but "https://fsfe.org/foo/bar.html" should be changed into "/foo/bar.html".
max.mehl commented 3 months ago
Owner

Even though it has always been the rule that links within fsfe.org should be relative, there are many many links written as absolute links - some pointing to https://fsfe.org, some to http://fsfe.org, some to http://www.fsfe.org/, and some even to www.fsfeurope.org.

Yes, far too many for my taste. Unfortunately, during editing news items or so in a collaborative text editor, I can see the point of using absolute links: a proofreader or editor can immediately click on the link to check whether it works or how it looks like (and if it makes sense). The truncated links are harder to check.

So while I agree that using protocol+server is bad style, I wonder how we can assure that with the next news item the problem will be reintroduces.

Unfortunately I don’t think that this can be fixed with a global search and replace, because there might be occasions where an URL is written in a text, purposedly including the servername (but potentially having to be updated from a former version to https://fsfe.org).

Why is that? Using a regex, or some XSL tooling, we could explicitely search for href attributes to not update the content itself.

> Even though it has always been the rule that links within fsfe.org should be relative, there are many many links written as absolute links - some pointing to https://fsfe.org, some to http://fsfe.org, some to http://www.fsfe.org/, and some even to www.fsfeurope.org. Yes, far too many for my taste. Unfortunately, during editing news items or so in a collaborative text editor, I can see the point of using absolute links: a proofreader or editor can immediately click on the link to check whether it works or how it looks like (and if it makes sense). The truncated links are harder to check. So while I agree that using protocol+server is bad style, I wonder how we can assure that with the next news item the problem will be reintroduces. > Unfortunately I don't think that this can be fixed with a global search and replace, because there might be occasions where an URL is written in a text, purposedly including the servername (but potentially having to be updated from a former version to https://fsfe.org). Why is that? Using a regex, or some XSL tooling, we could explicitely search for href attributes to not update the content itself.
reinhard commented 3 months ago
Poster

Unfortunately, during editing news items or so in a collaborative text editor, I can see the point of using absolute links: a proofreader or editor can immediately click on the link to check whether it works or how it looks like (and if it makes sense). The truncated links are harder to check.

I am tempted to answer this concern by adding a dependency on #138 to this issue :-) so we would have our own tool to turn markup into HTML. But I guess that’s a long way until we’re there.

Until then, I guess we could make things already a lot better by removing at least the old versions like www.fsfeuropr.org or www.fsfe.org or the ones without https.

Why is that? Using a regex, or some XSL tooling, we could explicitely search for href attributes to not update the content itself.

Yes, you’re right, something like s;href="http://www.fsfeurope.org;href=";g should actually do the trick.

> Unfortunately, during editing news items or so in a collaborative text editor, I can see the point of using absolute links: a proofreader or editor can immediately click on the link to check whether it works or how it looks like (and if it makes sense). The truncated links are harder to check. I am tempted to answer this concern by adding a dependency on #138 to this issue :-) so we would have our own tool to turn markup into HTML. But I guess that's a long way until we're there. Until then, I guess we could make things already a lot better by removing at least the old versions like www.fsfeuropr.org or www.fsfe.org or the ones without https. > Why is that? Using a regex, or some XSL tooling, we could explicitely search for href attributes to not update the content itself. Yes, you're right, something like `s;href="http://www.fsfeurope.org;href=";g` should actually do the trick.
max.mehl commented 3 months ago
Owner

OK, let’s start with the cleanup first, and then think of long-term solutions later.

#138 is of course yet another heavy change which would influence the workflow of editors, so the links may be part of that step.

OK, let's start with the cleanup first, and then think of long-term solutions later. #138 is of course yet another heavy change which would influence the workflow of editors, so the links may be part of that step.
nico.rikken commented 3 months ago
Collaborator

I’ve submitted a pull request with a cleanup. We should probably expand the webhooks to warn for absolute URLs.

I've submitted a pull request with a cleanup. We should probably expand the webhooks to warn for absolute URLs.
reinhard commented 3 months ago
Poster

Thank you @nico.rikken! This is an important first step. Of course we shall not forget about the other variants like http (without “s”), www.fsfe.org, or www.fsfeurope.org.

Thank you @nico.rikken! This is an important first step. Of course we shall not forget about the other variants like http (without "s"), www.fsfe.org, or www.fsfeurope.org.
nico.rikken commented 3 months ago
Collaborator

Indeed, so various permutations:

href="http://fsfe.org/            (470 files)
href="https://fsfe.org/           (734 files)
href="http://www.fsfe.org/        (116 files)
href="https://www.fsfe.org/       (8 files)
href="http://fsfeurope.org/       (43 files)
href="https://fsfeurope.org/      (0 files)
href="http://www.fsfeurope.org/   (100 files)
href="https://www.fsfeurope.org/  (0 files)

As the pull request #1383 focusess on href="https://fsfe.org/ it replaces the bulk. Afterwards I can open up pull-requests for the rest.

I was wearry of replacing the campaigns pages, assuming they were also published under a seperate url like https://pdfreaders.org/ . But reading further I get the impression that is not the case. Can ALL xhtml and html pages, and XML events be replaced to absolute URls?

Indeed, so various permutations: ``` href="http://fsfe.org/ (470 files) href="https://fsfe.org/ (734 files) href="http://www.fsfe.org/ (116 files) href="https://www.fsfe.org/ (8 files) href="http://fsfeurope.org/ (43 files) href="https://fsfeurope.org/ (0 files) href="http://www.fsfeurope.org/ (100 files) href="https://www.fsfeurope.org/ (0 files) ``` As the pull request #1383 focusess on `href="https://fsfe.org/` it replaces the bulk. Afterwards I can open up pull-requests for the rest. I was wearry of replacing the campaigns pages, assuming they were also published under a seperate url like https://pdfreaders.org/ . But reading further I get the impression that is not the case. Can ALL xhtml and html pages, and XML events be replaced to absolute URls?
reinhard commented 3 months ago
Poster

You were absolutely right not doing the replacements in the pdfreaders and drm.info directories, since they are indeed published under different URLs.

You were absolutely right *not* doing the replacements in the pdfreaders and drm.info directories, since they are indeed published under different URLs.
nico.rikken self-assigned this 2 months ago
nico.rikken commented 2 months ago
Collaborator

I just created the pull request to solve this issue.

What to do with pdfreaders and drm.info ? I can check and correct the URLs to be https://fsfe.org style.

I just created the pull request to solve this issue. What to do with pdfreaders and drm.info ? I can check and correct the URLs to be `https://fsfe.org` style.
reinhard commented 2 months ago
Poster

I just created the pull request to solve this issue.

Looks very good to me, I just merged it.

What to do with pdfreaders and drm.info ? I can check and correct the URLs to be https://fsfe.org style.

That would be excellent, thank you!

> I just created the pull request to solve this issue. Looks very good to me, I just merged it. > What to do with pdfreaders and drm.info ? I can check and correct the URLs to be `https://fsfe.org` style. That would be excellent, thank you!
nico.rikken commented 2 months ago
Collaborator

Check: https://git.fsfe.org/FSFE/fsfe-website/pulls/1424

I noticed that there are still some things to be replaced:

news/2008/news-20080228-01.ca.xhtml
58:Més informació: http://fsfeurope.org</p>
news/2003/news-20030624-01.it.xml
16:    <link>http://mail.fsfeurope.org/pipermail/press-release-it/2003q2/000011.html</link>

edit: Addressed by #1425 - merged

news/2002/article2002-01-18-01.en.xhtml
77:      More information: <a href="/">http://fsfeurope.org/</a>

edit: Addressed by #1431 - pending

Codified email addresses:

news/2009/news-20090414-01.el.xhtml
145: Εκτελεστικό Συμβούλιο του FSFE στο council -- AT -- fsfeurope.org,

More specific URLs:

news/2004/news-20040726-01.it.xml
14:      http://www.<i>area</i>.fsfeurope.org/news/news.<i>lingua</i>.rss,
16:      http://www.<i>area</i>.fsfeurope.org/events/events.<i>lingua</i>.rss.
18:      http://www.italy.fsfeurope.org/news/news.it.rss.<br />

Files:

about/people/greve/greve.de.xhtml
82:    als <a href="http://download.fsfeurope.org/audio/20090331-Greve-Paris.ogg">OGG
84:    und <a href="http://download.fsfeurope.org/audio/20090331-Greve-Paris.mp3">MP3</a>

edit: Addressed by #1429 - pending

activities/education/tgs/tagatschool6.de.xhtml
34:"http://www.fsfeurope.org/activities/education/tgs/tgs.fr.html">Französisch
40:"http://www.fsfeurope.org/activities/education/tgs/">Homepage
269:"http://www.fsfeurope.org/activities/education/tgs/tgs.fr.html">Übersetzung
453:"http://www.fsfeurope.org/activities/education/tgs/">[7]</a> ;-)
473:"http://www.fsfeurope.org/activities/education/tgs/tgs.fr.html">TUX&amp;GNU@school
476:"http://www.fsfeurope.org/activities/education/tgs/">Einschreibemöglichkeit
activities/policy/fp6/focal.en.xhtml
410:<td align="left">http://fsfeurope.org</td>
855:<tt>http://fsfeurope.org/documents/whyfs.en.html</tt>, this
862:<dd>Online at <tt>http://fsfeurope.org/activities/policy/fp6/recommendation.html</tt>.</dd>
news/2012/news-20120124-01.en.xml
<link>http://fsfe.org/campaigns/ilovefs/2012/ilovefs.en.html</link>

edit: Addressed by #1431 - pending

Check: https://git.fsfe.org/FSFE/fsfe-website/pulls/1424 I noticed that there are still some things to be replaced: ### No links: ``` news/2008/news-20080228-01.ca.xhtml 58:Més informació: http://fsfeurope.org</p> ``` ### Mailman links: ``` news/2003/news-20030624-01.it.xml 16: <link>http://mail.fsfeurope.org/pipermail/press-release-it/2003q2/000011.html</link> ``` **edit:** Addressed by #1425 - merged ### Link names (not the actual hyperlink): ``` news/2002/article2002-01-18-01.en.xhtml 77: More information: <a href="/">http://fsfeurope.org/</a> ``` **edit:** Addressed by #1431 - pending ### Codified email addresses: ``` news/2009/news-20090414-01.el.xhtml 145: Εκτελεστικό Συμβούλιο του FSFE στο council -- AT -- fsfeurope.org, ``` ### More specific URLs: ``` news/2004/news-20040726-01.it.xml 14: http://www.<i>area</i>.fsfeurope.org/news/news.<i>lingua</i>.rss, 16: http://www.<i>area</i>.fsfeurope.org/events/events.<i>lingua</i>.rss. 18: http://www.italy.fsfeurope.org/news/news.it.rss.<br /> ``` ### Files: ``` about/people/greve/greve.de.xhtml 82: als <a href="http://download.fsfeurope.org/audio/20090331-Greve-Paris.ogg">OGG 84: und <a href="http://download.fsfeurope.org/audio/20090331-Greve-Paris.mp3">MP3</a> ``` **edit:** Addressed by #1429 - pending ### Other links: ``` activities/education/tgs/tagatschool6.de.xhtml 34:"http://www.fsfeurope.org/activities/education/tgs/tgs.fr.html">Französisch 40:"http://www.fsfeurope.org/activities/education/tgs/">Homepage 269:"http://www.fsfeurope.org/activities/education/tgs/tgs.fr.html">Übersetzung 453:"http://www.fsfeurope.org/activities/education/tgs/">[7]</a> ;-) 473:"http://www.fsfeurope.org/activities/education/tgs/tgs.fr.html">TUX&amp;GNU@school 476:"http://www.fsfeurope.org/activities/education/tgs/">Einschreibemöglichkeit ``` ### Links in tables?: ``` activities/policy/fp6/focal.en.xhtml 410:<td align="left">http://fsfeurope.org</td> 855:<tt>http://fsfeurope.org/documents/whyfs.en.html</tt>, this 862:<dd>Online at <tt>http://fsfeurope.org/activities/policy/fp6/recommendation.html</tt>.</dd> ``` ### Links in events pages: ``` news/2012/news-20120124-01.en.xml <link>http://fsfe.org/campaigns/ilovefs/2012/ilovefs.en.html</link> ``` **edit:** Addressed by #1431 - pending
nico.rikken commented 2 months ago
Collaborator

I’ve created PR #1425 to solve the mailman links. Which actually solves a lot of broken links 🎉😃

I've created PR #1425 to solve the mailman links. Which actually solves a lot of broken links 🎉😃
nico.rikken commented 2 months ago
Collaborator

I’m looking into links back to the homepage, like <a href="http://fsfe.org">. I can change it to <a href="https://fsfe.org"> or <a href="/">. Of course the latter is no option for the drm.info and pdfreaders sections. Personally I prefer te "/" option. What do you think?

edit: I created #1428 to address this - merged

I'm looking into links back to the homepage, like `<a href="http://fsfe.org">`. I can change it to `<a href="https://fsfe.org">` or `<a href="/">`. Of course the latter is no option for the drm.info and pdfreaders sections. Personally I prefer te `"/"` option. What do you think? **edit:** I created #1428 to address this - merged
nico.rikken commented 2 months ago
Collaborator

I also noticed some links to the test.fsfe.org domain.

edit: the test URLs seems to be correct.

And in #1424 the suggestion came up to convert major website links to https:// (like wikipedia.org)

I also noticed some links to the `test.fsfe.org` domain. **edit:** the test URLs seems to be correct. And in #1424 the suggestion came up to convert major website links to `https://` (like `wikipedia.org`)
reinhard commented 2 months ago
Poster

Thank you so much for fixing all this step by step, I consider this a huge improvement for our whole website!

Personally I prefer te "/" option. What do you think?

I absolutely agree! I merged your pull request.

I also noticed some links to the test.fsfe.org domain.

Oh, wow. Some of them might be intentional (explaining that there is the test instance of the website), but where this obviuosly is not the case, it should also be changed.

And in #1424 the suggestion came up to convert major website links to https:// (like wikipedia.org)

I wouldn’t worry too much about these. We could probably spend hours every month to update external links that have changed...

Thank you so much for fixing all this step by step, I consider this a huge improvement for our whole website! > Personally I prefer te `"/"` option. What do you think? I absolutely agree! I merged your pull request. > I also noticed some links to the `test.fsfe.org` domain. Oh, wow. Some of them might be intentional (explaining that there is the test instance of the website), but where this obviuosly is not the case, it should also be changed. > And in #1424 the suggestion came up to convert major website links to `https://` (like `wikipedia.org`) I wouldn't worry too much about these. We could probably spend hours every month to update external links that have changed...
nico.rikken commented 2 months ago
Collaborator

Does it make sense to include some of these improvements into the automated build or testing process? The relevant links I can think of now:

  • Links to FSFE websites and domains are never plain http, always https
  • Links to fsfe.org are relative, not absolute

Other improvements related to this issue seem of a temporary nature. So once the fixes are in master, problems like fsfeurope.org domains and Mailman links are unlikely to return.

Depending on how the current CI/CD setup works, the URLs could also be changed automatically on a merge request, or be modified when building the website for publising.

Does it make sense to include some of these improvements into the automated build or testing process? The relevant links I can think of now: * Links to FSFE websites and domains are never plain `http`, always `https` * Links to `fsfe.org` are relative, not absolute Other improvements related to this issue seem of a temporary nature. So once the fixes are in master, problems like `fsfeurope.org` domains and Mailman links are unlikely to return. Depending on how the current CI/CD setup works, the URLs could also be changed automatically on a merge request, or be modified when building the website for publising.
reinhard commented 2 months ago
Poster

I think the best way to handle this would be in the pre-commit hook.

@max.mehl what do you think?

I think the best way to handle this would be in the pre-commit hook. @max.mehl what do you think?
nico.rikken commented 2 months ago
Collaborator

A point I’d like some feedback on:

There are plenty of links to the old fellowship pages: <a href="http://fellowship.fsfe.org/">. Looking for non-https links they stand out. But in practice they result in a 404 error. Should I update these to be https:// or leave them as they are?

A point I'd like some feedback on: There are plenty of links to the old fellowship pages: `<a href="http://fellowship.fsfe.org/">`. Looking for non-https links they stand out. But in practice they result in a 404 error. Should I update these to be `https://` or leave them as they are?
reinhard commented 2 months ago
Poster

@mk @max.mehl what do you think about how to handle links to fellowship.fsfe.org?

@mk @max.mehl what do you think about how to handle links to fellowship.fsfe.org?
mk commented 2 months ago
Owner

@nico.rikken do you have a list of what links that are? Maybe it makes more sense to update those links to point to fsfe.org/donate or to fsfe.org/contribute or maybe other parts.

@nico.rikken do you have a list of what links that are? Maybe it makes more sense to update those links to point to fsfe.org/donate or to fsfe.org/contribute or maybe other parts.
nico.rikken commented 2 months ago
Collaborator

@mk The link variants are limited:

$ ag -o --nofilename --nonumbers '"http(s)?://fellowship.fsfe(urope)?.org.*?"' | sort | uniq -c
    354 
    245 "http://fellowship.fsfe.org"
    126 "http://fellowship.fsfe.org/"
      5 "http://fellowship.fsfe.org/card.html"
      1 "http://fellowship.fsfe.org/contact.de.html"
      4 "http://fellowship.fsfe.org/contact.en.html"
      2 "http://fellowship.fsfe.org/grant.de.html"
      1 "http://fellowship.fsfe.org/grant.el.html"
      6 "http://fellowship.fsfe.org/grant.en.html"
      1 "http://fellowship.fsfe.org/grant.fr.html"
      4 "http://fellowship.fsfe.org/grant.html"
      2 "http://fellowship.fsfe.org/grant.it.html"
      5 "http://fellowship.fsfe.org/index.html"
      4 "http://fellowship.fsfe.org/interviews/greve/"
      4 "http://fellowship.fsfe.org/news/"
      5 "http://fellowship.fsfe.org/news.rss"
      1 "https://fellowship.fsfe.org/"
      6 "https://fellowship.fsfe.org/ams/join.php?ams=join"

It seems that all links are broken.

Thinking a bout it now, it seems as odd to land on a 404 error, as randomly ending up on a totally different page. Perhaps we need a simple redirect page that briefly explains that the fellowship is no longer, and there is still the option of supporting the FSFE through donations. It could include a link to the donation page. That would smooth the transition in case people click on an old link. Then again, just having the donation page might suffice. Looking through the link context briefly, a lot refer to donations directly, some also to membership.

I was looking for the fellowship interview of Georg Greve in archive.org, and found that even in 2009 this was handled using a redirect to the blogs.fsfe.org interview (see attached image).

So I suggest that we update those links to the new URL of the Greve interview: https://blogs.fsfe.org/fellowship-interviews/?p=27

@mk The link variants are limited: ``` $ ag -o --nofilename --nonumbers '"http(s)?://fellowship.fsfe(urope)?.org.*?"' | sort | uniq -c 354 245 "http://fellowship.fsfe.org" 126 "http://fellowship.fsfe.org/" 5 "http://fellowship.fsfe.org/card.html" 1 "http://fellowship.fsfe.org/contact.de.html" 4 "http://fellowship.fsfe.org/contact.en.html" 2 "http://fellowship.fsfe.org/grant.de.html" 1 "http://fellowship.fsfe.org/grant.el.html" 6 "http://fellowship.fsfe.org/grant.en.html" 1 "http://fellowship.fsfe.org/grant.fr.html" 4 "http://fellowship.fsfe.org/grant.html" 2 "http://fellowship.fsfe.org/grant.it.html" 5 "http://fellowship.fsfe.org/index.html" 4 "http://fellowship.fsfe.org/interviews/greve/" 4 "http://fellowship.fsfe.org/news/" 5 "http://fellowship.fsfe.org/news.rss" 1 "https://fellowship.fsfe.org/" 6 "https://fellowship.fsfe.org/ams/join.php?ams=join" ``` It seems that all links are broken. Thinking a bout it now, it seems as odd to land on a 404 error, as randomly ending up on a totally different page. Perhaps we need a simple redirect page that briefly explains that the fellowship is no longer, and there is still the option of supporting the FSFE through donations. It could include a link to the donation page. That would smooth the transition in case people click on an old link. Then again, just having the donation page might suffice. Looking through the link context briefly, a lot refer to donations directly, some also to membership. I was looking for the fellowship interview of Georg Greve in archive.org, and found that even in 2009 this was handled using a redirect to the blogs.fsfe.org interview (see attached image). So I suggest that we update those links to the new URL of the Greve interview: https://blogs.fsfe.org/fellowship-interviews/?p=27
mk commented 2 months ago
Owner

Thanks @nico.rikken

$ ag -o --nofilename --nonumbers ‘“http(s)?://fellowship.fsfe(urope)?.org.*?"’ | sort | uniq -c
354
245 “http://fellowship.fsfe.org
126 “http://fellowship.fsfe.org/

Those can both be forwarded to https://fsfe.org/donate

  5 "http://fellowship.fsfe.org/card.html"

Maybe this one can be forwarded to https://wiki.fsfe.org/TechDocs/CardHowtos or also just to the /donate.

  1 "http://fellowship.fsfe.org/contact.de.html"
  4 "http://fellowship.fsfe.org/contact.en.html"

They could both https://fsfe.org/contact

  2 "http://fellowship.fsfe.org/grant.de.html"
  1 "http://fellowship.fsfe.org/grant.el.html"
  6 "http://fellowship.fsfe.org/grant.en.html"
  1 "http://fellowship.fsfe.org/grant.fr.html"
  4 "http://fellowship.fsfe.org/grant.html"
  2 "http://fellowship.fsfe.org/grant.it.html"

IMHO they can be removed. (Now we have something similar, but this is internal docu https://wiki.fsfe.org/KnowHow/FSFELife/VolunteerAccountCreation )

  5 "http://fellowship.fsfe.org/index.html"

See above: /donate

  4 "http://fellowship.fsfe.org/interviews/greve/"

See below, I agree with forwarding it to blogs.fsfe.org, but maybe it is even better to just directly change the link on our pages to the correct link.

  4 "http://fellowship.fsfe.org/news/"

https://fsfe.org/news/

  5 "http://fellowship.fsfe.org/news.rss"

https://fsfe.org/news/news.en.rss

  1 "https://fellowship.fsfe.org/"
  6 "https://fellowship.fsfe.org/ams/join.php?ams=join"

Both again to /donate/

Thinking a bout it now, it seems as odd to land on a 404 error, as randomly ending up on a totally different page. Perhaps we need a simple redirect page that briefly explains that the fellowship is no longer, and there is still the option of supporting the FSFE through donations. It could include a link to the donation page. That would smooth the transition in case people click on an old link. Then again, just having the donation page might suffice. Looking through the link context briefly, a lot refer to donations directly, some also to membership.

Not a big fan of adding a new page to explain this. I would just use the /donate page as you said. Plus for some minor pages we could add forwardings or directly change the links in our pages (see the Fellowship interview).

Thank you!

Thanks @nico.rikken > $ ag -o --nofilename --nonumbers '"http(s)?://fellowship.fsfe(urope)?.org.*?"' | sort | uniq -c > 354 > 245 "http://fellowship.fsfe.org" > 126 "http://fellowship.fsfe.org/" Those can both be forwarded to https://fsfe.org/donate > 5 "http://fellowship.fsfe.org/card.html" Maybe this one can be forwarded to https://wiki.fsfe.org/TechDocs/CardHowtos or also just to the /donate. > 1 "http://fellowship.fsfe.org/contact.de.html" > 4 "http://fellowship.fsfe.org/contact.en.html" They could both https://fsfe.org/contact > 2 "http://fellowship.fsfe.org/grant.de.html" > 1 "http://fellowship.fsfe.org/grant.el.html" > 6 "http://fellowship.fsfe.org/grant.en.html" > 1 "http://fellowship.fsfe.org/grant.fr.html" > 4 "http://fellowship.fsfe.org/grant.html" > 2 "http://fellowship.fsfe.org/grant.it.html" IMHO they can be removed. (Now we have something similar, but this is internal docu https://wiki.fsfe.org/KnowHow/FSFELife/VolunteerAccountCreation ) > 5 "http://fellowship.fsfe.org/index.html" See above: /donate > 4 "http://fellowship.fsfe.org/interviews/greve/" See below, I agree with forwarding it to blogs.fsfe.org, but maybe it is even better to just directly change the link on our pages to the correct link. > 4 "http://fellowship.fsfe.org/news/" https://fsfe.org/news/ > 5 "http://fellowship.fsfe.org/news.rss" https://fsfe.org/news/news.en.rss > 1 "https://fellowship.fsfe.org/" > 6 "https://fellowship.fsfe.org/ams/join.php?ams=join" Both again to /donate/ > Thinking a bout it now, it seems as odd to land on a 404 error, as randomly ending up on a totally different page. Perhaps we need a simple redirect page that briefly explains that the fellowship is no longer, and there is still the option of supporting the FSFE through donations. It could include a link to the donation page. That would smooth the transition in case people click on an old link. Then again, just having the donation page might suffice. Looking through the link context briefly, a lot refer to donations directly, some also to membership. Not a big fan of adding a new page to explain this. I would just use the /donate page as you said. Plus for some minor pages we could add forwardings or directly change the links in our pages (see the Fellowship interview). Thank you!
reinhard commented 2 months ago
Poster

I would suggest to change the links instead of forwarding.

Also, I would suggest https://my.fsfe.org/donate instead of https://fsfe.org/donate.

Third, if you change the links, please link to a file (e.g. https://fsfe.org/contact/index.html) instead of a directory (like https://fsfe.org/contact/), so the build script will automatically insert the correct language into the link.

I would suggest to change the links instead of forwarding. Also, I would suggest https://my.fsfe.org/donate instead of https://fsfe.org/donate. Third, if you change the links, please link to a file (e.g. https://fsfe.org/contact/index.html) instead of a directory (like https://fsfe.org/contact/), so the build script will automatically insert the correct language into the link.
nico.rikken commented 1 month ago
Collaborator

@mk thanks, I’ve almost got that replacement scripted, so I can open a merge request.

I noticed a link where the link text was still the fellowship.fsfe.org domain, but was actually linking to the donation page:

news/nl/nl-200904.en.xhtml:
<a href="https://my.fsfe.org/donate">http://fellowship.fsfe.org/join</a>

Do you want me to update the link texts as well in case they specify the URL?

In the case above, that would result in:

- <a href="https://my.fsfe.org/donate">http://fellowship.fsfe.org/join</a>
+ <a href="https://my.fsfe.org/donate">https://fsfe.org/donate</a>
@mk thanks, I've almost got that replacement scripted, so I can open a merge request. I noticed a link where the link text was still the fellowship.fsfe.org domain, but was actually linking to the donation page: ``` news/nl/nl-200904.en.xhtml: <a href="https://my.fsfe.org/donate">http://fellowship.fsfe.org/join</a> ``` Do you want me to update the link texts as well in case they specify the URL? In the case above, that would result in: ``` - <a href="https://my.fsfe.org/donate">http://fellowship.fsfe.org/join</a> + <a href="https://my.fsfe.org/donate">https://fsfe.org/donate</a> ```
reinhard commented 1 month ago
Poster

Since @mk is on vacation for the next 2 weeks, I dare to say that it makes more sense to also change the link text, so let’s do it that way.

Since @mk is on vacation for the next 2 weeks, I dare to say that it makes more sense to also change the link text, so let's do it that way.
max.mehl commented 1 month ago
Owner

I agree to this approach, thanks @nico.rikken!

Regarding the pre-commit hook: I do not think that we need to check for http:// in fsfe.org domains, I didn’t see them in a long time. For relative links, I can include a check in the pre-commit commit routine that looks for https?://fsfe(urope)?.org. However, if a match is found, I would not abort it because some subsites, e.g. DRM or pdfreaders, do require an absolute URL. So this would be a warning, just like some other checks.

Would that be OK for you?

I agree to this approach, thanks @nico.rikken! Regarding the pre-commit hook: I do not think that we need to check for http:// in fsfe.org domains, I didn't see them in a long time. For relative links, I can include a check in the pre-commit commit routine that looks for `https?://fsfe(urope)?.org`. However, if a match is found, I would not abort it because some subsites, e.g. DRM or pdfreaders, do require an absolute URL. So this would be a warning, just like some other checks. Would that be OK for you?
nico.rikken commented 1 month ago
Collaborator

@reinhard

Regarding the fellowship replacement:

Also, I would suggest https://my.fsfe.org/donate instead of https://fsfe.org/donate.

Currently there are different links:

  • https://my.fsfe.org/donate
  • /donate/donate
  • /donate/donate.html
  • /donate/donate.en.html

Which should I default to? To me /donate/donate or /donate/donate.html seem to make most sense, rather than directly referring to a subdomain. But I’m missing context here, so I hope you can fill me in.

Also, can I drop the language-specific links in the search-replace action? For example a Dutch (nl) translation contains a link to the English contact page. Can I drop it like so: ?

--- a/news/2010/news-20100129-01.nl.xhtml
+++ b/news/2010/news-20100129-01.nl.xhtml
-      het <a href="http://fellowship.fsfe.org/contact.en.html">het
+      het <a href="/contact/contact.html">het
@reinhard Regarding the fellowship replacement: > Also, I would suggest https://my.fsfe.org/donate instead of https://fsfe.org/donate. Currently there are different links: * `https://my.fsfe.org/donate` * `/donate/donate` * `/donate/donate.html` * `/donate/donate.en.html` Which should I default to? To me `/donate/donate` or `/donate/donate.html` seem to make most sense, rather than directly referring to a subdomain. But I'm missing context here, so I hope you can fill me in. Also, can I drop the language-specific links in the search-replace action? For example a Dutch (nl) translation contains a link to the English contact page. Can I drop it like so: ? ``` --- a/news/2010/news-20100129-01.nl.xhtml +++ b/news/2010/news-20100129-01.nl.xhtml - het <a href="http://fellowship.fsfe.org/contact.en.html">het + het <a href="/contact/contact.html">het ```
reinhard commented 1 month ago
Poster

Currently there are different links:

  • https://my.fsfe.org/donate
  • /donate/donate
  • /donate/donate.html
  • /donate/donate.en.html

Which should I default to?

https://my.fsfe.org/donate, this is where most other “donate” or “become a supporter” links already point to as well.

To me /donate/donate or /donate/donate.html seem to make most sense, rather than directly referring to a subdomain. But I’m missing context here, so I hope you can fill me in.

/donate/donate.html was a page where one could choose whether to donate one-time or become a supporter, and then be forwarded to different forms. We now have a single form for both purposes, so the step in between is not necessary any more. /donate/donate.html now forwards to https://my.fsfe.org/donate anyway.

Also, can I drop the language-specific links in the search-replace action? For example a Dutch (nl) translation contains a link to the English contact page. Can I drop it like so: ?

--- a/news/2010/news-20100129-01.nl.xhtml
+++ b/news/2010/news-20100129-01.nl.xhtml
-      het <a href="http://fellowship.fsfe.org/contact.en.html">het
+      het <a href="/contact/contact.html">het

Yes, exactly.

> Currently there are different links: > * `https://my.fsfe.org/donate` > * `/donate/donate` > * `/donate/donate.html` > * `/donate/donate.en.html` > > Which should I default to? https://my.fsfe.org/donate, this is where most other "donate" or "become a supporter" links already point to as well. > To me `/donate/donate` or `/donate/donate.html` seem to make most sense, rather than directly referring to a subdomain. But I'm missing context here, so I hope you can fill me in. `/donate/donate.html` was a page where one could choose whether to donate one-time or become a supporter, and then be forwarded to different forms. We now have a single form for both purposes, so the step in between is not necessary any more. `/donate/donate.html` now forwards to https://my.fsfe.org/donate anyway. > Also, can I drop the language-specific links in the search-replace action? For example a Dutch (nl) translation contains a link to the English contact page. Can I drop it like so: ? > > ``` > --- a/news/2010/news-20100129-01.nl.xhtml > +++ b/news/2010/news-20100129-01.nl.xhtml > - het <a href="http://fellowship.fsfe.org/contact.en.html">het > + het <a href="/contact/contact.html">het > ``` Yes, exactly.
nico.rikken commented 1 month ago
Collaborator

I’d like to remove the fsfeurope.org email adresses as well. Can I just convert the @fsfeurope.org domain to @fsfe.org, or should it be changed to @lists.fsfe.org?

Some e-mail adresses that are linked directly:

$ ag -o --nofilename --nonumbers 'mailto:[^<>]*fsfeurope.org' | sed "/^[[:space:]]*$/d" | sort | uniq -c | sort -nr
     19 mailto:dus@office.fsfeurope.org
      8 mailto:team@fsfeurope.org
      8 mailto:finland@fsfeurope.org
      7 mailto:morant@fsfeurope.org
      7 mailto:announce-request@fsfeurope.org
      6 mailto:rk@office.fsfeurope.org
      6 mailto:discussion-request@fsfeurope.org
      5 mailto:italy@fsfeurope.org
      5 mailto:groot@fsfeurope.org
      5 mailto:editors@fsfeurope.org
      4 mailto:west@fsfeurope.org
      3 mailto:uk@fsfeurope.org
      3 mailto:germany@fsfeurope.org
      2 mailto:oberg@fsfeurope.org
      2 mailto:legal@fsfeurope.org
      1 mailto:loic@fsfeurope.org
      1 mailto:announce@fsfeurope.org

Some adresses are constructed like team at fsfe.org, team @ fsfe.org and similar. I can update those later.

I'd like to remove the `fsfeurope.org` email adresses as well. Can I just convert the `@fsfeurope.org` domain to `@fsfe.org`, or should it be changed to `@lists.fsfe.org`? Some e-mail adresses that are linked directly: ``` $ ag -o --nofilename --nonumbers 'mailto:[^<>]*fsfeurope.org' | sed "/^[[:space:]]*$/d" | sort | uniq -c | sort -nr 19 mailto:dus@office.fsfeurope.org 8 mailto:team@fsfeurope.org 8 mailto:finland@fsfeurope.org 7 mailto:morant@fsfeurope.org 7 mailto:announce-request@fsfeurope.org 6 mailto:rk@office.fsfeurope.org 6 mailto:discussion-request@fsfeurope.org 5 mailto:italy@fsfeurope.org 5 mailto:groot@fsfeurope.org 5 mailto:editors@fsfeurope.org 4 mailto:west@fsfeurope.org 3 mailto:uk@fsfeurope.org 3 mailto:germany@fsfeurope.org 2 mailto:oberg@fsfeurope.org 2 mailto:legal@fsfeurope.org 1 mailto:loic@fsfeurope.org 1 mailto:announce@fsfeurope.org ``` Some adresses are constructed like `team at fsfe.org`, `team @ fsfe.org` and similar. I can update those later.
max.mehl commented 1 month ago
Owner

Ah, this is a tricky one. Here the better addresses one by one:

dus@office.fsfeurope.org - contact@fsfe.org
team@fsfeurope.org - contact@fsfe.org
finland@fsfeurope.org - contact@fsfe.org
morant@fsfeurope.org - private address
announce-request@fsfeurope.org - contact@fsfe.org
rk@office.fsfeurope.org - contact@fsfe.org
discussion-request@fsfeurope.org - (not sure about the context, but in this case lists.fsfe.org?)
italy@fsfeurope.org - italy@lists.fsfe.org
groot@fsfeurope.org - private address, disabled
editors@fsfeurope.org - contact@fsfe.org or web@lists.fsfe.org
west@fsfeurope.org - ?
uk@fsfeurope.org - contact@fsfe.org
germany@fsfeurope.org - germany@lists.fsfe.org
oberg@fsfeurope.org - jonas@fsfe.org
legal@fsfeurope.org - contact@fsfe.org
loic@fsfeurope.org - ?
announce@fsfeurope.org - contact@fsfe.org

Why so many contact@? The ticket system has been introduces just a few years back, and since then we can easily dispatch requests to the respective teams.

Also: rather than using the email addresses directly, would it make more sense to link to fsfe.org/contact instead of contact@fsfe.org?

Ah, this is a tricky one. Here the better addresses one by one: ``` dus@office.fsfeurope.org - contact@fsfe.org team@fsfeurope.org - contact@fsfe.org finland@fsfeurope.org - contact@fsfe.org morant@fsfeurope.org - private address announce-request@fsfeurope.org - contact@fsfe.org rk@office.fsfeurope.org - contact@fsfe.org discussion-request@fsfeurope.org - (not sure about the context, but in this case lists.fsfe.org?) italy@fsfeurope.org - italy@lists.fsfe.org groot@fsfeurope.org - private address, disabled editors@fsfeurope.org - contact@fsfe.org or web@lists.fsfe.org west@fsfeurope.org - ? uk@fsfeurope.org - contact@fsfe.org germany@fsfeurope.org - germany@lists.fsfe.org oberg@fsfeurope.org - jonas@fsfe.org legal@fsfeurope.org - contact@fsfe.org loic@fsfeurope.org - ? announce@fsfeurope.org - contact@fsfe.org ``` Why so many contact@? The ticket system has been introduces just a few years back, and since then we can easily dispatch requests to the respective teams. Also: rather than using the email addresses directly, would it make more sense to link to fsfe.org/contact instead of contact@fsfe.org?
nico.rikken commented 1 month ago
Collaborator

@max.mehl I like your proposal to refer to the contact page. That would require a more manual replacement, but I’ll have a look at it.

@max.mehl I like your proposal to refer to the contact page. That would require a more manual replacement, but I'll have a look at it.
nico.rikken commented 1 month ago
Collaborator

@max.mehl some additional email adresses I found, in different formatting:

austria @ fsfeurope.org
coughlan @ fsfeurope.org
council @ fsfeurope.org
editors @ fsfeurope.org
edu-team @ fsfeurope.org
finland @ fsfeurope.org
fla-bacula @ fsfeurope.org
france @ fsfeurope.org
ftf @ fsfeurope.org
jelic @ fsfeurope.org
kersten @ fsfeurope.org
loic @ fsfeurope.org
milenovic @ fsfeurope.org
morant @ fsfeurope.org
office @ fsfeurope.org
policies @ fsfeurope.org
system-hackers @ fsfeurope.org
translators @ fsfeurope.org
vianna @ fsfeurope.org
weiden @ fsfeurope.org

Can you please provide a similar set of alternative addresses?

@max.mehl some additional email adresses I found, in different formatting: ``` austria @ fsfeurope.org coughlan @ fsfeurope.org council @ fsfeurope.org editors @ fsfeurope.org edu-team @ fsfeurope.org finland @ fsfeurope.org fla-bacula @ fsfeurope.org france @ fsfeurope.org ftf @ fsfeurope.org jelic @ fsfeurope.org kersten @ fsfeurope.org loic @ fsfeurope.org milenovic @ fsfeurope.org morant @ fsfeurope.org office @ fsfeurope.org policies @ fsfeurope.org system-hackers @ fsfeurope.org translators @ fsfeurope.org vianna @ fsfeurope.org weiden @ fsfeurope.org ``` Can you please provide a similar set of alternative addresses?
max.mehl commented 1 month ago
Owner

Ah sure!

austria @ fsfeurope.org - austria@lists.fsfe.org
coughlan @ fsfeurope.org - contact@fsfe.org
council @ fsfeurope.org - contact@fsfe.org
editors @ fsfeurope.org - contact@fsfe.org or web@lists.fsfe.org
edu-team @ fsfeurope.org - contact@fsfe.org
finland @ fsfeurope.org - contact@fsfe.org
fla-bacula @ fsfeurope.org - contact@fsfe.org
france @ fsfeurope.org - france@lists.fsfe.org
ftf @ fsfeurope.org - contact@fsfe.org
jelic @ fsfeurope.org - private
kersten @ fsfeurope.org - contact@fsfe.org
loic @ fsfeurope.org - private
milenovic @ fsfeurope.org - private
morant @ fsfeurope.org - private
office @ fsfeurope.org - contact@fsfe.org
policies @ fsfeurope.org - contact@fsfe.org
system-hackers @ fsfeurope.org - contact@fsfe.org
translators @ fsfeurope.org - translators@lists.fsfe.org
vianna @ fsfeurope.org - ? vienna?
weiden @ fsfeurope.org - nanda@fsfe.org

can we remove the deprecated private addresses altogether? Otherwise, contact@fsfe.org or /contact would work.

Ah sure! ``` austria @ fsfeurope.org - austria@lists.fsfe.org coughlan @ fsfeurope.org - contact@fsfe.org council @ fsfeurope.org - contact@fsfe.org editors @ fsfeurope.org - contact@fsfe.org or web@lists.fsfe.org edu-team @ fsfeurope.org - contact@fsfe.org finland @ fsfeurope.org - contact@fsfe.org fla-bacula @ fsfeurope.org - contact@fsfe.org france @ fsfeurope.org - france@lists.fsfe.org ftf @ fsfeurope.org - contact@fsfe.org jelic @ fsfeurope.org - private kersten @ fsfeurope.org - contact@fsfe.org loic @ fsfeurope.org - private milenovic @ fsfeurope.org - private morant @ fsfeurope.org - private office @ fsfeurope.org - contact@fsfe.org policies @ fsfeurope.org - contact@fsfe.org system-hackers @ fsfeurope.org - contact@fsfe.org translators @ fsfeurope.org - translators@lists.fsfe.org vianna @ fsfeurope.org - ? vienna? weiden @ fsfeurope.org - nanda@fsfe.org ``` can we remove the deprecated private addresses altogether? Otherwise, contact@fsfe.org or /contact would work.
nico.rikken commented 1 month ago
Collaborator

I noticed http:// links in other files, like .svg, .xsl, .php, .pl and .txt. I’ll take a look at those as well.

I noticed `http://` links in other files, like `.svg`, `.xsl`, `.php`, `.pl` and `.txt`. I'll take a look at those as well.
max.mehl commented 2 weeks ago
Owner

@nico.rikken, you touched so many files and improved so many bits that I lost oversight (which is a good sign, so thanks a bunch!). Do you think we’ve fixed all of them now, or are there still open issues?

@nico.rikken, you touched so many files and improved so many bits that I lost oversight (which is a good sign, so thanks a bunch!). Do you think we've fixed all of them now, or are there still open issues?
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.