florian.vuillemot florian.vuillemot
  • Paris
  • Joined on 2019-02-11
florian.vuillemot commented on pull request fsfe-system-hackers/forms#114 2023-08-07 08:02:35 +00:00
WIP: Using PostgreSQL instead of JSON

@reinhard

Back then when I thought about the idea of using an SQL database instead of JSON, I would have planned to use a separate table for each application, where the include_vars are…

florian.vuillemot commented on pull request fsfe-system-hackers/forms#114 2023-08-05 08:54:54 +00:00
WIP: Using PostgreSQL instead of JSON

@reinhard I'm talking about these emails for the "logged" table. These emails do not need to be validated and are stored.

florian.vuillemot pushed to feature/#25-json-to-sql at fsfe-system-hackers/forms 2023-08-03 15:54:04 +00:00
0cc3ac473b Limit packages updates
florian.vuillemot commented on pull request fsfe-system-hackers/forms#114 2023-08-03 14:16:19 +00:00
WIP: Using PostgreSQL instead of JSON

Thank you @reinhard

How about creating two tables? One for "logged" emails and one for "confirmed" emails. I assume that never confirmed emails are not usable and are kept for compliance?

florian.vuillemot commented on pull request fsfe-system-hackers/forms#114 2023-07-31 20:30:48 +00:00
WIP: Using PostgreSQL instead of JSON

Keeping the .json and the database together at the start may be preferable. This allows us to check that the behaviour is correct.

At the same time, we can start migrating other…

florian.vuillemot pushed to feature/#25-json-to-sql at fsfe-system-hackers/forms 2023-07-31 20:28:23 +00:00
3fe08e8455 REUSE
florian.vuillemot commented on pull request fsfe-system-hackers/forms#114 2023-07-31 20:25:51 +00:00
WIP: Using PostgreSQL instead of JSON

@linus @reinhard

I am confused about the JSON storage system. Please correct me if I am wrong: when an email needs to be confirmed, it is not written to the log file until is confirmed.…

florian.vuillemot pushed to feature/#25-json-to-sql at fsfe-system-hackers/forms 2023-07-31 20:14:42 +00:00
1bce734f25 Add the email in the datetime without considering it as confirmable
florian.vuillemot reopened pull request fsfe-system-hackers/forms#114 2023-07-31 18:12:06 +00:00
WIP: Using PostgreSQL instead of JSON
florian.vuillemot closed pull request fsfe-system-hackers/forms#114 2023-07-31 18:11:50 +00:00
WIP: Using PostgreSQL instead of JSON
florian.vuillemot pushed to feature/#25-json-to-sql at fsfe-system-hackers/forms 2023-07-31 18:10:28 +00:00
a645e14617 Update tests
florian.vuillemot pushed to feature/#25-json-to-sql at fsfe-system-hackers/forms 2023-07-31 14:40:54 +00:00
9c0d33bcba Init Flask database
florian.vuillemot pushed to feature/#25-json-to-sql at fsfe-system-hackers/forms 2023-07-25 08:09:29 +00:00
c8a494a6af Continue to use json fomrat
florian.vuillemot commented on pull request fsfe-system-hackers/forms#114 2023-07-19 16:40:34 +00:00
WIP: Using PostgreSQL instead of JSON

Keeping the .json and the database together at the start may be preferable. This allows us to check that the behaviour is correct.

At the same time, we can start migrating other components to…

florian.vuillemot pushed to feature/#25-json-to-sql at fsfe-system-hackers/forms 2023-07-12 20:25:21 +00:00
c3d2c05753 Using the email database model in place of the json
f45746938b Primary key and fix nullable columns
Compare 2 commits »
florian.vuillemot pushed to feature/#25-json-to-sql at fsfe-system-hackers/forms 2023-07-12 20:16:53 +00:00
a7ae6edf7b Update the email model
ea7fa52e95 Remove useless import
Compare 2 commits »
florian.vuillemot commented on pull request fsfe-system-hackers/forms#114 2023-07-10 20:28:41 +00:00
WIP: Using PostgreSQL instead of JSON

It's as if I'd updated all the Pipenv.lock files and this wasn't planned. Should I go back or is it OK?

florian.vuillemot commented on pull request fsfe-system-hackers/forms#114 2023-07-10 20:21:26 +00:00
WIP: Using PostgreSQL instead of JSON

@linus if I understand correctly, the REUSE API is not using PostgreSQL for development (https://git.fsfe.org/reuse/api/pulls/71/files#diff-a8af255e3836e7327821285b1659791a79535e7b). Should we do the same here?

florian.vuillemot created pull request fsfe-system-hackers/forms#114 2023-07-10 20:16:10 +00:00
Using PostgreSQL instead of JSON
florian.vuillemot created branch feature/#25-json-to-sql in fsfe-system-hackers/forms 2023-07-10 20:13:48 +00:00