florian.vuillemot

florian.vuillemot commented on issue fsfe-system-hackers/forms#49

2019-07-31 20:24:06 +00:00

Redesign template configuration (#44)

I love this PR. That cleans a lot of stuff !

florian.vuillemot commented on issue fsfe-system-hackers/forms#49

2019-07-28 22:41:47 +00:00

Redesign template configuration (#44)

Ok :)

florian.vuillemot commented on issue fsfe-system-hackers/forms#49

2019-07-27 20:20:13 +00:00

Redesign template configuration (#44)

@reinhard I had 2 comments. I'm preparing an exam for monday. So, I read the code quickly without testing it...

florian.vuillemot commented on issue fsfe-system-hackers/forms#49

2019-07-27 20:16:13 +00:00

Redesign template configuration (#44)

dict(data) ? But data it's already a dict according to typing.

florian.vuillemot commented on issue fsfe-system-hackers/forms#49

2019-07-26 21:43:15 +00:00

Redesign template configuration (#44)

Waoo, everything becomes more simple, I really like it !

florian.vuillemot commented on issue fsfe-system-hackers/forms#49

2019-07-26 21:22:17 +00:00

Redesign template configuration (#44)

Maybe create a tmp variable for old_data.request_data and data.request_data ?

florian.vuillemot commented on issue fsfe-system-hackers/forms#46

2019-07-15 20:15:41 +00:00

Improve general architecture

Amazing job @reinhard !

florian.vuillemot commented on issue fsfe-system-hackers/forms#43

2019-07-13 23:59:48 +00:00

#23 Merge emails parameters (application.json + template.json)

@max.mehl could you validate that everything is good please ? :)

florian.vuillemot commented on issue fsfe-system-hackers/forms#43

2019-07-13 20:08:29 +00:00

#23 Merge emails parameters (application.json + template.json)

@reinhard so about 'allowed_vars',do you have any plans about this variable or can I move it to the config file and factorize SenderService.py ?

florian.vuillemot pushed to refacto/simplify_config at fsfe-system-hackers/forms

2019-07-13 20:03:00 +00:00

56d342b3c9 Add typing

florian.vuillemot closed pull request fsfe-system-hackers/forms#45

2019-07-13 19:27:59 +00:00

Some suggestions to further clean up code after config simplifying

florian.vuillemot merged pull request fsfe-system-hackers/forms#45

2019-07-13 19:27:59 +00:00

Some suggestions to further clean up code after config simplifying

florian.vuillemot commented on issue fsfe-system-hackers/forms#45

2019-07-13 19:27:42 +00:00

Some suggestions to further clean up code after config simplifying

Omg this cleans a lot of horrible code ! Thank you !!!!

florian.vuillemot commented on issue fsfe-system-hackers/forms#26

2019-07-13 18:09:17 +00:00

Docker image footprint is quite big

@reinhard Yes, let's go :)

florian.vuillemot commented on issue fsfe-system-hackers/forms#43

2019-07-12 21:37:35 +00:00

#23 Merge emails parameters (application.json + template.json)

Ok perfect !

florian.vuillemot pushed to refacto/simplify_config at fsfe-system-hackers/forms

2019-07-12 21:22:45 +00:00

1414c91061 Renaming

florian.vuillemot commented on issue fsfe-system-hackers/forms#43

2019-07-12 09:48:46 +00:00

#23 Merge emails parameters (application.json + template.json)

@reinhard perfect for "allowed_vars" I will just rename the variable and let it in this file :)

florian.vuillemot commented on issue fsfe-system-hackers/forms#43

2019-07-11 22:01:10 +00:00

#23 Merge emails parameters (application.json + template.json)

@reinhard

florian.vuillemot pushed to refacto/simplify_config at fsfe-system-hackers/forms

2019-07-11 22:00:13 +00:00

0a3bd9270e Refactoring

florian.vuillemot pushed to refacto/simplify_config at fsfe-system-hackers/forms

2019-07-11 21:27:09 +00:00

d0e7348729 Renaming