Deleting a branch is permanent. It CANNOT be undone. Continue?
#818 first draft of publishing chapters from the brochure
Open
eal
wants to merge 3 commits from eal/fsfe-website:firstchapterdraft into master
Labels
No Label
Milestone
No Milestone
Assignees
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
This pull request currently doesn't have any dependencies.
Loading…
There is no content yet.
Delete Branch 'eal/fsfe-website:firstchapterdraft'
This is a first draft for future publications of individual chapters from the pmpc-brochure. As this is the first time I have been working on the LESS/CSS, @max.mehl can you please have a look before merging?
That’s not necessary, bootstrap offers img-circle: https://getbootstrap.com/docs/3.3/css/#images
Why do you indent here and below? Let’s try to keep a unified indenting scheme, so perhaps 2 or 4 spaces or 1 tab.
Also, it makes sense to first define the div and then the img it contains. An hierarchical structure makes things easier to understand.
I would not put the single image in a div, you could add all classes to the img directly: img-circle, pull-right (instead of float-style). If you uploaded the picture in 80px*80px, you would not even have to define the max-width.
This misses a class/id or whatever. After media, you have a normal declaration of a target
Can’t we just use the blockquote tag?
Blanklines. Blanklines everywhere :D
Indentation went mad :P
Why using a custom class here? What’s wrong with out default one with a fixed width? Ideally max-width:556px (80% of 100% in full width)
The round picture requires a square picture, otherwise it looks like an egg ;)
We already have a footnotes style used in some places. E.g. have a look here: https://fsfe.org/about/funds/2017.en.html
@max.mehl i removed some of your proposed unnecessary styles, but I have to admit, I did not understood all of your comments. Generally this seems not to be a good workflow and I would like to propose that we either
i prefer the first one and see no problem with it. would that be ok with you?
I also think that the workflow we currently use for the testimonials pages works well, especially if we can use the test instance to see what we’re talking about :-)
@reinhard Thank you for the comment. Yes, that is also a good worflow, considering I understand how to work with the test-instance soon : )