FSFE/fsfe-website
25
31
Fork 92
Code Issues 65 Pull Requests 5 Wiki Activity

Fixed text for a more fluent read #3918

Merged
delliott merged 2 commits from about-page-small-changes into master 2024-07-30 08:35:52 +00:00
Conversation 2 Commits 2 Files Changed 1 +5 -5
bonnie commented 2023-12-05 09:50:08 +00:00
Member
Copy Link

While proofreading a translation I stumbled across the text on the about page and found it was not a very smooth reading experience. @floriansnow could you check my suggestions and give feedback on them?

While proofreading a translation I stumbled across the text on the about page and found it was not a very smooth reading experience. @floriansnow could you check my suggestions and give feedback on them?
bonnie requested review from floriansnow 2023-12-05 09:50:18 +00:00
floriansnow requested changes 2023-12-07 11:47:27 +00:00
floriansnow left a comment
Member
Copy Link

LGTM, except for the parts I commented.

LGTM, except for the parts I commented.
about/about.en.xhtml Outdated
@ -61,2 +60,2 @@
support the FSFE and our mission. Some also answered interviews or even
made a video. Enjoy getting to know our community!
Hear voices and read testimonials from our diverse community about why they
support the FSFE and our mission. Some have also answered interviews or even
floriansnow commented 2023-12-07 11:44:44 +00:00
Member
Copy Link

It was better without the 'have' and I would say 'interview questions' instead of 'interviews'.

It was better without the 'have' and I would say 'interview questions' instead of 'interviews'.
doczkal commented 2024-02-01 20:45:38 +00:00
Member
Copy Link

I agree with Florian

I agree with Florian
delliott marked this conversation as resolved
about/about.en.xhtml Outdated
@ -77,3 +77,3 @@
See who we are and get to know the people behind the FSFE. Here you
find the ones who are working for and with the FSFE and have been given
find those who work for and with the FSFE and who have been given
permanent responsibility or authority for certain areas - staffers
floriansnow commented 2023-12-07 11:46:06 +00:00
Member
Copy Link

Not technically part of your change, but I would suggest removing 'permanent' because it sounds far too permanent. :)

Not technically part of your change, but I would suggest removing 'permanent' because it sounds far too permanent. :)
doczkal commented 2024-02-01 20:45:19 +00:00
Member
Copy Link

maybe better with a "those" ... "and those who have been given" ? Can't pin it down it's just an idea.

maybe better with a "those" ... "and those who have been given" ? Can't pin it down it's just an idea.
delliott marked this conversation as resolved
delliott force-pushed about-page-small-changes from 5b6c7188be to 5b827b9121 2024-07-30 08:32:23 +00:00 Compare
delliott merged commit 0b260ab6a3 into master 2024-07-30 08:35:52 +00:00
delliott deleted branch about-page-small-changes 2024-07-30 08:36:14 +00:00
delliott commented 2024-07-30 08:37:04 +00:00
Member
Copy Link

After discussion with @bonnie and @tobiasd it was decided that I could apply the feedback recommended and merge the PR.

After discussion with @bonnie and @tobiasd it was decided that I could apply the feedback recommended and merge the PR.
Sign in to join this conversation.
Reviewers
No Reviewers
floriansnow
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bonnie cryptie dario delliott dmaphy doczkal eal egnun eventregbot fi floriansnow gabriel.ku guido hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard repentinus schiessle sofiaritz tobiasd vincent
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#3918
No description provided.
Delete Branch "about-page-small-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?