FSFE
/
fsfe-website
28
30
Fork 86
Code Issues 64 Pull Requests 13 Wiki Activity

Fixed text for a more fluent read #3918

Open
bonnie wants to merge 1 commits from about-page-small-changes into master
pull from: about-page-small-changes
merge into: FSFE:master
Conversation 0 Commits 1 Files Changed 1 +4 -4
bonnie commented 2023-12-05 09:50:08 +00:00
Member
Copy Link

While proofreading a translation I stumbled across the text on the about page and found it was not a very smooth reading experience. @floriansnow could you check my suggestions and give feedback on them?

While proofreading a translation I stumbled across the text on the about page and found it was not a very smooth reading experience. @floriansnow could you check my suggestions and give feedback on them?
bonnie added 1 commit 2023-12-05 09:50:10 +00:00
continuous-integration/drone/pr Build is passing Details
5b6c7188be Fixed text for a more fluent read
bonnie requested review from floriansnow 2023-12-05 09:50:18 +00:00
floriansnow requested changes 2023-12-07 11:47:27 +00:00
floriansnow left a comment
Member
Copy Link

LGTM, except for the parts I commented.

LGTM, except for the parts I commented.
about/about.en.xhtml
@ -61,2 +60,2 @@
support the FSFE and our mission. Some also answered interviews or even
made a video. Enjoy getting to know our community!
Hear voices and read testimonials from our diverse community about why they
support the FSFE and our mission. Some have also answered interviews or even
floriansnow commented 2023-12-07 11:44:44 +00:00
Member
Copy Link

It was better without the 'have' and I would say 'interview questions' instead of 'interviews'.

It was better without the 'have' and I would say 'interview questions' instead of 'interviews'.
doczkal commented 2024-02-01 20:45:38 +00:00
Member
Copy Link

I agree with Florian

I agree with Florian
about/about.en.xhtml
@ -77,3 +77,3 @@
See who we are and get to know the people behind the FSFE. Here you
find the ones who are working for and with the FSFE and have been given
find those who work for and with the FSFE and who have been given
permanent responsibility or authority for certain areas - staffers
floriansnow commented 2023-12-07 11:46:06 +00:00
Member
Copy Link

Not technically part of your change, but I would suggest removing 'permanent' because it sounds far too permanent. :)

Not technically part of your change, but I would suggest removing 'permanent' because it sounds far too permanent. :)
doczkal commented 2024-02-01 20:45:19 +00:00
Member
Copy Link

maybe better with a "those" ... "and those who have been given" ? Can't pin it down it's just an idea.

maybe better with a "those" ... "and those who have been given" ? Can't pin it down it's just an idea.
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
floriansnow
Labels
Clear labels   
bug

   
build

   
cgi Scripting

   
design

   
disruptive

Requires careful coordination and documentation changes

  
documentation

   
duplicate

   
easy

   
feature-request

   
help wanted

   
javascript

   
priority/low

   
question

   
system-hackers

   
tagging

   
text

   
translations

   
wait/bugfix

   
wait/inprogress

   
wait/misc

   
wait/proofread

   
wontfix

   
xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#3918
No description provided.
Delete Branch "about-page-small-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?