#33 Add outdated project only once to queue

Open
opened 1 year ago by max.mehl · 2 comments
max.mehl commented 1 year ago

When I tried to get the badge for a registered project that was outdated, the following happened after I reloaded the badge’s URL and the info page a few times:

[2019-09-10 09:56:35,368] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:56:35,369] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:56:35,369] (reuse_api) DEBUG: size of queue is 1
[2019-09-10 09:56:35,370] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website'
[2019-09-10 09:57:00,445] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:00,446] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:00,446] (reuse_api) DEBUG: size of queue is 2
[2019-09-10 09:57:01,744] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:01,745] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:01,746] (reuse_api) DEBUG: size of queue is 3
[2019-09-10 09:57:01,746] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website'
[2019-09-10 09:57:22,832] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:22,833] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:22,833] (reuse_api) DEBUG: size of queue is 4
[2019-09-10 09:57:23,461] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:23,462] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:23,462] (reuse_api) DEBUG: size of queue is 5
[2019-09-10 09:57:23,463] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website'
[2019-09-10 09:57:24,477] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:24,478] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:24,479] (reuse_api) DEBUG: size of queue is 6
[2019-09-10 09:57:25,174] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:25,175] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:25,175] (reuse_api) DEBUG: size of queue is 7
[2019-09-10 09:57:25,176] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website'
[2019-09-10 09:57:35,862] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:35,863] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:35,863] (reuse_api) DEBUG: size of queue is 8
[2019-09-10 09:57:36,457] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:36,458] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:36,458] (reuse_api) DEBUG: size of queue is 9
[2019-09-10 09:57:36,458] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website'
[2019-09-10 09:57:39,001] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:39,002] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:39,002] (reuse_api) DEBUG: size of queue is 10
[2019-09-10 09:57:40,629] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated
[2019-09-10 09:57:40,630] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue
[2019-09-10 09:57:40,631] (reuse_api) DEBUG: size of queue is 11
[2019-09-10 09:57:40,632] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website'

Unfortunately, at the same time, the badge didn’t show the “checking...” string, but stayed at being non-compliant (which was the status before and after the check).

It seems to me that the logic behind the automatic checks has to be refined a bit.

When I tried to get the badge for a registered project that was outdated, the following happened after I reloaded the badge's URL and the info page a few times: ``` [2019-09-10 09:56:35,368] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:56:35,369] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:56:35,369] (reuse_api) DEBUG: size of queue is 1 [2019-09-10 09:56:35,370] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website' [2019-09-10 09:57:00,445] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:00,446] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:00,446] (reuse_api) DEBUG: size of queue is 2 [2019-09-10 09:57:01,744] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:01,745] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:01,746] (reuse_api) DEBUG: size of queue is 3 [2019-09-10 09:57:01,746] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website' [2019-09-10 09:57:22,832] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:22,833] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:22,833] (reuse_api) DEBUG: size of queue is 4 [2019-09-10 09:57:23,461] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:23,462] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:23,462] (reuse_api) DEBUG: size of queue is 5 [2019-09-10 09:57:23,463] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website' [2019-09-10 09:57:24,477] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:24,478] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:24,479] (reuse_api) DEBUG: size of queue is 6 [2019-09-10 09:57:25,174] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:25,175] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:25,175] (reuse_api) DEBUG: size of queue is 7 [2019-09-10 09:57:25,176] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website' [2019-09-10 09:57:35,862] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:35,863] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:35,863] (reuse_api) DEBUG: size of queue is 8 [2019-09-10 09:57:36,457] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:36,458] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:36,458] (reuse_api) DEBUG: size of queue is 9 [2019-09-10 09:57:36,458] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website' [2019-09-10 09:57:39,001] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:39,002] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:39,002] (reuse_api) DEBUG: size of queue is 10 [2019-09-10 09:57:40,629] (reuse_api) DEBUG: 'git.fsfe.org/fsfe/fsfe-website' is outdated [2019-09-10 09:57:40,630] (reuse_api) DEBUG: adding 'git.fsfe.org/fsfe/fsfe-website' to queue [2019-09-10 09:57:40,631] (reuse_api) DEBUG: size of queue is 11 [2019-09-10 09:57:40,632] (reuse_api) DEBUG: sending badge for 'git.fsfe.org/fsfe/fsfe-website' ``` Unfortunately, at the same time, the badge didn't show the "checking..." string, but stayed at being non-compliant (which was the status before and after the check). It seems to me that the logic behind the automatic checks has to be refined a bit.
max.mehl added the
bug
label 1 year ago
max.mehl commented 9 months ago
Owner

Same for new projects, especially big ones. Each reload of the blank page triggers a new lint.

Same for new projects, especially big ones. Each reload of the blank page triggers a new lint.
max.mehl commented 9 months ago
Owner

Does not happen any more by making the api-worker spawn containers with a fixed name per project, but that’s obviously just a dirty hack. It also shows the wrong information that the lint is finished, but it’s actually still running.

Does not happen any more by making the api-worker spawn containers with a fixed name per project, but that's obviously just a dirty hack. It also shows the wrong information that the lint is finished, but it's actually still running.
florian.vuillemot was assigned by max.mehl 1 week ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.