#1 Dockerfile improvements

Closed
opened 9 months ago by vincent · 2 comments
vincent commented 9 months ago

1) We can merge lines 11 to 16 as they’re related:

RUN apt-get -q update && \
    apt-get -qy --allow-downgrades --allow-remove-essential --allow-change-held-packages upgrade && \
    apt-get install -y planet-venus/testing procps cron && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

This will make the docker image slimmer.

2) We can merge lines 54 to 67:

RUN find /home/venus/lang/ -name "planet_*.ini" -exec planet {} \;

It’s shorter and will work regardless of language addition / supression.

1) We can merge lines [11](https://git.fsfe.org/fsfe-system-hackers/fsfe-planet/src/commit/30f5c94ca483a5af2c72aeeac690fdb2234c6a8d/Dockerfile#L11) to [16](https://git.fsfe.org/fsfe-system-hackers/fsfe-planet/src/commit/30f5c94ca483a5af2c72aeeac690fdb2234c6a8d/Dockerfile#L11) as they're related: ```dockerfile RUN apt-get -q update && \ apt-get -qy --allow-downgrades --allow-remove-essential --allow-change-held-packages upgrade && \ apt-get install -y planet-venus/testing procps cron && \ apt-get clean && \ rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* ``` This will make the docker image slimmer. 2) We can merge lines [54](https://git.fsfe.org/fsfe-system-hackers/fsfe-planet/src/commit/30f5c94ca483a5af2c72aeeac690fdb2234c6a8d/Dockerfile#L54) to [67](https://git.fsfe.org/fsfe-system-hackers/fsfe-planet/src/commit/30f5c94ca483a5af2c72aeeac690fdb2234c6a8d/Dockerfile#L67): ```dockerfile RUN find /home/venus/lang/ -name "planet_*.ini" -exec planet {} \; ``` It's shorter and will work regardless of language addition / supression.
mweimann commented 9 months ago
Collaborator

See PR #7

See PR #7
max.mehl commented 9 months ago
Owner

Closed by #7. Thanks @mweimann !

Closed by #7. Thanks @mweimann !
Sign in to join this conversation.
No Label
No Milestone
No Assignees
3 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.