TEDective/etl
11
3
Fork 0
Code Issues 20 Pull Requests Actions Packages Projects Releases Wiki Activity

Currency conversion does not work on newer TED releases #28

New Issue
Closed
opened 2024-04-16 17:25:01 +00:00 by i.galabov · 4 comments
i.galabov commented 2024-04-16 17:25:01 +00:00
Member
Copy Link

In some cases, this is the problem.
image

When parsing, some values seem to have characters they are not supposed to have.

In some cases, this is the problem. ![image](/attachments/744c3799-5fae-4c04-9979-868eb9c6f7ae) When parsing, some values seem to have characters they are not supposed to have.
image.png
32 KiB
i.galabov added the
Kind/Bug
Priority
High
 labels 2024-04-16 17:25:01 +00:00
i.galabov added reference fix/currecny_conversion_BUG_new_TED 2024-04-16 18:18:33 +00:00
i.galabov commented 2024-04-16 18:20:00 +00:00
Author
Member
Copy Link

The branch I have added I implemented a change. So that I can continue working with the new structure of the archive. You can use the fix. Keep in mind I did not fully test it. It worked for me so I could continue with my issue.

The branch I have added I implemented a change. So that I can continue working with the new structure of the archive. You can use the fix. Keep in mind I did not fully test it. It worked for me so I could continue with my issue.
micgor32 commented 2024-04-16 19:50:48 +00:00
Owner
Copy Link

In some cases, this is the problem.
image

When parsing, some values seem to have characters they are not supposed to have.

Could you provide bit more backtrace, or steps how to reproduce the error? Would save me a bit of time :D

> In some cases, this is the problem. > ![image](/attachments/744c3799-5fae-4c04-9979-868eb9c6f7ae) > > When parsing, some values seem to have characters they are not supposed to have. Could you provide bit more backtrace, or steps how to reproduce the error? Would save me a bit of time :D
i.galabov commented 2024-04-16 22:39:59 +00:00
Author
Member
Copy Link

./result/bin/run-pipeline --first-month 2023-02 --last-month 2023-03

./result/bin/run-pipeline --first-month 2023-02 --last-month 2023-03
linus commented 2024-04-17 08:44:03 +00:00
Owner
Copy Link

was already fixed on main. Please always merge main back to whatever you're working on.

was already fixed on `main`. Please always merge `main` back to whatever you're working on.
linus closed this issue 2024-04-17 08:44:10 +00:00
Sign in to join this conversation.
fix/currecny_conversion_BUG_new_TED
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Priority
High
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alex.sander i.galabov laurents linus maxsc micgor32 nedas sfisches siemer thomaswu tobiasd vincent weast
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TEDective/etl#28
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?