FSFE/fsfe-website
30
33
Fork 97
Code Issues 65 Pull Requests 20 Wiki Activity

adding new NGI page for the FSFE Website, and including the NGI logo #987

Merged
max.mehl merged 3 commits from gabriel.ku/fsfe-website:NGI0Page into master 2019-06-12 14:02:58 +00:00
Conversation 2 Commits 3 Files Changed 2
+60
gabriel.ku commented 2019-06-12 12:34:15 +00:00
Member
Copy Link
Copy Source
No description provided.
max.mehl requested changes 2019-06-12 12:48:19 +00:00
max.mehl left a comment
Owner
Copy Link
Copy Source

Please change the file name to ngi0.en.xhtml, and fix the list of links

Please change the file name to ngi0.en.xhtml, and fix the list of links
activities/ftf/ngi0-en.xhtml
@@ -0,0 +44,4 @@
<p>You can find more information about NGI0 PET and NGI0 Discovery at their respective websites linked below:</p>
<p>NGI Zero PET: <a href="https://nlnet.nl/PET">https://nlnet.nl/PET</a></p>
max.mehl commented 2019-06-12 12:46:54 +00:00
Owner
Copy Link
Copy Source

I would make this an unordered list, not two paragraphs. It could look like:

<ul>
  <li>NGI Zero PET: <a href="https://nlnet.nl/PET">https://nlnet.nl/PET</a></li>
  <li>NGI Zero Discovery: <a href="https://nlnet.nl/discovery">https://nlnet.nl/discovery</a>
</ul>
I would make this an unordered list, not two paragraphs. It could look like: ``` <ul> <li>NGI Zero PET: <a href="https://nlnet.nl/PET">https://nlnet.nl/PET</a></li> <li>NGI Zero Discovery: <a href="https://nlnet.nl/discovery">https://nlnet.nl/discovery</a> </ul> ```
max.mehl requested changes 2019-06-12 13:04:25 +00:00
activities/ftf/ngi0.en.xhtml
@@ -0,0 +47,4 @@
<ul>
<li>NGI Zero PET: <a href="https://nlnet.nl/PET">https://nlnet.nl/PET</a></li>
<li>NGI Zero Discovery: <a href="https://nlnet.nl/discovery">https://nlnet.nl/discovery</a></li>
<ul>
max.mehl commented 2019-06-12 13:04:18 +00:00
Owner
Copy Link
Copy Source

Syntax error here. Should be the closing </ul>

Normally, the Git hooks should have warned you about this error, so it seems you don't have them enabled. Could you please do so? It's a matter of a few minutes max: https://wiki.fsfe.org/TechDocs/Mainpage/Editing#Enabling_Git_hooks

Syntax error here. Should be the closing `</ul>` Normally, the Git hooks should have warned you about this error, so it seems you don't have them enabled. Could you please do so? It's a matter of a few minutes max: https://wiki.fsfe.org/TechDocs/Mainpage/Editing#Enabling_Git_hooks
max.mehl closed this pull request 2019-06-12 14:02:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
max.mehl
Labels
Clear labels
Accessibility
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert (Albert Dengg) alex.busch (alex.busch) alex.sander (alex.sander) anaghz (anaghz) annarita.russo (annarita.russo) ao (André Ockers) bonnie (bonnie) ciampix (Marco Ciampa) cryptie (cryptie) dario (dario) delliott (delliott) dfajfer (Damian Fajfer) dmaphy (Dominic Hopf) doczkal (Thomas Doczkal) eal (eal) egnun (Erik Grun) eventregbot (eventregbot) fi (fi) floriansnow (Florian Snow) gabriel.ku (gabriel.ku) guido (guido) hf (hf) hugo (hugo) ineiev (ineiev) jithendra (jithendra) jn (jn) jzarl (jzarl) linus (Linus Sehn) lucabon (Luca Bonissi) lucas.lasota (lucas.lasota) max.mehl (Max Mehl) mk (Matthias Kirschner) monochromec (monochromec) mweimann (Michael Weimann) nico.rikken (nico.rikken) patrick (Patrick Ohnewein) reinhard (Reinhard Müller) renovate-bot (Renovate Bot) repentinus (Heiki Lõhmus) schiessle (Björn Schießle) silviarbgl (Silvia Rbgl) sofiaritz (Sofía Aritz) tobiasd (tobiasd) vincent (vincent)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#987
Delete Branch "gabriel.ku/fsfe-website:NGI0Page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?