#974 WIP: Use sidecar files for identifying outdated translations

Fechado
Ghost quer aplicar o merge de 6 commits de :fix#64_2 em master
Ghost comentou 1 ano atrás

Alternative ansatz to fix #64.

Alternative ansatz to fix #64.
max.mehl comentou 1 ano atrás
Proprietário

Interesting!

A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? check-translation-status.sh

A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out

Interesting! A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? [check-translation-status.sh](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/check-translation-status.sh) A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out
reinhard comentou 1 ano atrás
Colaborador

The idea is interesting, but I see two downsides:

  • The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations.
  • The solution is strictly limited to determining outdated translations, the effort of all the “git log” calls cannot be reused for e.g. including the date of the last change in the HTML output (#837).

However, I have some idea how to improve this concept which I will describe in issue #64.

The idea is interesting, but I see two downsides: * The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations. * The solution is strictly limited to determining outdated translations, the effort of all the "git log" calls cannot be reused for e.g. including the date of the last change in the HTML output (#837). However, I have some idea how to improve this concept which I will describe in issue #64.
Ghost comentou 1 ano atrás
Autor
  • The sidecar file is only rebuilt when the English version
    changes. So if a formerly outdated translation is updated, it is not
    removed from the list of outdated translations.

Good point! Fixed in 9d24d36061

> * The sidecar file is only rebuilt when the English version > changes. So if a formerly outdated translation is updated, it is not > removed from the list of outdated translations. Good point! Fixed in 9d24d36061
Ghost comentou 1 ano atrás
Autor

A command to output all languages which are outdated against their
english original: check-translation-status.sh -f -o out

I didn’t notice that script. On my machine, doing

for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done

takes approx. 12 minutes (with lots of “date: ungültiges Datum „@“” messages).

Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do

find . -name "*.outdated*" | xargs cat | grep xhtml

and get all outdated files no (almost) no time.

> A command to output all languages which are outdated against their > english original: check-translation-status.sh -f -o out I didn't notice that script. On my machine, doing for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done takes approx. 12 minutes (with lots of "date: ungültiges Datum „@“" messages). Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do find . -name "*.outdated*" | xargs cat | grep xhtml and get all outdated files no (almost) no time.
reinhard comentou 4 meses atrás
Colaborador

Closing per discussion in #837

Closing per discussion in #837
reinhard closed this pull request 4 meses atrás
Todas as verificações foram bem sucedidas
the build was successful
Este pull request não pode ser reaberto porque o branch foi excluído.
Acesse para participar desta conversação.
No reviewers
Sem marco
Sem responsável
3 participante(s)
Notificações
Data limite

Data limite não informada.

Dependências

Atualmente este pull request não tem dependências.

Carregando…
Ainda não há conteúdo.