WIP: Use sidecar files for identifying outdated translations #974

Ghost · 2019-06-01T18:04:41Z

Ghost skomentował(-a)

2019-06-01 18:04:41 +00:00

First-time contributor

Alternative ansatz to fix #64.

max.mehl skomentował(-a)

2019-06-03 12:57:48 +00:00

Właściciel

Interesting!

A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? check-translation-status.sh

A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out

Interesting! A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? [check-translation-status.sh](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/check-translation-status.sh) A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out

reinhard skomentował(-a)

2019-06-03 14:23:46 +00:00

Członek

The idea is interesting, but I see two downsides:

The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations.
The solution is strictly limited to determining outdated translations, the effort of all the "git log" calls cannot be reused for e.g. including the date of the last change in the HTML output (#837).

However, I have some idea how to improve this concept which I will describe in issue #64.

The idea is interesting, but I see two downsides: * The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations. * The solution is strictly limited to determining outdated translations, the effort of all the "git log" calls cannot be reused for e.g. including the date of the last change in the HTML output (#837). However, I have some idea how to improve this concept which I will describe in issue #64.

Ghost skomentował(-a)

2019-06-03 16:29:28 +00:00

First-time contributor

The sidecar file is only rebuilt when the English version
changes. So if a formerly outdated translation is updated, it is not
removed from the list of outdated translations.

Good point! Fixed in 9d24d36061

> * The sidecar file is only rebuilt when the English version > changes. So if a formerly outdated translation is updated, it is not > removed from the list of outdated translations. Good point! Fixed in 9d24d36061

Ghost skomentował(-a)

2019-06-03 16:42:52 +00:00

First-time contributor

A command to output all languages which are outdated against their
english original: check-translation-status.sh -f -o out

I didn't notice that script. On my machine, doing

for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done

takes approx. 12 minutes (with lots of "date: ungültiges Datum „@“" messages).

Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do

find . -name "*.outdated*" | xargs cat | grep xhtml

and get all outdated files no (almost) no time.

> A command to output all languages which are outdated against their > english original: check-translation-status.sh -f -o out I didn't notice that script. On my machine, doing for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done takes approx. 12 minutes (with lots of "date: ungültiges Datum „@“" messages). Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do find . -name "*.outdated*" | xargs cat | grep xhtml and get all outdated files no (almost) no time.

reinhard odwołał(-a) się do tego Pull Requesta

2020-04-21 19:18:36 +00:00

"Last changed" in footer displays build info instead of commit info #837

reinhard skomentował(-a)

2020-04-27 12:19:24 +00:00

Członek

Closing per discussion in #837

reinhard zamknął(-ęła) ten pull request

2020-04-27 12:19:25 +00:00

the build was successful

Szczegóły

continuous-integration/drone/pr