#974 WIP: Use sidecar files for identifying outdated translations

닫힘
Ghost :fix#64_2 에서 master 로 6 commits 를 머지하려 합니다
Ghost 코멘트됨, 1 년 전

Alternative ansatz to fix #64.

Alternative ansatz to fix #64.
max.mehl 코멘트됨, 1 년 전
소유자

Interesting!

A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? check-translation-status.sh

A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out

Interesting! A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? [check-translation-status.sh](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/check-translation-status.sh) A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out
reinhard 코멘트됨, 1 년 전
협업자

The idea is interesting, but I see two downsides:

  • The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations.
  • The solution is strictly limited to determining outdated translations, the effort of all the “git log” calls cannot be reused for e.g. including the date of the last change in the HTML output (#837).

However, I have some idea how to improve this concept which I will describe in issue #64.

The idea is interesting, but I see two downsides: * The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations. * The solution is strictly limited to determining outdated translations, the effort of all the "git log" calls cannot be reused for e.g. including the date of the last change in the HTML output (#837). However, I have some idea how to improve this concept which I will describe in issue #64.
Ghost 코멘트됨, 1 년 전
포스터
  • The sidecar file is only rebuilt when the English version
    changes. So if a formerly outdated translation is updated, it is not
    removed from the list of outdated translations.

Good point! Fixed in 9d24d36061

> * The sidecar file is only rebuilt when the English version > changes. So if a formerly outdated translation is updated, it is not > removed from the list of outdated translations. Good point! Fixed in 9d24d36061
Ghost 코멘트됨, 1 년 전
포스터

A command to output all languages which are outdated against their
english original: check-translation-status.sh -f -o out

I didn’t notice that script. On my machine, doing

for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done

takes approx. 12 minutes (with lots of “date: ungültiges Datum „@“” messages).

Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do

find . -name "*.outdated*" | xargs cat | grep xhtml

and get all outdated files no (almost) no time.

> A command to output all languages which are outdated against their > english original: check-translation-status.sh -f -o out I didn't notice that script. On my machine, doing for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done takes approx. 12 minutes (with lots of "date: ungültiges Datum „@“" messages). Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do find . -name "*.outdated*" | xargs cat | grep xhtml and get all outdated files no (almost) no time.
reinhard 코멘트됨, 4 달 전
협업자

Closing per discussion in #837

Closing per discussion in #837
reinhard closed this pull request 4 달 전
All checks were successful
the build was successful
This pull request cannot be reopened because the branch was deleted.
로그인하여 이 대화에 참여
No reviewers
마일스톤 없음
담당자 없음
참여자 3명
알림
마감일

마감일이 설정되지 않았습니다.

의존성

이 풀 리퀘스트는 어떠한 의존성도 가지지 않습니다.

불러오는 중...
아직 콘텐츠가 없습니다.