#974 WIP: Use sidecar files for identifying outdated translations

Geschlossen
Ghost möchte 6 Commits von <deleted>:fix#64_2 nach master zusammenführen
Ghost hat vor 1 Jahr kommentiert

Alternative ansatz to fix #64.

Alternative ansatz to fix #64.
max.mehl hat vor 1 Jahr kommentiert
Besitzer

Interesting!

A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? check-translation-status.sh

A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out

Interesting! A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? [check-translation-status.sh](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/check-translation-status.sh) A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out
reinhard hat vor 1 Jahr kommentiert
Mitarbeiter

The idea is interesting, but I see two downsides:

  • The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations.
  • The solution is strictly limited to determining outdated translations, the effort of all the “git log” calls cannot be reused for e.g. including the date of the last change in the HTML output (#837).

However, I have some idea how to improve this concept which I will describe in issue #64.

The idea is interesting, but I see two downsides: * The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations. * The solution is strictly limited to determining outdated translations, the effort of all the "git log" calls cannot be reused for e.g. including the date of the last change in the HTML output (#837). However, I have some idea how to improve this concept which I will describe in issue #64.
Ghost hat vor 1 Jahr kommentiert
Ersteller
  • The sidecar file is only rebuilt when the English version
    changes. So if a formerly outdated translation is updated, it is not
    removed from the list of outdated translations.

Good point! Fixed in 9d24d36061

> * The sidecar file is only rebuilt when the English version > changes. So if a formerly outdated translation is updated, it is not > removed from the list of outdated translations. Good point! Fixed in 9d24d36061
Ghost hat vor 1 Jahr kommentiert
Ersteller

A command to output all languages which are outdated against their
english original: check-translation-status.sh -f -o out

I didn’t notice that script. On my machine, doing

for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done

takes approx. 12 minutes (with lots of “date: ungültiges Datum „@“” messages).

Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do

find . -name "*.outdated*" | xargs cat | grep xhtml

and get all outdated files no (almost) no time.

> A command to output all languages which are outdated against their > english original: check-translation-status.sh -f -o out I didn't notice that script. On my machine, doing for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done takes approx. 12 minutes (with lots of "date: ungültiges Datum „@“" messages). Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do find . -name "*.outdated*" | xargs cat | grep xhtml and get all outdated files no (almost) no time.
reinhard hat vor 5 Monaten kommentiert
Mitarbeiter

Closing per discussion in #837

Closing per discussion in #837
reinhard hat diesen Pull-Request vor 5 Monaten geschlossen
Alle Prüfungen waren erfolgreich
the build was successful
Dieser Pull-Request kann nicht wieder geöffnet werden, da die Branche bereits gelöscht wurde.
Anmelden, um an der Diskussion teilzunehmen.
Keine Reviewer
Kein Meilenstein
Niemand zuständig
3 Beteiligte
Nachrichten
Fällig am

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Dieser Pull-Request hat momentan keine Abhängigkeiten.

Laden…
Hier gibt es bis jetzt noch keinen Inhalt.