#974 WIP: Use sidecar files for identifying outdated translations

otevřený
ulf chce sloučit 6 revizí z větve ulf/fsfe-website:fix#64_2 do větve master
ulf okomentoval před 2 měsíci

Alternative ansatz to fix #64.

Alternative ansatz to fix #64.
max.mehl okomentoval před 2 měsíci
Vlastník

Interesting!

A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? check-translation-status.sh

A command to output all languages which are outdated against their english original: check-translation-status.sh -f -o out

Interesting! A script checking for outdated translations already exists, perhaps you can use or expand it instead of creating a script with the same focus? [check-translation-status.sh](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/check-translation-status.sh) A command to output all languages which are outdated against their english original: check-translation-status.sh -f <any_file> -o out
reinhard okomentoval před 2 měsíci
Spolupracovník

The idea is interesting, but I see two downsides:

  • The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations.
  • The solution is strictly limited to determining outdated translations, the effort of all the “git log” calls cannot be reused for e.g. including the date of the last change in the HTML output (#837).

However, I have some idea how to improve this concept which I will describe in issue #64.

The idea is interesting, but I see two downsides: * The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations. * The solution is strictly limited to determining outdated translations, the effort of all the "git log" calls cannot be reused for e.g. including the date of the last change in the HTML output (#837). However, I have some idea how to improve this concept which I will describe in issue #64.
ulf okomentoval před 2 měsíci
Autor
  • The sidecar file is only rebuilt when the English version changes. So if a formerly outdated translation is updated, it is not removed from the list of outdated translations.

Good point! Fixed in 9d24d36061

> * The sidecar file is only rebuilt when the English version > changes. So if a formerly outdated translation is updated, it is not > removed from the list of outdated translations. Good point! Fixed in 9d24d36061
ulf okomentoval před 2 měsíci
Autor

A command to output all languages which are outdated against their english original: check-translation-status.sh -f -o out

I didn’t notice that script. On my machine, doing

for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done

takes approx. 12 minutes (with lots of “date: ungültiges Datum „@“” messages).

Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do

find . -name "*.outdated*" | xargs cat | grep xhtml

and get all outdated files no (almost) no time.

> A command to output all languages which are outdated against their > english original: check-translation-status.sh -f -o out I didn't notice that script. On my machine, doing for f in `find . -name "*.en.xhtml"`; do echo $f; tools/check-translation-status.sh -o out -a -f $f; done takes approx. 12 minutes (with lots of "date: ungültiges Datum „@“" messages). Generating the sidecar files takes approx. 5 minutes on my box (which is roughly the extra time a full build takes with #974.) Once the sidecar files are generated, you can do find . -name "*.outdated*" | xargs cat | grep xhtml and get all outdated files no (almost) no time.
All checks were successful
the build was successful
Požadavek na natažení je označen jako ve vývoji. Odstraňte WIP: prefix z titulku, až bude hotový
Přihlaste se pro zapojení do konverzace.
Bez milníku
Bez zpracovatelů
3 účastníků
Termín dokončení

Žádný termín dokončení.

Závislosti

Tento požadavek na natažení momentálně nemá žádné závislosti.

Načítá se…
Zrušit
Uložit
Není zde žádný obsah.