#961 WIP: Automatically calculate shipping costs based on country selection

Open
reinhard wants to merge 8 commits from Issue_877_merchanise_wrong_shipping into master
reinhard commented 1 month ago
There is no content yet.
monochromec commented 1 month ago
Collaborator

Let me know if you need support here.

Let me know if you need support here.
reinhard commented 1 month ago
Poster

@monochromec the current state of the pull request is technically functional, but we will use this opportunity to re-evaluate which shipping costs are appropriate for which target countries. I expect this patch to be applied within the upcoming week.

@monochromec the current state of the pull request is technically functional, but we will use this opportunity to re-evaluate which shipping costs are appropriate for which target countries. I expect this patch to be applied within the upcoming week.
max.mehl commented 1 month ago
Owner

At this point, we could also think of using the same stucture as on fsfe.org/promo where we also ask for street, ZIP and city separately. Not sure what makes most sense for the ones who actually send the packages.

At this point, we could also think of using the same stucture as on fsfe.org/promo where we also ask for street, ZIP and city separately. Not sure what makes most sense for the ones who actually send the packages.
vincent requested changes 1 month ago
@@ -46,0 +52,4 @@
52
+
53
+my $shipping;
54
+
55
+given ($country_code) {
vincent

I would recommend to avoid given / when because this is an experimental feature. Please see here.

I would recommend to avoid `given` / `when` because this is an experimental feature. Please see [here](https://perldoc.perl.org/perlsyn.html#Experimental-Details-on-given-and-when).

Reviewers

vincent requested changes 1 month ago
This pull request is marked as a work in progress. Remove the WIP: prefix from the title when it's ready
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.