Adding SKIM to pdf reader #914

lucas.lasota · 2019-05-20T11:59:55Z

lucas.lasota commented

2019-05-20 11:59:55 +00:00

Hello!

In relation to the ticket [1] about the pdf reader Skim, I would like to update the pdf reader's page with the information about Skim.

Please merge it if everything is fine.

Thanks!

[1] https://tickets.fsfe.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=85024#

Hello! In relation to the ticket [1] about the pdf reader Skim, I would like to update the pdf reader's page with the information about Skim. Please merge it if everything is fine. Thanks! [1] https://tickets.fsfe.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=85024#

max.mehl commented

2019-05-22 09:20:38 +00:00

Seems fine. I just wonder what your avatar is doing in there ;)

It seems you didn't update your master branch, or accidentially added it to this pull request.

I would recommend to run git rm about/lasota/lucas-lasota-foto.1024x1024.jpg inside the repository (branch SKIM) and commit this change to this branch. This way, you would update this pull request and have only the file about Skim added.

Seems fine. I just wonder what your avatar is doing in there ;) It seems you didn't update your master branch, or accidentially added it to this pull request. I would recommend to run `git rm about/lasota/lucas-lasota-foto.1024x1024.jpg` inside the repository (branch `SKIM`) and commit this change to this branch. This way, you would update this pull request and have only the file about Skim added.

max.mehl added the

wait/bugfix

label 2019-05-22 09:20:48 +00:00

lucas.lasota commented

2019-05-23 10:05:17 +00:00

Hi Max,
thank you for the help.
I deleted the avatar and the Vindaloo files for all languages.
Skim was already added.

Lucas

Hi Max, thank you for the help. I deleted the avatar and the Vindaloo files for all languages. Skim was already added. Lucas

max.mehl commented

2019-05-23 10:45:26 +00:00

Thanks, looks good! Except one issue:

I noticed that there is no logo for Skim, although you reference it via <logo>skim.png</logo>. Could you please add one, following the examples of the other readers?

Thanks, looks good! Except one issue: I noticed that there is no logo for Skim, although you reference it via `<logo>skim.png</logo>`. Could you please add one, following the examples of the other readers?

lucas.lasota commented

2019-05-23 11:34:51 +00:00

Max, one small suggestion.

In the pdf readers' main page[1] there are three main readers which boxes are bigger than others. I presume they are more popular.
However, at the moment there are readers for GNU/Linux and Windows. It would be nice to have one also for OS X.
Since Skim is dedicated to OS X, maybe it could be in a prominent position too?

[1] https://pdfreaders.org/

Max, one small suggestion. In the pdf readers' main page[1] there are three main readers which boxes are bigger than others. I presume they are more popular. However, at the moment there are readers for GNU/Linux and Windows. It would be nice to have one also for OS X. Since Skim is dedicated to OS X, maybe it could be in a prominent position too? [1] https://pdfreaders.org/

max.mehl commented

2019-05-23 12:24:19 +00:00

OK, sounds reasonable. You can set the priorities in the file. The smaller the number, the earlier the reader is shown. The first 3 ones are the prominent boxes.

But I would suggest to do that change in a separate Pull Request (so also in a separate branch), in the following order:

Evince
Sumatra
SKIM
Okular

It's not idea as Okular and Evince are the two major PDF readers for GNU/Linux, but for different desktopn environments. But having the three major operating systems represented on the prominent place makes sense, and GNOME seems to be a bit more used than Okular.

Lucas, could you please make this change accordingly? I will now merge this PR since it served its purpose. Thanks for working on it!

OK, sounds reasonable. You can set the priorities in the file. The smaller the number, the earlier the reader is shown. The first 3 ones are the prominent boxes. But I would suggest to do that change in a separate Pull Request (so also in a separate branch), in the following order: 1. Evince 2. Sumatra 3. SKIM 4. Okular It's not idea as Okular and Evince are the two major PDF readers for GNU/Linux, but for different desktopn environments. But having the three major operating systems represented on the prominent place makes sense, and GNOME seems to be a bit more used than Okular. Lucas, could you please make this change accordingly? I will now merge this PR since it served its purpose. Thanks for working on it!

max.mehl closed this pull request

2019-05-23 12:24:57 +00:00

max.mehl referenced this issue from a commit

2019-05-23 13:53:51 +00:00

Adding SKIM to pdf reader (#914) This also removes Vindaloo which isn't maintained anymore and offline

Sign in to join this conversation.

No reviewers