#818 first draft of publishing chapters from the brochure

Fermé
eal veut fusionner 3 révision(s) depuis eal:firstchapterdraft vers master
eal a commenté il y a 1 an

This is a first draft for future publications of individual chapters from the pmpc-brochure. As this is the first time I have been working on the LESS/CSS, @max.mehl can you please have a look before merging?

This is a first draft for future publications of individual chapters from the pmpc-brochure. As this is the first time I have been working on the LESS/CSS, @max.mehl can you please have a look before merging?
max.mehl révisé il y a 1 an
@@ -509,1 +509,4 @@

/* Styles for the pmpc-news articles */

img.newsitempic-externalauthor {
max.mehl a commenté il y a 1 an

That’s not necessary, bootstrap offers img-circle: https://getbootstrap.com/docs/3.3/css/#images

That's not necessary, bootstrap offers img-circle: https://getbootstrap.com/docs/3.3/css/#images
@@ -510,0 +514,4 @@
border-radius: 50%;
}

div.newsitempic-externalauthor {
max.mehl a commenté il y a 1 an

Why do you indent here and below? Let’s try to keep a unified indenting scheme, so perhaps 2 or 4 spaces or 1 tab.

Also, it makes sense to first define the div and then the img it contains. An hierarchical structure makes things easier to understand.

Why do you indent here and below? Let's try to keep a unified indenting scheme, so perhaps 2 or 4 spaces or 1 tab. Also, it makes sense to first define the div and then the img it contains. An hierarchical structure makes things easier to understand.
@@ -510,0 +516,4 @@

div.newsitempic-externalauthor {
float: right;
max-width: 80px;
max.mehl a commenté il y a 1 an

I would not put the single image in a div, you could add all classes to the img directly: img-circle, pull-right (instead of float-style). If you uploaded the picture in 80px*80px, you would not even have to define the max-width.

I would not put the single image in a div, you could add all classes to the img directly: img-circle, [pull-right](https://getbootstrap.com/docs/3.3/css/#helper-classes-floats) (instead of float-style). If you uploaded the picture in 80px*80px, you would not even have to define the max-width.
@@ -510,0 +521,4 @@
}
@media (min-width: @screen-sm-min) {
float: right;
max.mehl a commenté il y a 1 an

This misses a class/id or whatever. After media, you have a normal declaration of a target

This misses a class/id or whatever. After media, you have a normal declaration of a target
@@ -510,0 +527,4 @@
}
div.box-grey-bg {
max.mehl a commenté il y a 1 an

Can’t we just use the blockquote tag?

Can't we just use the blockquote tag?
look/fsfe.less
@@ -510,0 +551,4 @@
}
}
max.mehl a commenté il y a 1 an

Blanklines. Blanklines everywhere :D

Blanklines. Blanklines everywhere :D
look/fsfe.less
@@ -510,0 +560,4 @@
margin-right: auto;
}

@media (min-width: @screen-sm-min) {
max.mehl a commenté il y a 1 an

Indentation went mad :P

Indentation went mad :P
news/2019/news-20190228-01.en.xhtml
@@ -0,0 +16,4 @@

<p>Free Software is well established in the IT world. A significant number of companies, from SMEs to global corporations, invest considerable sums in the further development and use of Free Software. Public administrations now also regularly use Free Software. For example, for administration in municipalities, as a decision database for courts, or for the provision of geodata on the Internet [<a href="#1">1</a>]. The reasons for using Free Software in companies and public administrations are manifold, e.g. the openness of the standards used, the independence from suppliers and products, the exchange with the community of users and developers, security, as well as stability and possible cost savings.</p>
<div class="newsitempic-full">
max.mehl a commenté il y a 1 an

Why using a custom class here? What’s wrong with out default one with a fixed width? Ideally max-width:556px (80% of 100% in full width)

Why using a custom class here? What's wrong with out default one with a fixed width? Ideally max-width:556px (80% of 100% in full width)
@@ -0,0 +60,4 @@
<div class="newsitempic-externalauthor">
<img src="/picturebase/people/2019-Simon_Schlauri-200px.jpg" class="newsitempic-externalauthor" alt="Prof. Dr. Simon Schlauri" />
max.mehl a commenté il y a 1 an

The round picture requires a square picture, otherwise it looks like an egg ;)

The round picture requires a square picture, otherwise it looks like an egg ;)
@@ -0,0 +88,4 @@
</div>
<div class="pmpc-article-footnotes">
max.mehl a commenté il y a 1 an

We already have a footnotes style used in some places. E.g. have a look here: https://fsfe.org/about/funds/2017.en.html

We already have a footnotes style used in some places. E.g. have a look here: https://fsfe.org/about/funds/2017.en.html
eal a commenté il y a 1 an
Publier

@max.mehl i removed some of your proposed unnecessary styles, but I have to admit, I did not understood all of your comments. Generally this seems not to be a good workflow and I would like to propose that we either

  • use inline-CSS and once we have the style finished we move that over to the central CSS just like we do it with the supporters interview now, or
  • you do changes in the .less etc and give me comments what you did.

i prefer the first one and see no problem with it. would that be ok with you?

@max.mehl i removed some of your proposed unnecessary styles, but I have to admit, I did not understood all of your comments. Generally this seems not to be a good workflow and I would like to propose that we either - use inline-CSS and once we have the style finished we move that over to the central CSS just like we do it with the supporters interview now, or - you do changes in the .less etc and give me comments what you did. i prefer the first one and see no problem with it. would that be ok with you?
reinhard a commenté il y a 1 an
Collaborateur

I also think that the workflow we currently use for the testimonials pages works well, especially if we can use the test instance to see what we’re talking about :-)

I also think that the workflow we currently use for the testimonials pages works well, especially if we can use the test instance to see what we're talking about :-)
eal a commenté il y a 1 an
Publier

@reinhard Thank you for the comment. Yes, that is also a good worflow, considering I understand how to work with the test-instance soon : )

@reinhard Thank you for the comment. Yes, that is also a good worflow, considering I understand how to work with the test-instance soon : )
eal a fermé cette pull request il y a 1 an
Tous les contrôles ont réussi
the build was successful
Cette demande d'ajout ne peut pas être rouverte car la branche a été supprimée.
Connectez-vous pour rejoindre cette conversation.
Pas de relecteur
Aucun jalon
Pas d'assignataires
3 participants
Notifications
Échéance

Aucune échéance n'a été définie.

Dépendances

La demande de fusion n'a actuellement pas de dépendance.

Chargement…
Il n'existe pas encore de contenu.