FSFE
/
fsfe-website
27
30
Fork 88
Code Issues 63 Pull Requests 6 Wiki Activity

Extract community/people css to a separate file; fixes mobile layout #767

Closed
mweimann wants to merge 4 commits from fix-community-people-mobile into master
pull from: fix-community-people-mobile
merge into: FSFE:master
Conversation 7 Commits 4 Files Changed 6 +261 -156
mweimann commented 2019-02-01 08:16:55 +00:00
Member
Copy Link

Like suggested on the mailing list I extracted the CSS to a separate file.

I also fixed the mobile layout (see screenshots).

Like suggested on the mailing list I extracted the CSS to a separate file. I also fixed the mobile layout (see screenshots).
mobile_after.png
541 KiB
mobile_before.png
519 KiB
mobile_after.png mobile_before.png
max.mehl was assigned by mweimann 2019-02-01 08:16:55 +00:00
eal was assigned by mweimann 2019-02-01 08:16:55 +00:00
mweimann added the
design
 label 2019-02-01 08:16:55 +00:00
max.mehl commented 2019-02-01 12:55:10 +00:00
Owner
Copy Link

I see you've placed the CSS in a new file. Shouldn't we rather put this in fsfe.less, i.e. fsfe.min.css? We already have 3 CSS files and a fourth one could cause even more confusion I'm afraid...

I see you've placed the CSS in a new file. Shouldn't we rather put this in fsfe.less, i.e. fsfe.min.css? We already have 3 CSS files and a fourth one could cause even more confusion I'm afraid...
mweimann commented 2019-02-03 18:38:24 +00:00
Author
Member
Copy Link

@max.mehl I've changed the css to less. I also added some less instructions to the readme.

@max.mehl I've changed the css to less. I also added some less instructions to the readme.
eal commented 2019-02-28 15:30:26 +00:00
Member
Copy Link

Hi all,
I am confused, can you help me please? I now see changes to
fsfe.min.css & style.less as well as the creation of a community-people.min.css and community-people.less ...

I would be on the same page as @max.mehl and not start a new CSS file but rather use the existing ones.
@mweimann

Hi all, I am confused, can you help me please? I now see changes to fsfe.min.css & style.less as well as the creation of a community-people.min.css and community-people.less ... I would be on the same page as @max.mehl and not start a new CSS file but rather use the existing ones. @mweimann
mweimann commented 2019-03-03 13:29:08 +00:00
Author
Member
Copy Link

@eal @max.mehl the reason was to keep the behavior. Inline styles are only present on the page they're written into. I can include it in the fsfe main file.

@eal @max.mehl the reason was to keep the behavior. Inline styles are only present on the page they're written into. I can include it in the fsfe main file.
mweimann commented 2019-03-10 17:59:13 +00:00
Author
Member
Copy Link

@max.mehl go? :)

@max.mehl go? :)
mweimann commented 2019-03-31 13:58:34 +00:00
Author
Member
Copy Link

Conflicts solved, let's go @max.mehl

Conflicts solved, let's go @max.mehl
mweimann commented 2019-04-29 16:26:18 +00:00
Author
Member
Copy Link

Closing this one, because of it's now too old.
A shame for the time I wasted here... :/

Closing this one, because of it's now too old. A shame for the time I wasted here... :/
mweimann closed this pull request 2019-04-29 16:26:23 +00:00
Some checks are pending
the build was successful
Details
continuous-integration/drone/pr
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
build

   
cgi Scripting

   
design

   
disruptive

Requires careful coordination and documentation changes

  
documentation

   
duplicate

   
easy

   
feature-request

   
help wanted

   
javascript

   
priority/low

   
question

   
system-hackers

   
tagging

   
text

   
translations

   
wait/bugfix

   
wait/inprogress

   
wait/misc

   
wait/proofread

   
wontfix

   
xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
max.mehl
eal
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#767
No description provided.
Delete Branch "fix-community-people-mobile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?