Extract community/people css to a separate file; fixes mobile layout #767

2019-02-01T08:16:55Z

mweimann commented

2019-02-01 08:16:55 +00:00

Like suggested on the mailing list I extracted the CSS to a separate file.

I also fixed the mobile layout (see screenshots).

Like suggested on the mailing list I extracted the CSS to a separate file. I also fixed the mobile layout (see screenshots).

mobile_after.png

541 KiB

mobile_before.png

519 KiB

max.mehl was assigned by mweimann

2019-02-01 08:16:55 +00:00

eal was assigned by mweimann

2019-02-01 08:16:55 +00:00

mweimann added the design label 2019-02-01 08:16:55 +00:00

max.mehl commented

2019-02-01 12:55:10 +00:00

I see you've placed the CSS in a new file. Shouldn't we rather put this in fsfe.less, i.e. fsfe.min.css? We already have 3 CSS files and a fourth one could cause even more confusion I'm afraid...

mweimann commented

2019-02-03 18:38:24 +00:00

@max.mehl I've changed the css to less. I also added some less instructions to the readme.

eal commented

2019-02-28 15:30:26 +00:00

Hi all,
I am confused, can you help me please? I now see changes to
fsfe.min.css & style.less as well as the creation of a community-people.min.css and community-people.less ...

I would be on the same page as @max.mehl and not start a new CSS file but rather use the existing ones.
@mweimann

Hi all, I am confused, can you help me please? I now see changes to fsfe.min.css & style.less as well as the creation of a community-people.min.css and community-people.less ... I would be on the same page as @max.mehl and not start a new CSS file but rather use the existing ones. @mweimann

mweimann commented

2019-03-03 13:29:08 +00:00

@eal @max.mehl the reason was to keep the behavior. Inline styles are only present on the page they're written into. I can include it in the fsfe main file.