#767 Extract community/people css to a separate file; fixes mobile layout

Open
mweimann wants to merge 3 commits from fix-community-people-mobile into master
mweimann commented 1 month ago

Like suggested on the mailing list I extracted the CSS to a separate file.

I also fixed the mobile layout (see screenshots).

Like suggested on the mailing list I extracted the CSS to a separate file. I also fixed the mobile layout (see screenshots).
max.mehl was assigned by mweimann 1 month ago
eal was assigned by mweimann 1 month ago
mweimann added the
design
label 1 month ago
max.mehl commented 1 month ago
Owner

I see you’ve placed the CSS in a new file. Shouldn’t we rather put this in fsfe.less, i.e. fsfe.min.css? We already have 3 CSS files and a fourth one could cause even more confusion I’m afraid…

I see you've placed the CSS in a new file. Shouldn't we rather put this in fsfe.less, i.e. fsfe.min.css? We already have 3 CSS files and a fourth one could cause even more confusion I'm afraid...
mweimann commented 1 month ago
Poster

@max.mehl I’ve changed the css to less. I also added some less instructions to the readme.

@max.mehl I've changed the css to less. I also added some less instructions to the readme.
eal commented 3 weeks ago
Collaborator

Hi all, I am confused, can you help me please? I now see changes to fsfe.min.css & style.less as well as the creation of a community-people.min.css and community-people.less …

I would be on the same page as @max.mehl and not start a new CSS file but rather use the existing ones. @mweimann

Hi all, I am confused, can you help me please? I now see changes to fsfe.min.css & style.less as well as the creation of a community-people.min.css and community-people.less ... I would be on the same page as @max.mehl and not start a new CSS file but rather use the existing ones. @mweimann
mweimann commented 3 weeks ago
Poster

@eal @max.mehl the reason was to keep the behavior. Inline styles are only present on the page they’re written into. I can include it in the fsfe main file.

@eal @max.mehl the reason was to keep the behavior. Inline styles are only present on the page they're written into. I can include it in the fsfe main file.
mweimann commented 2 weeks ago
Poster

@max.mehl go? :)

@max.mehl go? :)
This pull request cannot be merged automatically due to conflicts.
Merge manually to resolve the conflicts.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.