#767 Extract community/people css to a separate file; fixes mobile layout

Closed
mweimann wants to merge 4 commits from fix-community-people-mobile into master
mweimann commented 2 years ago
Collaborator

Like suggested on the mailing list I extracted the CSS to a separate file.

I also fixed the mobile layout (see screenshots).

Like suggested on the mailing list I extracted the CSS to a separate file. I also fixed the mobile layout (see screenshots).
max.mehl was assigned by mweimann 2 years ago
eal was assigned by mweimann 2 years ago
mweimann added the
design
label 2 years ago
max.mehl commented 2 years ago
Owner

I see you've placed the CSS in a new file. Shouldn't we rather put this in fsfe.less, i.e. fsfe.min.css? We already have 3 CSS files and a fourth one could cause even more confusion I'm afraid...

I see you've placed the CSS in a new file. Shouldn't we rather put this in fsfe.less, i.e. fsfe.min.css? We already have 3 CSS files and a fourth one could cause even more confusion I'm afraid...
mweimann commented 2 years ago
Poster
Collaborator

@max.mehl I've changed the css to less. I also added some less instructions to the readme.

@max.mehl I've changed the css to less. I also added some less instructions to the readme.
eal commented 2 years ago
Collaborator

Hi all,
I am confused, can you help me please? I now see changes to
fsfe.min.css & style.less as well as the creation of a community-people.min.css and community-people.less ...

I would be on the same page as @max.mehl and not start a new CSS file but rather use the existing ones.
@mweimann

Hi all, I am confused, can you help me please? I now see changes to fsfe.min.css & style.less as well as the creation of a community-people.min.css and community-people.less ... I would be on the same page as @max.mehl and not start a new CSS file but rather use the existing ones. @mweimann
mweimann commented 2 years ago
Poster
Collaborator

@eal @max.mehl the reason was to keep the behavior. Inline styles are only present on the page they're written into. I can include it in the fsfe main file.

@eal @max.mehl the reason was to keep the behavior. Inline styles are only present on the page they're written into. I can include it in the fsfe main file.
mweimann commented 2 years ago
Poster
Collaborator

@max.mehl go? :)

@max.mehl go? :)
mweimann commented 2 years ago
Poster
Collaborator

Conflicts solved, let's go @max.mehl

Conflicts solved, let's go @max.mehl
mweimann commented 2 years ago
Poster
Collaborator

Closing this one, because of it's now too old.
A shame for the time I wasted here... :/

Closing this one, because of it's now too old. A shame for the time I wasted here... :/
mweimann closed this pull request 2 years ago
All checks were successful
the build was successful
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.