FSFE/fsfe-website
25
31
Fork 92
Code Issues 65 Pull Requests 5 Wiki Activity

Fixes the newsletter layout at the bottom #759

Merged
max.mehl merged 2 commits from fix-newsletter-area into master 2019-01-30 15:33:20 +00:00
Conversation 5 Commits 2 Files Changed 5 +48 -27
mweimann commented 2019-01-29 19:47:54 +00:00
Member
Copy Link

This is about the newsletter area, e.g. on this page https://fsfe.org/community/people/cryptie/cryptie.html

After the fix it looks like this:

This is about the newsletter area, e.g. on this page https://fsfe.org/community/people/cryptie/cryptie.html After the fix it looks like this:
nl-after-small.png
23 KiB
nl-after-wide.png
24 KiB
nl-after-small.png nl-after-wide.png
mweimann commented 2019-01-29 19:48:19 +00:00
Author
Member
Copy Link

This is how it looked like before

This is how it looked like before
nl-before-small.png
23 KiB
nl-before-wide.png
26 KiB
nl-before-small.png nl-before-wide.png
mweimann commented 2019-01-29 19:48:52 +00:00
Author
Member
Copy Link

@eal @max.mehl what do you think?

@eal @max.mehl what do you think?
mweimann added the
design
 label 2019-01-29 19:48:57 +00:00
max.mehl was assigned by mweimann 2019-01-29 19:49:04 +00:00
eal was assigned by mweimann 2019-01-29 19:49:06 +00:00
mweimann reviewed 2019-01-29 19:50:02 +00:00
look/fsfe.less
mweimann commented 2019-01-29 19:50:02 +00:00
Author
Member
Copy Link

I fixated the font size and line height here.
Otherwise the layout switches as the screen size does..

I fixated the font size and line height here. Otherwise the layout switches as the screen size does..
max.mehl commented 2019-01-30 08:50:20 +00:00
Owner
Copy Link

Looks good, thank you for spotting and fixing!

I've added the minified CSS files since they are the one which are used in the end. If nobody opposes, I think we can merge it.

Looks good, thank you for spotting and fixing! I've added the minified CSS files since they are the one which are used in the end. If nobody opposes, I think we can merge it.
mweimann commented 2019-01-30 11:27:04 +00:00
Author
Member
Copy Link

I’ve added the minified CSS files since they are the one which are used in the end.

Hmm good to know. I'm used to have a build system doing that.. I'll add them next time.

> I’ve added the minified CSS files since they are the one which are used in the end. Hmm good to know. I'm used to have a build system doing that.. I'll add them next time.
max.mehl closed this pull request 2019-01-30 15:33:20 +00:00
mweimann deleted branch fix-newsletter-area 2019-02-01 07:14:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
design
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bonnie cryptie dario delliott dmaphy doczkal eal egnun eventregbot fi floriansnow gabriel.ku guido hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard repentinus schiessle sofiaritz tobiasd vincent
No Assignees max.mehl eal
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#759
No description provided.
Delete Branch "fix-newsletter-area"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?