FSFE/fsfe-website
30
33
Fork 96
Code Issues 65 Pull Requests 15 Wiki Activity

feat: optionally play notification+sound on completion #5657

Merged
tobiasd merged 2 commits from feat/sounds into master 2026-04-14 12:18:22 +00:00
Conversation 3 Commits 2 Files Changed 7
+193 -2
delliott commented 2026-02-02 21:57:06 +00:00
Member
Copy Link
Copy Source

dependency not installed by default, very opt in

dependency not installed by default, very opt in
delliott requested review from hl 2026-02-02 21:57:07 +00:00
delliott added a new dependency 2026-02-02 21:57:20 +00:00
#5649 FEAT: uv build system, audible bell when build is ready
delliott marked the pull request as work in progress 2026-02-02 22:00:10 +00:00
delliott commented 2026-02-02 22:00:31 +00:00
Author
Member
Copy Link
Copy Source

I am not sure this is worth the complexity, and extra deps required for proper ci checking? IDK

I am not sure this is worth the complexity, and extra deps required for proper ci checking? IDK
delliott requested review from tobiasd 2026-02-02 22:03:16 +00:00
delliott marked the pull request as ready for review 2026-02-26 12:26:29 +00:00
delliott removed review request for hl 2026-02-26 12:26:36 +00:00
delliott commented 2026-02-26 12:26:44 +00:00
Author
Member
Copy Link
Copy Source

@tobiasd thoughts?

@tobiasd thoughts?
delliott added 2 commits 2026-04-14 08:37:41 +00:00
feat: optionally play notification+sound on completion 830a959edb 
dependency not installed by default, very opt in
feat: add all groups to pre commit for typechecking
continuous-integration/drone/pr Build is passing
Details
313fb6e586
delliott force-pushed feat/sounds from 83fa167d49 to 313fb6e586 2026-04-14 08:37:41 +00:00 Compare
tobiasd approved these changes 2026-04-14 12:18:01 +00:00
tobiasd merged commit bb71af1288 into master 2026-04-14 12:18:22 +00:00
tobiasd deleted branch feat/sounds 2026-04-14 12:18:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
tobiasd
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert (Albert Dengg) alex.busch (alex.busch) alex.sander (alex.sander) anaghz (anaghz) annarita.russo (annarita.russo) ao (André Ockers) bcludts (bcludts) bonnie (bonnie) cryptie (cryptie) dario (dario) delliott (delliott) dfajfer (Damian Fajfer) dmaphy (Dominic Hopf) doczkal (Thomas Doczkal) eal (eal) egnun (Erik Grun) eventregbot (eventregbot) fi (fi) floriansnow (Florian Snow) gabriel.ku (gabriel.ku) guido (guido) hugo (hugo) ineiev (ineiev) jithendra (jithendra) jn (jn) jzarl (jzarl) linus (Linus Sehn) lucabon (Luca Bonissi) lucas.lasota (lucas.lasota) max.mehl (Max Mehl) mk (Matthias Kirschner) monochromec (monochromec) mweimann (Michael Weimann) nico.rikken (nico.rikken) patrick (Patrick Ohnewein) reinhard (Reinhard Müller) renovate-bot (Renovate Bot) repentinus (Heiki Lõhmus) schiessle (Björn Schießle) silviarbgl (Silvia Rbgl) sofiaritz (Sofía Aritz) tobiasd (tobiasd) vincent (vincent)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#5649 FEAT: uv build system, audible bell when build is ready
FSFE/fsfe-website
Reference: FSFE/fsfe-website#5657
Delete Branch "feat/sounds"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?