FSFE/fsfe-website
30
33
Fork 97
Code Issues 65 Pull Requests 20 Wiki Activity

feat/python-checks #5651

Merged
tobiasd merged 24 commits from feat/python-checks into master 2026-02-26 12:40:58 +00:00
Conversation 4 Commits 24 Files Changed 23
+1090 -1086
delliott commented 2026-01-28 11:13:07 +00:00
Member
Copy Link
Copy Source

port the bash precommit hooks to python in a nice extensible way.

It should have feature parity and be much easier to read and maintain. It also allows for reducing the number of dependencies in the pre commit docker image.

I have tested that the checks can both pass and fail correctly, but it is somewhat possible there might be some edge cases and bugs I have missed. So for a short while after merging if failing ci look at it a little more carefully, in case the checks need some tuning.

port the bash precommit hooks to python in a nice extensible way. It should have feature parity and be much easier to read and maintain. It also allows for reducing the number of dependencies in the pre commit docker image. I have tested that the checks can both pass and fail correctly, but it is somewhat possible there might be some edge cases and bugs I have missed. So for a short while after merging if failing ci look at it a little more carefully, in case the checks need some tuning.
👍 1
delliott force-pushed feat/python-checks from 053dae6979 to e81a9d27da 2026-02-02 17:52:16 +00:00 Compare
delliott marked the pull request as ready for review 2026-02-02 17:52:34 +00:00
delliott requested review from tobiasd 2026-02-02 17:58:49 +00:00
delliott force-pushed feat/python-checks from 904d3de44d to cb28e7c7ff 2026-02-02 18:01:15 +00:00 Compare
delliott force-pushed feat/python-checks from 346c0498d3 to 3cc18e65bb 2026-02-03 12:54:03 +00:00 Compare
delliott force-pushed feat/python-checks from 3cc18e65bb to 464f30c159 2026-02-07 22:26:58 +00:00 Compare
delliott force-pushed feat/python-checks from 464f30c159 to a0b532d92b 2026-02-18 12:27:51 +00:00 Compare
tobiasd reviewed 2026-02-25 12:53:09 +00:00
tools/ci-checks/checks/check_image_ratio.py Outdated
@@ -0,0 +69,4 @@
16:9 ratio for preview is mandatory for news items.
More information on preview images:
https://wiki.fsfe.org/TechDocs/Mainpage/Editing#Preview_Image""")
tobiasd commented 2026-02-25 12:53:08 +00:00
Owner
Copy Link
Copy Source

This link (and maybe others) should point to docs.fsfe.org instead

This link (and maybe others) should point to docs.fsfe.org instead
delliott commented 2026-02-26 12:24:37 +00:00
Author
Member
Copy Link
Copy Source

Made the requested changes.

Made the requested changes.
delliott marked this conversation as resolved
tobiasd requested changes 2026-02-26 10:12:54 +00:00
Dismissed
tobiasd left a comment
Owner
Copy Link
Copy Source

Except for the links to the wiki which should point to docs it is looking good for me :)

Except for the links to the wiki which should point to docs it is looking good for me :)
delliott force-pushed feat/python-checks from a0b532d92b to e5af974daa 2026-02-26 12:24:18 +00:00 Compare
delliott commented 2026-02-26 12:24:51 +00:00
Author
Member
Copy Link
Copy Source

Links have been changed from wiki to docs.

Links have been changed from wiki to docs.
tobiasd approved these changes 2026-02-26 12:40:47 +00:00
tobiasd merged commit baf96e4d11 into master 2026-02-26 12:40:58 +00:00
tobiasd deleted branch feat/python-checks 2026-02-26 12:40:58 +00:00
tobiasd referenced this issue from a commit 2026-02-26 12:40:59 +00:00
feat/python-checks (#5651)
Sign in to join this conversation.
Reviewers
No Reviewers
tobiasd
Labels
Clear labels
Accessibility
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert (Albert Dengg) alex.busch (alex.busch) alex.sander (alex.sander) anaghz (anaghz) annarita.russo (annarita.russo) ao (André Ockers) bonnie (bonnie) ciampix (Marco Ciampa) cryptie (cryptie) dario (dario) delliott (delliott) dfajfer (Damian Fajfer) dmaphy (Dominic Hopf) doczkal (Thomas Doczkal) eal (eal) egnun (Erik Grun) eventregbot (eventregbot) fi (fi) floriansnow (Florian Snow) gabriel.ku (gabriel.ku) guido (guido) hf (hf) hugo (hugo) ineiev (ineiev) jithendra (jithendra) jn (jn) jzarl (jzarl) linus (Linus Sehn) lucabon (Luca Bonissi) lucas.lasota (lucas.lasota) max.mehl (Max Mehl) mk (Matthias Kirschner) monochromec (monochromec) mweimann (Michael Weimann) nico.rikken (nico.rikken) patrick (Patrick Ohnewein) reinhard (Reinhard Müller) renovate-bot (Renovate Bot) repentinus (Heiki Lõhmus) schiessle (Björn Schießle) silviarbgl (Silvia Rbgl) sofiaritz (Sofía Aritz) tobiasd (tobiasd) vincent (vincent)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#5651
Delete Branch "feat/python-checks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?