cleanup: fix simple broken links #5635

2026-01-19T12:10:40Z

hl commented

2026-01-19 12:10:40 +00:00

CI does not accept them because the text is not the same in the translated version.

Editing old news makes no sense from a time perspective.

I would force merge without CI approval

CI does not accept them because the text is not the same in the translated version. Editing old news makes no sense from a time perspective. I would force merge without CI approval

hl added 1 commit 2026-01-19 12:10:41 +00:00

cleanup: fix simple broken links

continuous-integration/drone/pr Build is failing

Details

94bf1979a2

hl added 1 commit 2026-01-19 12:12:27 +00:00

Merge branch 'master' into fix-broken-links

continuous-integration/drone/pr Build is failing

Details

bf5ab94b16

tobiasd commented

2026-01-21 11:41:27 +00:00

A force merge would break the main branch for the website build, as the same tests that are failing now are also performed there.

So either also keep the broken links or fix the pages properly.

A force merge would break the main branch for the website build, as the same tests that are failing now are also performed there. So either also keep the broken links or fix the pages properly.

delliott commented

2026-01-25 10:32:48 +00:00

A force merge would break the main branch for the website build, as the same tests that are failing now are also performed there.

So either also keep the broken links or fix the pages properly.

If I recall correctly, this is not quite true.

We do run the checks again, but after merging to master there is no way for the ci to tell what was there before the merge and what was there after, i.e the diff.

If our repo was fully compliant that would be fine, we just run the checks for all files. But it is very much not fully compliant, so that would just always fail. Instead we run the checks on merge, but things based on changed files, such as the xml structure compare, are not ran on any files.

We do run checks not based on changed files, such as pytest on master after a merge.

You can see what checks are/are not ran in the output, eg https://drone.fsfe.org/FSFE/fsfe-website/18263/1/2

> A force merge would break the main branch for the website build, as the same tests that are failing now are also performed there. > > So either also keep the broken links or fix the pages properly. If I recall correctly, this is not quite true. We do run the checks again, but after merging to master there is no way for the ci to tell what was there before the merge and what was there after, i.e the diff. If our repo was fully compliant that would be fine, we just run the checks for all files. But it is very much not fully compliant, so that would just always fail. Instead we run the checks on merge, but things based on changed files, such as the xml structure compare, are not ran on any files. We do run checks not based on changed files, such as `pytest` on master after a merge. You can see what checks are/are not ran in the output, eg https://drone.fsfe.org/FSFE/fsfe-website/18263/1/2

delliott commented

2026-02-26 12:25:22 +00:00

@tobiasd I think we can merge this?

bonnie added 1 commit 2026-04-13 10:07:44 +00:00

Fix CI issues

continuous-integration/drone/pr Build is failing

Details

53eecd1108

bonnie added 1 commit 2026-04-13 10:14:54 +00:00

remove style video

continuous-integration/drone/pr Build is failing

Details

8f97da1dc2

tobiasd merged commit 1804e3bd9c into master

2026-04-13 10:20:31 +00:00

tobiasd referenced this issue from a commit

2026-04-13 10:20:34 +00:00

cleanup: fix simple broken links (#5635)

tobiasd deleted branch fix-broken-links

2026-04-13 10:20:36 +00:00

Sign in to join this conversation.

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#5635