FSFE/fsfe-website
27
33
Fork 93
Code Issues 64 Pull Requests 18 Wiki Activity

fix/events-wiki #5628

Merged
tobiasd merged 4 commits from fix/events-wiki into master 2026-01-27 10:32:28 +00:00
Conversation 3 Commits 4 Files Changed 7 +10 -53
delliott commented 2026-01-15 15:09:31 +00:00
Member
Copy Link

fixes #5622

fixes https://git.fsfe.org/FSFE/fsfe-website/issues/5622
delliott requested review from mk 2026-01-15 15:09:32 +00:00
delliott force-pushed fix/events-wiki from 5a8b949443 to 19f3e65716 2026-01-15 15:09:43 +00:00 Compare
delliott added a new dependency 2026-01-15 15:09:56 +00:00
#5622 Remove outdated sidebar about wiki events from event page
tobiasd reviewed 2026-01-15 16:01:15 +00:00
fsfe.org/events/events.de.xhtml Outdated
@@ -59,3 +59,3 @@
<p>
Beachte, dass alle FSFE-Events von unserem
<a href="/about/codeofconduct">Verhaltenskodex</a>
<a href="/about/codeofconduct.html">Verhaltenskodex</a>
tobiasd commented 2026-01-15 16:01:15 +00:00
Owner
Copy Link

The .html is not needed for the link to work as apache2 will resolve it correctly to the matching HTML file.

The `.html` is not needed for the link to work as apache2 will resolve it correctly to the matching HTML file.
delliott commented 2026-01-15 16:13:14 +00:00
Author
Member
Copy Link

I see, I was just making the files match. Four our internal postfixing to link directly it must end in .html. If apache handles it it does not matter though I guess.

I see, I was just making the files match. Four our internal postfixing to link directly it must end in .html. If apache handles it it does not matter though I guess.
delliott commented 2026-01-25 10:22:50 +00:00
Author
Member
Copy Link

I think I will keep the .html ending: I think I prefer to rely on our build system to sort out links than our webserver, as ideally we would eventually be webserver agnostic.

I think I will keep the .html ending: I think I prefer to rely on our build system to sort out links than our webserver, as ideally we would eventually be webserver agnostic.
delliott marked this conversation as resolved
tobiasd reviewed 2026-01-15 16:03:07 +00:00
fsfe.org/events/events.en.xhtml Outdated
@@ -7,3 +7,3 @@
</head>
<body class="toplevel article ltr">
<body class="toplevel article">
tobiasd commented 2026-01-15 16:03:07 +00:00
Owner
Copy Link

The ltr class will prevent the wrong display in rtl languages that have no events.XX.xhtml page and fall back to the English version.

The `ltr` class will prevent the wrong display in `rtl` languages that have no `events.XX.xhtml` page and fall back to the English version.
delliott commented 2026-01-15 16:13:52 +00:00
Author
Member
Copy Link

So should we always be fixing every body with ltr? I would have thought this a problem for css/language based xsl?

So should we always be fixing every body with `ltr`? I would have thought this a problem for css/language based xsl?
delliott commented 2026-01-25 10:21:59 +00:00
Author
Member
Copy Link

I have whitelisted the body for the diff checks, and returned the ltr class.

I have whitelisted the body for the diff checks, and returned the ltr class.
delliott marked this conversation as resolved
mk declined to review 2026-01-16 05:33:43 +00:00
mk commented 2026-01-16 06:39:15 +00:00
Owner
Copy Link

(I removed myself as technical reviewer.)

(I removed myself as technical reviewer.)
delliott force-pushed fix/events-wiki from 19f3e65716 to daae5f1613 2026-01-25 10:21:12 +00:00 Compare
delliott requested review from tobiasd 2026-01-25 10:26:31 +00:00
tobiasd merged commit 0d99c0f164 into master 2026-01-27 10:32:28 +00:00
tobiasd deleted branch fix/events-wiki 2026-01-27 10:32:29 +00:00
tobiasd referenced this issue from a commit 2026-01-27 10:32:30 +00:00
fix/events-wiki (#5628)
Sign in to join this conversation.
Reviewers
No Reviewers
tobiasd
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bcludts bonnie cryptie dario delliott dfajfer dmaphy doczkal eal egnun eventregbot fi floriansnow gabriel.ku guido hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard renovate-bot repentinus schiessle sofiaritz tobiasd vincent
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Blocks
#5622 Remove outdated sidebar about wiki events from event page
FSFE/fsfe-website
Reference: FSFE/fsfe-website#5628
Delete Branch "fix/events-wiki"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?