FSFE/fsfe-website
27
32
Fork 93
Code Issues 63 Pull Requests 18 Wiki Activity

feat/config #5590

Merged
tobiasd merged 8 commits from feat/config into master 2026-01-15 15:49:45 +00:00
Conversation 1 Commits 8 Files Changed 25 +360 -221
delliott commented 2025-12-26 11:19:10 +00:00
Member
Copy Link
  • use nargs instead of splitting strings. Nicer logic, more standard
  • Show default values of args in help message
  • each site can now have a config.toml with deps and required files for deployment.
  • cleaner argument handling and custom value generation
  • use dataclass to hold args, or cleaner typing
  • pass config types to run commands instead of individual args
  • clean up the whole build.py file

Overall, this is a nice internal refactor that also offers the feature of per site config.

It does have a breaking change of how multiple args are handled, but the arg help page should explain it just fine.

- use nargs instead of splitting strings. Nicer logic, more standard - Show default values of args in help message - each site can now have a `config.toml` with deps and required files for deployment. - cleaner argument handling and custom value generation - use dataclass to hold args, or cleaner typing - pass config types to run commands instead of individual args - clean up the whole build.py file Overall, this is a nice internal refactor that also offers the feature of per site config. It does have a breaking change of how multiple args are handled, but the arg help page should explain it just fine.
delliott requested review from tobiasd 2025-12-26 11:50:24 +00:00
delliott commented 2025-12-26 17:31:27 +00:00
Author
Member
Copy Link

Has been ran on test to ensure it works:

https://drone.fsfe.org/FSFE/fsfe-website/18032

Has been ran on test to ensure it works: https://drone.fsfe.org/FSFE/fsfe-website/18032
delliott force-pushed feat/config from d2bc7c899e to 9d0ad0d5ec 2025-12-27 11:33:25 +00:00 Compare
delliott force-pushed feat/config from 9d0ad0d5ec to fdb7de3584 2026-01-13 12:07:24 +00:00 Compare
tobiasd merged commit ad79262abf into master 2026-01-15 15:49:45 +00:00
tobiasd referenced this issue from a commit 2026-01-15 15:49:45 +00:00
feat/config (#5590)
tobiasd deleted branch feat/config 2026-01-15 15:49:46 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
tobiasd
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bcludts bonnie cryptie dario delliott dfajfer dmaphy doczkal eal egnun eventregbot fi fkobi floriansnow gabriel.ku guido hl hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard renovate-bot repentinus schiessle sofiaritz tobiasd vincent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#5590
Delete Branch "feat/config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?