pre-commit.Dockerfile: do not reinstall essential packages #5545

2025-12-04T09:49:12Z

fkobi commented

2025-12-04 09:49:12 +00:00

Gentoo calls them @system, Debian calls them essential.
These provide the basic system functionality and it can be assumed that they are always present.

Removing them from here keeps the dockerfile cleaner & the build process faster.

I've left perl-base in there as it's pretty heavy and Gentoo and Alpine do not install it by default

Signed-off-by: Filip Kobierski fkobi@fsfe.org

Gentoo calls them @system, Debian calls them essential. These provide the basic system functionality and it can be assumed that they are always present. Removing them from here keeps the dockerfile cleaner & the build process faster. I've left perl-base in there as it's pretty heavy and Gentoo and Alpine do not install it by default Signed-off-by: Filip Kobierski <fkobi@fsfe.org>

delliott was assigned by fkobi

2025-12-04 09:49:12 +00:00

fkobi added 1 commit 2025-12-04 09:49:13 +00:00

pre-commit.Dockerfile: do not reinstall essential packages

continuous-integration/drone/pr Build is passing

Details

653bc2e73a

Gentoo calls them @system, Debian calls them essential.
These provide the basic system functionality and it can be assumed that they are always present.

Removing them from here keeps the dockerfile cleaner & the build process faster.

I've left perl-base in there as it's pretty heavy and Gentoo and Alpine do not install it by default

Signed-off-by: Filip Kobierski <fkobi@fsfe.org>

fkobi added the enhancement label 2025-12-04 09:54:24 +00:00

delliott approved these changes 2025-12-04 11:30:45 +00:00

delliott left a comment

I added them to make clearer exactly what we depend upon, and the speed cost is minimal.

But its fair enough not to install them.

LGTM

I added them to make clearer exactly what we depend upon, and the speed cost is minimal. But its fair enough not to install them. LGTM

tobiasd merged commit 5605a7853b into master

2025-12-04 16:08:52 +00:00

tobiasd deleted branch smaller-reinstall

2025-12-04 16:08:52 +00:00

tobiasd referenced this issue from a commit

2025-12-04 16:08:53 +00:00

pre-commit.Dockerfile: do not reinstall essential packages (#5545)

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#5545