Improvements for spreadtheword page #549

2018-10-18T15:09:59Z

max.mehl commented

2018-10-18 15:09:59 +00:00

See #535 for discussion. This PR will close it eventually.

Add checkboxes to set preferences for desired languages of the promo material
Add radio buttons to choose between standard package or custom package
Make the "I would like to use the material for" field mandatory and use a placeholder to describe what to fill in
Add a checkbox to enable people to receive information about the FSFE (add to community database as contact)
~~~Make donation amount field mandatory, blank, and use a placeholder of 10~~ (will do that later)

See #535 for discussion. This PR will close it eventually. - [x] Add checkboxes to set preferences for desired languages of the promo material - [x] Add radio buttons to choose between standard package or custom package - [x] Make the "I would like to use the material for" field mandatory and use a placeholder to describe what to fill in - [x] Add a checkbox to enable people to receive information about the FSFE (add to community database as contact) - [x] ~~Make donation amount field mandatory, blank, and use a placeholder of ~10~~ (will do that later)

max.mehl commented

2018-10-18 15:33:48 +00:00

@eal @reinhard You can also make changes to my branch improve-stw-535. This way, we can collaborate easily.

In order to do so, you can do:

git remote add max.mehl https://git.fsfe..org/max.mehl/fsfe-website.git
git fetch max.mehl

After you've done this once, you can always do:

git checkout max.mehl/improve-stw-535
git pull max.mehl improve-stw-535
# do some changes and commits
git push max.mehl improve-stw-535

@eal @reinhard You can also make changes to my branch `improve-stw-535`. This way, we can collaborate easily. In order to do so, you can do: ``` git remote add max.mehl https://git.fsfe..org/max.mehl/fsfe-website.git git fetch max.mehl ``` After you've done this once, you can always do: ``` git checkout max.mehl/improve-stw-535 git pull max.mehl improve-stw-535 # do some changes and commits git push max.mehl improve-stw-535 ```

max.mehl commented

2018-10-18 15:35:37 +00:00

In order to preview my changes, I recommend using local builds. It should be sufficient to run fsfe-preview contribute/spreadtheword.en.xhtml as no other files have been touched so far.

In order to preview my changes, I recommend using [local builds](https://wiki.fsfe.org/TechDocs/Mainpage/BuildLocally). It should be sufficient to run `fsfe-preview contribute/spreadtheword.en.xhtml` as no other files have been touched so far.

eal commented

2018-10-23 09:20:06 +00:00

Hi Max,
thank you very much for the implementations so far, there are already some big steps forward. I did a test right now and here is some feedback:

You can choose multiple languages now. does that make sense? I can for example have language preferences in two or three languages. Which language shall I send then, if we have items in all languages mentioned available?
Last steps: there is a field "Which address shall be use" (sic) - what does that mean?
"Receive the latest Free Software news: I want to receive occasional information about FSFE's activities (less than one email a week on average)"
--> do I receive Free Software news or information about FSFE's activities? I would stick to the latter
--> let's drop any mentioning of a frequency how often we send. I do not see any advantage in it and to me currently sounds a lot ( I skim and read one mail a week)
"I would like to use the material for (short description):"
--> If I think about having it obligatory to fill in something here combined with the obligation to state some amount of money (even though 0 is possible) i would change the blindtext slightly to: "For example: myself, my friends, spread information about Free Software in my sourrounding, at event xyz etc." Currently it reads like an obligation to spread our material. I am also fine with people giving us 10 euro and order for themselves and put a sticker on their laptop.
"0 or >10" is a good approach good imho

On a more general level, I think the order form is very long now. It is 2,5 screens on my big monitor. And this before the first item appears.
I wonder if putting the order form at the end would be a better UX? We could still start with a visible button "order now" that sends you down with an anchor. What do you think?

Hi Max, thank you very much for the implementations so far, there are already some big steps forward. I did a test right now and here is some feedback: * You can choose multiple languages now. does that make sense? I can for example have language preferences in two or three languages. Which language shall I send then, if we have items in all languages mentioned available? * Last steps: there is a field "Which address shall be use" (sic) - what does that mean? * "Receive the latest Free Software news: I want to receive occasional information about FSFE's activities (less than one email a week on average)" --> do I receive Free Software news or information about FSFE's activities? I would stick to the latter --> let's drop any mentioning of a frequency how often we send. I do not see any advantage in it and to me currently sounds a lot ( I skim and read one mail a week) * "I would like to use the material for (short description):" --> If I think about having it obligatory to fill in something here combined with the obligation to state some amount of money (even though 0 is possible) i would change the blindtext slightly to: "For example: myself, my friends, spread information about Free Software in my sourrounding, at event xyz etc." Currently it reads like an obligation to spread our material. I am also fine with people giving us 10 euro and order for themselves and put a sticker on their laptop. * "0 or >10" is a good approach good imho On a more general level, I think the order form is very long now. It is 2,5 screens on my big monitor. And this before the first item appears. I wonder if putting the order form at the end would be a better UX? We could still start with a visible button "order now" that sends you down with an anchor. What do you think?

max.mehl commented

2018-10-23 11:20:53 +00:00

Hi Erik,

You can choose multiple languages now. does that make sense? I can for example have language preferences in two or three languages. Which language shall I send then, if we have items in all languages mentioned available?

This has been wished by Ulrike because the former way of finding out the preferences of the user was erratic (it has been based on the language of the page). If someone in South Tyrol wishes 2 languages and they are German and Italian for example, it makes perfect sense. Of course, evaluation is still necessary for the ones packing the promo material, but it might prevent sending English-only material to Italy in the future.

Last steps: there is a field “Which address shall be use” (sic) - what does that mean?

Actually this is a hidden field (class: "special") to catch bots. On your computer in the repository please run fsfe-preview --copy look/fsfe.min.css to load the latest CSS version for your local previews.

“Receive the latest Free Software news: I want to receive occasional information about FSFE’s activities (less than one email a week on average)” --> do I receive Free Software news or information about FSFE’s activities? I would stick to the latter --> let’s drop any mentioning of a frequency how often we send. I do not see any advantage in it and to me currently sounds a lot ( I skim and read one mail a week)

This is the default language used in your personal setting on my.fsfe.org for example. I would suggest we stick to this, but I'd leave this to @reinhard to decide.

“I would like to use the material for (short description):” --> If I think about having it obligatory to fill in something here combined with the obligation to state some amount of money (even though 0 is possible) i would change the blindtext slightly to: “For example: myself, my friends, spread information about Free Software in my sourrounding, at event xyz etc.” Currently it reads like an obligation to spread our material. I am also fine with people giving us 10 euro and order for themselves and put a sticker on their laptop.

Fine for me. Would you like to change it? You can also push a change to this branch ;)

I wonder if putting the order form at the end would be a better UX? We could still start with a visible button “order now” that sends you down with an anchor. What do you think?

Makes sense. IIRC, we've had the form at the bottom for a longer period but moved it up. But I like the approach of having a button leading to the bottom. Would you like to suggest something directly?

Hi Erik, > You can choose multiple languages now. does that make sense? I can for example have language preferences in two or three languages. Which language shall I send then, if we have items in all languages mentioned available? This has been wished by Ulrike because the former way of finding out the preferences of the user was erratic (it has been based on the language of the page). If someone in South Tyrol wishes 2 languages and they are German and Italian for example, it makes perfect sense. Of course, evaluation is still necessary for the ones packing the promo material, but it might prevent sending English-only material to Italy in the future. > Last steps: there is a field “Which address shall be use” (sic) - what does that mean? Actually this is a hidden field (class: "special") to catch bots. On your computer in the repository please run `fsfe-preview --copy look/fsfe.min.css` to load the latest CSS version for your local previews. > “Receive the latest Free Software news: I want to receive occasional information about FSFE’s activities (less than one email a week on average)” --> do I receive Free Software news or information about FSFE’s activities? I would stick to the latter --> let’s drop any mentioning of a frequency how often we send. I do not see any advantage in it and to me currently sounds a lot ( I skim and read one mail a week) This is the default language used in your personal setting on my.fsfe.org for example. I would suggest we stick to this, but I'd leave this to @reinhard to decide. > “I would like to use the material for (short description):” --> If I think about having it obligatory to fill in something here combined with the obligation to state some amount of money (even though 0 is possible) i would change the blindtext slightly to: “For example: myself, my friends, spread information about Free Software in my sourrounding, at event xyz etc.” Currently it reads like an obligation to spread our material. I am also fine with people giving us 10 euro and order for themselves and put a sticker on their laptop. Fine for me. Would you like to change it? You can also push a change to this branch ;) > I wonder if putting the order form at the end would be a better UX? We could still start with a visible button “order now” that sends you down with an anchor. What do you think? Makes sense. IIRC, we've had the form at the bottom for a longer period but moved it up. But I like the approach of having a button leading to the bottom. Would you like to suggest something directly?

max.mehl referenced this issue from a commit

2018-11-02 10:12:07 +00:00

copy file from #549 at commit 16e0174483

max.mehl commented

2018-11-02 10:30:13 +00:00

Now also available as a preview in the test instance: https://test.fsfe.org/contribute/spreadtheword.en.html

reinhard commented

2018-11-02 10:58:44 +00:00

I can submit the form with selecting neither "Default" nor "Custom".

Also, I guess the option to subscribe to the FSFE Community Database is not really implemented yet, and it would require some work on the fsfe-cd side, als well as possibly some thinking about how to avoid spam subscriptions through this channel.

I can submit the form with selecting neither "Default" nor "Custom". Also, I guess the option to subscribe to the FSFE Community Database is not really implemented yet, and it would require some work on the fsfe-cd side, als well as possibly some thinking about how to avoid spam subscriptions through this channel.

max.mehl commented

2018-11-02 11:28:16 +00:00

I can submit the form with selecting neither “Default” nor “Custom”.

Oh thanks, fixed!

Also, I guess the option to subscribe to the FSFE Community Database is not really implemented yet, and it would require some work on the fsfe-cd side, als well as possibly some thinking about how to avoid spam subscriptions through this channel.

Absolutely. I didn't do anything on the backend side yet.

> I can submit the form with selecting neither “Default” nor “Custom”. Oh thanks, fixed! > Also, I guess the option to subscribe to the FSFE Community Database is not really implemented yet, and it would require some work on the fsfe-cd side, als well as possibly some thinking about how to avoid spam subscriptions through this channel. Absolutely. I didn't do anything on the backend side yet.

max.mehl commented

2019-01-11 14:01:06 +00:00

Will merge this to master now. It contains the changes in the first post, so no things involving OTRS or the CD, and also not the article selector or the extra donation website.

max.mehl closed this pull request

2019-01-11 14:02:24 +00:00

max.mehl deleted branch improve-stw-535

2019-01-11 14:02:34 +00:00

reinhard referenced this issue from a commit

2019-04-02 12:19:07 +00:00

First improvements for spreadtheword page (#549) Will close the first items proposed in #535

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#549

Allow edits from maintainers