FSFE/fsfe-website
31
33
Fork 96
Code Issues 66 Pull Requests 18 Wiki Activity

feat/overview #5435

Merged
tobiasd merged 2 commits from feat/overview into master 2025-10-28 05:27:22 +00:00
Conversation 2 Commits 2 Files Changed 8
+249 -95
delliott commented 2025-10-27 14:56:45 +00:00
Member
Copy Link
Copy Source
  • fixes issues with xml structure pre commit hook
  • Moves comprea-files to lib
  • adds a n overview page on status.fsfe.org to see what files have different structures
- fixes issues with xml structure pre commit hook - Moves comprea-files to lib - adds a n overview page on status.fsfe.org to see what files have different structures
delliott added 2 commits 2025-10-27 14:56:46 +00:00
feat: break compare xml into lib function 50e63113e2
feat: status page for xml strcture difference data
continuous-integration/drone/pr Build is passing
Details
5b27764a46
delliott requested review from tobiasd 2025-10-27 14:56:59 +00:00
tobiasd merged commit 81d0b63a6e into master 2025-10-28 05:27:22 +00:00
tobiasd referenced this issue from a commit 2025-10-28 05:27:25 +00:00
feat/overview (#5435)
tobiasd deleted branch feat/overview 2025-10-28 05:27:25 +00:00
fkobi reviewed 2025-10-28 16:37:57 +00:00
status.fsfe.org/xml_structure/__init__.py
@@ -0,0 +1,6 @@
# SPDX-FileCopyrightText: Free Software Foundation Europe e.V. <https://fsfe.org>
fkobi commented 2025-10-28 16:37:57 +00:00
Contributor
Copy Link
Copy Source

this should be an empty file IMO. It's contents are very basic Python knowledge and half the lines are just REUSE

this should be an empty file IMO. It's contents are very basic Python knowledge and half the lines are just REUSE
delliott commented 2025-10-28 16:41:08 +00:00
Author
Member
Copy Link
Copy Source

Yeah, fair. I try and keep the Python reuse compliant, and am planning on adding reuse to enforce that in ci soon.

The explanation is probably unnecessary, I have just been copying around the same file for every time I need it.

Yeah, fair. I try and keep the Python reuse compliant, and am planning on adding reuse to enforce that in ci soon. The explanation is probably unnecessary, I have just been copying around the same file for every time I need it.
fkobi reviewed 2025-10-28 16:40:56 +00:00
tools/ci-checks/compare-xml-structure.py
@@ -172,9 +84,9 @@ def main() -> None:
tasks.extend((master, path, args.whitelist) for path in paths if path != master)
with multiprocessing.Pool(processes=args.jobs) as pool:
filtered_results = (
fkobi commented 2025-10-28 16:40:56 +00:00
Contributor
Copy Link
Copy Source

@delliott do you care to explain this change?

@delliott do you care to explain this change?
delliott commented 2025-10-28 16:44:33 +00:00
Author
Member
Copy Link
Copy Source

The lazy generator using ( seemed to be false incorrectly when coerced to bool for some reason, and the eager one [ was not.

I did not bother to investigate further.

The lazy generator using `(` seemed to be false incorrectly when coerced to bool for some reason, and the eager one `[` was not. I did not bother to investigate further.
👍 1
fkobi marked this conversation as resolved
Sign in to join this conversation.
Reviewers
No Reviewers
tobiasd
fkobi
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert (Albert Dengg) alex.busch (alex.busch) alex.sander (alex.sander) anaghz (anaghz) annarita.russo (annarita.russo) ao (André Ockers) bcludts (bcludts) bonnie (bonnie) ciampix (Marco Ciampa) cryptie (cryptie) dario (dario) delliott (delliott) dfajfer (Damian Fajfer) dmaphy (Dominic Hopf) doczkal (Thomas Doczkal) eal (eal) egnun (Erik Grun) eventregbot (eventregbot) fi (fi) floriansnow (Florian Snow) gabriel.ku (gabriel.ku) guido (guido) hugo (hugo) ineiev (ineiev) jithendra (jithendra) jn (jn) jzarl (jzarl) linus (Linus Sehn) lucabon (Luca Bonissi) lucas.lasota (lucas.lasota) max.mehl (Max Mehl) mk (Matthias Kirschner) monochromec (monochromec) mweimann (Michael Weimann) nico.rikken (nico.rikken) patrick (Patrick Ohnewein) reinhard (Reinhard Müller) renovate-bot (Renovate Bot) repentinus (Heiki Lõhmus) schiessle (Björn Schießle) silviarbgl (Silvia Rbgl) sofiaritz (Sofía Aritz) tobiasd (tobiasd) vincent (vincent)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#5435
Delete Branch "feat/overview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?