FSFE/fsfe-website
30
33
Fork 98
Code Issues 66 Pull Requests 18 Wiki Activity

feat/php-linter #5321

Merged
tobiasd merged 5 commits from feat/php-linter into master 2025-09-24 18:13:51 +00:00
Conversation 3 Commits 5 Files Changed 11
+530 -499
delliott commented 2025-09-20 13:50:48 +00:00
Member
Copy Link
Copy Source

At least helps with #5297

At least helps with https://git.fsfe.org/FSFE/fsfe-website/issues/5297
delliott marked the pull request as work in progress 2025-09-20 15:55:08 +00:00
delliott marked the pull request as ready for review 2025-09-22 09:31:25 +00:00
delliott requested review from tobiasd 2025-09-22 09:31:36 +00:00
delliott requested review from hl 2025-09-23 15:31:01 +00:00
delliott added the cgi Scripting label 2025-09-24 11:27:09 +00:00
tobiasd commented 2025-09-24 13:06:48 +00:00
Owner
Copy Link
Copy Source

The content of the PHPMailer subdirectory is 3rd party content, not sure if we should touch it to make the linter happy... do we have to? Or will it pop up every time the linter is running otherwise?

The content of the PHPMailer subdirectory is 3rd party content, not sure if we should touch it to make the linter happy... do we have to? Or will it pop up every time the linter is running otherwise?
delliott commented 2025-09-24 13:08:51 +00:00
Author
Member
Copy Link
Copy Source

Ah, I see. We should be able to add an ignore to the linter, I think.

Ah, I see. We should be able to add an ignore to the linter, I think.
delliott added 1 commit 2025-09-24 13:29:07 +00:00
feat: run php linter on all php files
continuous-integration/drone/pr Build is passing
Details
677eac4288
delliott commented 2025-09-24 13:29:13 +00:00
Author
Member
Copy Link
Copy Source

And done, we no longer lint phpmailer

And done, we no longer lint phpmailer
tobiasd merged commit b390c5472e into master 2025-09-24 18:13:50 +00:00
tobiasd referenced this issue from a commit 2025-09-24 18:13:53 +00:00
feat/php-linter (#5321)
tobiasd deleted branch feat/php-linter 2025-10-24 16:06:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
tobiasd
hl
Labels
Clear labels
Accessibility
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No labels cgi Scripting
Milestone
No items
No Milestone
Assignees
Clear assignees
albert (Albert Dengg) alex.busch (alex.busch) alex.sander (alex.sander) anaghz (anaghz) annarita.russo (annarita.russo) ao (André Ockers) bonnie (bonnie) ciampix (Marco Ciampa) cryptie (cryptie) dario (dario) delliott (Darragh Elliott) dfajfer (Damian Fajfer) dmaphy (Dominic Hopf) doczkal (Thomas Doczkal) eal (eal) egnun (Erik Grun) eventregbot (eventregbot) fi (fi) floriansnow (Florian Snow) foxort (Tino Tempesta) gabriel.ku (gabriel.ku) guido (guido) hf (hf) hugo (hugo) ineiev (ineiev) jithendra (jithendra) jn (jn) jzarl (jzarl) linus (Linus Sehn) lucabon (Luca Bonissi) lucas.lasota (lucas.lasota) max.mehl (Max Mehl) mk (Matthias Kirschner) monochromec (monochromec) mweimann (Michael Weimann) nico.rikken (nico.rikken) patrick (Patrick Ohnewein) reinhard (Reinhard Müller) renovate-bot (Renovate Bot) repentinus (Heiki Lõhmus) schiessle (Björn Schießle) silviarbgl (Silvia Rbgl) sofiaritz (Sofía Aritz) tobiasd (tobiasd) vincent (vincent)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#5321