FSFE/fsfe-website
28
32
Fork 93
Code Issues 59 Pull Requests 14 Wiki Activity

build/email-subjects #5281

Merged
tobiasd merged 3 commits from build/email-subjects into master 2025-09-08 05:47:05 +00:00
Conversation 1 Commits 3 Files Changed 7 +16 -6
delliott commented 2025-09-03 10:09:27 +00:00
Member
Copy Link

Allow specifying a subject in our email element.

Eg the xhtml content

<email mailto="yes" subject="Ada and Zangemann">contact@fsfe.org</email>

Will now generate

<a href="mailto:contact@fsfe.org?subject=Ada and Zangemann">contact@fsfe.org</a>

Which when clicked will open an email client, and correctly populate the subject.

I also added the subject to all ada zangemann pages, and have documented it on the web features page.

Resolves #2742

Allow specifying a subject in our email element. Eg the xhtml content ```xml <email mailto="yes" subject="Ada and Zangemann">contact@fsfe.org</email> ``` Will now generate ```xml <a href="mailto:contact@fsfe.org?subject=Ada and Zangemann">contact@fsfe.org</a> ``` Which when clicked will open an email client, and correctly populate the subject. I also added the subject to all ada zangemann pages, and have documented it on the web features page. Resolves https://git.fsfe.org/FSFE/fsfe-website/issues/2742
delliott force-pushed build/email-subjects from adcd3289a1 to daeade7a24 2025-09-03 10:10:41 +00:00 Compare
delliott requested review from tobiasd 2025-09-03 10:37:26 +00:00
delliott requested review from mk 2025-09-03 10:37:35 +00:00
tobiasd reviewed 2025-09-06 05:59:06 +00:00
build/xslt/email-obfuscate.xsl
@@ -85,6 +86,11 @@
-->
<xsl:text disable-output-escaping="yes">&lt;a href="mailto:</xsl:text>
<xsl:value-of select="$email-encoded" disable-output-escaping="yes"/>
<xsl:text>?</xsl:text>
tobiasd commented 2025-09-06 05:59:06 +00:00
Owner
Copy Link

I'm wondering on the order of the separator ? added before the check if the $subject is set. The separator is only needed if a subject is set right?

I'm wondering on the order of the separator `?` added before the check if the `$subject` is set. The separator is only needed if a subject is set right?
delliott commented 2025-09-07 11:11:36 +00:00
Author
Member
Copy Link

I did it like this so that if in future we add another param, like say a cc we can do so without any logic around if it is the first param added having to add the question mark?

I can change it if we like, I think it matters little.

I did it like this so that if in future we add another param, like say a cc we can do so without any logic around if it is the first param added having to add the question mark? I can change it if we like, I think it matters little.
👍 1
tobiasd marked this conversation as resolved
tobiasd merged commit 235d86bed9 into master 2025-09-08 05:47:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mk
tobiasd
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bcludts bonnie cryptie dario delliott dfajfer dmaphy doczkal eal egnun eventregbot fi fkobi floriansnow gabriel.ku guido hl hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard renovate-bot repentinus schiessle sofiaritz tobiasd vincent
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#5281
Delete Branch "build/email-subjects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?