build/email-subjects #5281

2025-09-03T10:09:27Z

delliott commented

2025-09-03 10:09:27 +00:00

Allow specifying a subject in our email element.

Eg the xhtml content

<email mailto="yes" subject="Ada and Zangemann">contact@fsfe.org</email>

Will now generate

<a href="mailto:contact@fsfe.org?subject=Ada and Zangemann">contact@fsfe.org</a>

Which when clicked will open an email client, and correctly populate the subject.

I also added the subject to all ada zangemann pages, and have documented it on the web features page.

Resolves #2742

Allow specifying a subject in our email element. Eg the xhtml content ```xml <email mailto="yes" subject="Ada and Zangemann">contact@fsfe.org</email> ``` Will now generate ```xml <a href="mailto:contact@fsfe.org?subject=Ada and Zangemann">contact@fsfe.org</a> ``` Which when clicked will open an email client, and correctly populate the subject. I also added the subject to all ada zangemann pages, and have documented it on the web features page. Resolves https://git.fsfe.org/FSFE/fsfe-website/issues/2742

delliott force-pushed build/email-subjects from adcd3289a1 to daeade7a24

2025-09-03 10:10:41 +00:00

Compare

delliott referenced this pull request

2025-09-03 10:12:24 +00:00

Including subject into new email tag #2742

delliott requested review from tobiasd 2025-09-03 10:37:26 +00:00

delliott requested review from mk 2025-09-03 10:37:35 +00:00

tobiasd reviewed

2025-09-06 05:59:06 +00:00

build/xslt/email-obfuscate.xsl

						
				@@ -85,6 +86,11 @@

				        -->

				        <xsl:text disable-output-escaping="yes">&lt;a href="mailto:</xsl:text>

				        <xsl:value-of select="$email-encoded" disable-output-escaping="yes"/>

				        <xsl:text>?</xsl:text>

tobiasd commented

2025-09-06 05:59:06 +00:00

I'm wondering on the order of the separator ? added before the check if the $subject is set. The separator is only needed if a subject is set right?

I'm wondering on the order of the separator `?` added before the check if the `$subject` is set. The separator is only needed if a subject is set right?

delliott commented

2025-09-07 11:11:36 +00:00

I did it like this so that if in future we add another param, like say a cc we can do so without any logic around if it is the first param added having to add the question mark?

I can change it if we like, I think it matters little.

I did it like this so that if in future we add another param, like say a cc we can do so without any logic around if it is the first param added having to add the question mark? I can change it if we like, I think it matters little.

👍 1

tobiasd marked this conversation as resolved

tobiasd merged commit 235d86bed9 into master

2025-09-08 05:47:05 +00:00

tobiasd referenced this issue from a commit

2025-09-08 05:47:06 +00:00

build/email-subjects (#5281)

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#5281