refactor: use lxml instead of string templating in process_file. #5146

2025-07-13T10:51:04Z

delliott commented

2025-07-13 10:51:04 +00:00

Code looks much cleaner and easier to read, as well as being more performant.

Also prevents the construction of invalid xml.

Some benchmarks:

❯ hyperfine --runs 3 "uv run build --full "; git checkout master; hyperfine --runs 3 "uv run build --full "
Benchmark 1: uv run build --full
  Time (mean ± σ):     287.612 s ±  4.557 s    [User: 1613.681 s, System: 151.556 s]
  Range (min … max):   283.550 s … 292.539 s    3 runs
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
Benchmark 1: uv run build --full
Time (mean ± σ):     357.248 s ±  5.578 s    [User: 2052.506 s, System: 163.057 s]
  Range (min … max):   350.810 s … 360.609 s    3 runs

So this reduces build times by about a minute, getting us down to just under 5 minutes for a full build on my machine.

Code looks much cleaner and easier to read, as well as being more performant. Also prevents the construction of invalid xml. Some benchmarks: ``` ❯ hyperfine --runs 3 "uv run build --full "; git checkout master; hyperfine --runs 3 "uv run build --full " Benchmark 1: uv run build --full Time (mean ± σ): 287.612 s ± 4.557 s [User: 1613.681 s, System: 151.556 s] Range (min … max): 283.550 s … 292.539 s 3 runs Switched to branch 'master' Your branch is up to date with 'origin/master'. Benchmark 1: uv run build --full Time (mean ± σ): 357.248 s ± 5.578 s [User: 2052.506 s, System: 163.057 s] Range (min … max): 350.810 s … 360.609 s 3 runs ``` So this reduces build times by about a minute, getting us down to just under 5 minutes for a full build on my machine.

delliott force-pushed feat/lxml from ac54912b71 to 85af74c12d

2025-07-13 10:51:27 +00:00

Compare

delliott reviewed 2025-07-13 10:53:38 +00:00

build/lib/process_file.py Outdated

						
				@@ -246,0 +211,4 @@

				                href.text,

				                flags=re.MULTILINE | re.IGNORECASE,

				            )

				    except AssertionError:

delliott commented

2025-07-13 10:53:38 +00:00

One feels intuitively that this should be a full failure. But we use the build process to output ics files, and so we instead just catch the error and log it.