FSFE/fsfe-website
25
31
Fork 92
Code Issues 65 Pull Requests 8 Wiki Activity

Implement YH4F videobox #4773

Merged
bonnie merged 3 commits from sofiaritz/fsfe-website:yh4f-video-thingy into master 2025-01-24 08:34:45 +00:00
Conversation 2 Commits 3 Files Changed 4 +103 -1
sofiaritz commented 2025-01-22 11:08:42 +00:00
Member
Copy Link

Implemented using PeerTube iframes because now you can disable P2P for iframes [1].
The talks element is only added to the English page because the talks are in English.

If YH4F talks are carried out in other languages, it should be as simple as creating a talks.[lang].xml file with the links and adding the talks element to the respective page. From a GDPR perspective, as long as the talks are hosted in the FSFE's PeerTube and the p2p option is set to 0, there shouldn't be any problems.

[1] https://docs.joinpeertube.org/api/embed-player#p2p

Implemented using PeerTube iframes because now you can disable P2P for iframes [1]. The `talks` element is only added to the English page because the talks are in English. If YH4F talks are carried out in other languages, it should be as simple as creating a `talks.[lang].xml` file with the links and adding the `talks` element to the respective page. From a GDPR perspective, as long as the talks are hosted in the FSFE's PeerTube and the `p2p` option is set to `0`, there shouldn't be any problems. [1] https://docs.joinpeertube.org/api/embed-player#p2p
sofiaritz force-pushed yh4f-video-thingy from 3799836fcf to 9bb0a64819 2025-01-22 12:30:10 +00:00 Compare
sofiaritz force-pushed yh4f-video-thingy from 1ffd726887 to ace536fccd 2025-01-22 13:19:58 +00:00 Compare
sofiaritz changed title from WIP: Implement YH4F videobox to Implement YH4F videobox 2025-01-22 13:34:43 +00:00
bonnie requested review from bonnie 2025-01-22 14:08:22 +00:00
alvar commented 2025-01-22 20:58:18 +00:00
Contributor
Copy Link

First, thanks a lot for your work. On a first glance, this looks kinda nice and I really appreciate the PeerTube integration!

Implemented using PeerTube iframes because now you can disable P2P for iframes [1].
The talks element is only added to the English page because the talks are in English.

[…] From a GDPR perspective, as long as the talks are hosted in the FSFE's PeerTube and the p2p option is set to 0, there shouldn't be any problems.

[1] https://docs.joinpeertube.org/api/embed-player#p2p

While this is generally true, our PeerTube instance has the P2P feature disabled by default, following the upstream privacy guide.

roles/peertube/templates/var/www/peertube/config/production.yaml.j2 Lines 144 to 153 in 602d0d1bd9
p2p:
# Enable P2P by default in PeerTube client
# Can be enabled/disabled by anonymous users and logged in users
webapp:
enabled: false
# Enable P2P by default in PeerTube embed
# Can be enabled/disabled by URL option
embed:
enabled: false

You can verify this by opening a video - either via an iframe link or from the PeerTube webpage - and taking a look at the bottom-right corner, showing HLS. Only after opening the PeerTube webpage, clicking the settings gear icon in the top-right corner next to Login, selecting "Help share videos being played", saving and reloading, the P2P feature will be enabled, as one can see on a video, showing up- and downstream information instead of HLS.

But just in case, please keep the p2p=0 GET parameter.

Thanks again and please feel free to either ping me when you are working on something PeerTube related or create issues over there.

First, thanks a lot for your work. On a first glance, this looks kinda nice and I really appreciate the PeerTube integration! > Implemented using PeerTube iframes because now you can disable P2P for iframes [1]. > The `talks` element is only added to the English page because the talks are in English. > > […] From a GDPR perspective, as long as the talks are hosted in the FSFE's PeerTube and the `p2p` option is set to `0`, there shouldn't be any problems. > > [1] https://docs.joinpeertube.org/api/embed-player#p2p While this is generally true, our PeerTube instance has the P2P feature disabled by default, following the [upstream privacy guide](https://docs.joinpeertube.org/admin/privacy-guide#player-p2p). https://git.fsfe.org/fsfe-system-hackers/peertube/src/commit/602d0d1bd9db2205b2519007056b5ed432912fe7/roles/peertube/templates/var/www/peertube/config/production.yaml.j2#L144-L153 You can verify this by opening a video - either via an iframe link or from the PeerTube webpage - and taking a look at the bottom-right corner, showing _HLS_. Only after opening the PeerTube webpage, clicking the settings gear icon in the top-right corner next to _Login_, selecting _"Help share videos being played"_, saving and reloading, the P2P feature will be enabled, as one can see on a video, showing up- and downstream information instead of _HLS_. But just in case, please keep the `p2p=0` GET parameter. Thanks again and please feel free to either ping me when you are working on something PeerTube related or create issues [over there](https://git.fsfe.org/fsfe-system-hackers/peertube/issues).
❤️ 1 🚀 1
sofiaritz force-pushed yh4f-video-thingy from b9ecf7c83e to 9b0a825d2f 2025-01-23 08:11:39 +00:00 Compare
sofiaritz force-pushed yh4f-video-thingy from 9b0a825d2f to b3d201560e 2025-01-23 09:53:20 +00:00 Compare
bonnie commented 2025-01-23 11:05:19 +00:00
Member
Copy Link

This looks really good, thank you very much @sofiaritz, I also like how much attention you paid to the GDPR!

As you already did but just to have this officially written somewhere: I would also not include our German talks in this picturebox, as they might not be of much use to the audience. However, maybe we should link to a playlist with all talks on peertube so that people can also access them if they want to. For example to this one: https://media.fsfe.org/my-library/video-playlists/1F94VHv78iGrV1oou5eebU

This looks really good, thank you very much @sofiaritz, I also like how much attention you paid to the GDPR! As you already did but just to have this officially written somewhere: I would also not include our German talks in this picturebox, as they might not be of much use to the audience. However, maybe we should link to a playlist with all talks on peertube so that people can also access them if they want to. For example to this one: https://media.fsfe.org/my-library/video-playlists/1F94VHv78iGrV1oou5eebU
bonnie requested changes 2025-01-23 11:09:57 +00:00
Dismissed
fsfe.org/activities/yh4f/data/talks.en.xml Outdated
@ -0,0 +10,4 @@
</talk>
<talk>
<title>LUGA 2023: Youth Hacking 4 Freedom - Hacking competition for teenagers from Europe</title>
bonnie commented 2025-01-23 11:05:45 +00:00
Member
Copy Link

This talk is in German -> following my comment I would remove it.

This talk is in German -> following my comment I would remove it.
sofiaritz marked this conversation as resolved
fsfe.org/activities/yh4f/index.en.xhtml Outdated
@ -96,6 +96,8 @@ We have an international <a href="/activities/yh4f/jury.html">jury</a>, with lum
educative and exciting days in Brussels and socialise with fellow winners.
</p>
<talks/>
bonnie commented 2025-01-23 11:07:12 +00:00
Member
Copy Link

could we move it just above "Decide yourself what you code"

I am open to discuss this.

could we move it just above "Decide yourself what you code" I am open to discuss this.
sofiaritz marked this conversation as resolved
fsfe.org/activities/yh4f/index.xsl Outdated
@ -16,0 +25,4 @@
}
#yh4f-iframe {
position: absolute;
bonnie commented 2025-01-23 11:09:26 +00:00
Member
Copy Link

I might be absolutely wrong here! How does this work out on mobile end-devices, like Smartphones? Or is there now effect?

I might be absolutely wrong here! How does this work out on mobile end-devices, like Smartphones? Or is there now effect?
sofiaritz commented 2025-01-23 12:09:36 +00:00
Author
Member
Copy Link

That's from the default embedding style from PeerTube, it works just fine on smartphones (tested with the Firefox DevTools). No major effects removing it, I would keep it

That's from the default embedding style from PeerTube, it works just fine on smartphones (tested with the Firefox DevTools). No major effects removing it, I would keep it
bonnie marked this conversation as resolved
sofiaritz force-pushed yh4f-video-thingy from f65c276baa to 468cfb775d 2025-01-23 12:09:47 +00:00 Compare
sofiaritz requested review from bonnie 2025-01-23 12:10:11 +00:00
sofiaritz force-pushed yh4f-video-thingy from 468cfb775d to 862761f482 2025-01-24 08:09:22 +00:00 Compare
bonnie approved these changes 2025-01-24 08:29:52 +00:00
bonnie left a comment
Member
Copy Link

Looks good from my side

Looks good from my side
🎉 1
bonnie merged commit 93fc4c22bd into master 2025-01-24 08:34:45 +00:00
sofiaritz deleted branch yh4f-video-thingy 2025-01-24 08:36:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
bonnie
Labels
Clear labels   
bug

   
build

   
cgi Scripting

   
design

   
disruptive

Requires careful coordination and documentation changes

  
documentation

   
duplicate

   
easy

   
feature-request

   
help wanted

   
javascript

   
priority/low

   
question

   
system-hackers

   
tagging

   
text

   
translations

   
wait/bugfix

   
wait/inprogress

   
wait/misc

   
wait/proofread

   
wontfix

   
xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#4773
No description provided.
Delete Branch "sofiaritz/fsfe-website:yh4f-video-thingy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?