FSFE/fsfe-website
27
32
Fork 92
Code Issues 64 Pull Requests 12 Wiki Activity

feat: remove build-env #4660

Closed
delliott wants to merge 1 commits from (deleted):feat/remove-build-env into master
pull from: (deleted):feat/remove-build-env
merge into: FSFE:master
Conversation 2 Commits 1 Files Changed 13 +27 -84
delliott commented 2024-12-04 12:16:00 +00:00
Member
Copy Link

The only thing specifying a build env introduces at the moment is compiling the less instead of inserting a script for compiling it in browser.

The only real benefit of this is no dependency on lessc for compiling locally.

But it also introduces a divergence between dev env and production env, which is not ideal. It is a nontrivial divergence, as we never really update the less script, while the lessc version on the build server is updated whenever that server is updated. So we can have very divergent versions of lessc in use.

Removing --build-env it simplifies the logic and ensures a more consistent website build.

I have checked the output of building using current master branch with --build-env fsfe.org and on this branch, and there is none. Differences were checked for using diff -r.

This is a nonbreaking pr, as the argument is kept but simply no longer has any effect and will give a deprecation warning.

The only thing specifying a build env introduces at the moment is compiling the less instead of inserting a script for compiling it in browser. The only real benefit of this is no dependency on lessc for compiling locally. But it also introduces a divergence between dev env and production env, which is not ideal. It is a nontrivial divergence, as we never really update the less script, while the lessc version on the build server is updated whenever that server is updated. So we can have very divergent versions of lessc in use. Removing `--build-env` it simplifies the logic and ensures a more consistent website build. I have checked the output of building using current master branch with `--build-env fsfe.org` and on this branch, and there is none. Differences were checked for using `diff -r`. This is a nonbreaking pr, as the argument is kept but simply no longer has any effect and will give a deprecation warning.
delliott changed title from feat: remove build-env to WIP: feat: remove build-env 2024-12-04 12:20:09 +00:00
delliott force-pushed feat/remove-build-env from b22720c680 to e906c7ce95 2024-12-04 13:55:21 +00:00 Compare
delliott changed title from WIP: feat: remove build-env to feat: remove build-env 2024-12-04 13:55:59 +00:00
delliott force-pushed feat/remove-build-env from e906c7ce95 to 4879f24ab2 2024-12-04 13:56:20 +00:00 Compare
delliott requested review from tobiasd 2024-12-04 13:56:37 +00:00
delliott force-pushed feat/remove-build-env from 4879f24ab2 to fbf268abf6 2024-12-18 10:56:02 +00:00 Compare
delliott force-pushed feat/remove-build-env from fbf268abf6 to 170770e040 2025-01-08 11:37:39 +00:00 Compare
delliott commented 2025-01-08 11:49:28 +00:00
Author
Member
Copy Link

Latest tweak stops copying less to the output, as its now unnecessary. Just a slight efficiency improvement.

Latest tweak stops copying less to the output, as its now unnecessary. Just a slight efficiency improvement.
delliott commented 2025-01-20 10:48:06 +00:00
Author
Member
Copy Link

Will conglomerate these changes in a full python rewrite

Will conglomerate these changes in a full python rewrite
delliott closed this pull request 2025-01-20 10:48:08 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
tobiasd
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bonnie cryptie dario delliott dfajfer dmaphy doczkal eal egnun eventregbot fi fkobi floriansnow gabriel.ku guido hl hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard renovate-bot repentinus schiessle sofiaritz tobiasd vincent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#4660
No description provided.
Delete Branch "(deleted):feat/remove-build-env"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?