FSFE/fsfe-website
25
30
Fork 89
Code Issues 63 Pull Requests 9 Wiki Activity

feat: remove build-env #4660

Open
delliott wants to merge 1 commits from delliott/fsfe-website:feat/remove-build-env into master
pull from: delliott/fsfe-website:feat/remove-build-env
merge into: FSFE:master
Conversation 1 Commits 1 Files Changed 13 +27 -84
delliott commented 2024-12-04 12:16:00 +00:00
Contributor
Copy Link

The only thing specifying a build env introduces at the moment is compiling the less instead of inserting a script for compiling it in browser.

The only real benefit of this is no dependency on lessc for compiling locally.

But it also introduces a divergence between dev env and production env, which is not ideal. It is a nontrivial divergence, as we never really update the less script, while the lessc version on the build server is updated whenever that server is updated. So we can have very divergent versions of lessc in use.

Removing --build-env it simplifies the logic and ensures a more consistent website build.

I have checked the output of building using current master branch with --build-env fsfe.org and on this branch, and there is none. Differences were checked for using diff -r.

This is a nonbreaking pr, as the argument is kept but simply no longer has any effect and will give a deprecation warning.

The only thing specifying a build env introduces at the moment is compiling the less instead of inserting a script for compiling it in browser. The only real benefit of this is no dependency on lessc for compiling locally. But it also introduces a divergence between dev env and production env, which is not ideal. It is a nontrivial divergence, as we never really update the less script, while the lessc version on the build server is updated whenever that server is updated. So we can have very divergent versions of lessc in use. Removing `--build-env` it simplifies the logic and ensures a more consistent website build. I have checked the output of building using current master branch with `--build-env fsfe.org` and on this branch, and there is none. Differences were checked for using `diff -r`. This is a nonbreaking pr, as the argument is kept but simply no longer has any effect and will give a deprecation warning.
delliott changed title from feat: remove build-env to WIP: feat: remove build-env 2024-12-04 12:20:09 +00:00
delliott force-pushed feat/remove-build-env from b22720c680 to e906c7ce95 2024-12-04 13:55:21 +00:00 Compare
delliott changed title from WIP: feat: remove build-env to feat: remove build-env 2024-12-04 13:55:59 +00:00
delliott force-pushed feat/remove-build-env from e906c7ce95 to 4879f24ab2 2024-12-04 13:56:20 +00:00 Compare
delliott requested review from tobiasd 2024-12-04 13:56:37 +00:00
delliott force-pushed feat/remove-build-env from 4879f24ab2 to fbf268abf6 2024-12-18 10:56:02 +00:00 Compare
delliott force-pushed feat/remove-build-env from fbf268abf6 to 170770e040 2025-01-08 11:37:39 +00:00 Compare
delliott commented 2025-01-08 11:49:28 +00:00
Author
Contributor
Copy Link

Latest tweak stops copying less to the output, as its now unnecessary. Just a slight efficiency improvement.

Latest tweak stops copying less to the output, as its now unnecessary. Just a slight efficiency improvement.
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feat/remove-build-env:delliott-feat/remove-build-env
git checkout delliott-feat/remove-build-env
Sign in to join this conversation.
Reviewers
No reviewers
tobiasd
Labels
Clear labels   
bug

   
build

   
cgi Scripting

   
design

   
disruptive

Requires careful coordination and documentation changes

  
documentation

   
duplicate

   
easy

   
feature-request

   
help wanted

   
javascript

   
priority/low

   
question

   
system-hackers

   
tagging

   
text

   
translations

   
wait/bugfix

   
wait/inprogress

   
wait/misc

   
wait/proofread

   
wontfix

   
xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#4660
No description provided.
Delete Branch "delliott/fsfe-website:feat/remove-build-env"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?