remove-css-style #4393

delliott · 2024-08-20T16:14:08Z

delliott commented

2024-08-20 16:14:08 +00:00

Remove css <style>'s from files.

Will try and remove inline css in another pr I think.

Remove css \<style\>'s from files. Will try and remove inline css in another pr I think.

tobiasd approved these changes 2024-08-23 08:43:55 +00:00

Dismissed

tobiasd left a comment

looks good to me

delliott force-pushed remove-css-style from bcd974f63c to 51894c8796

2024-08-23 10:32:56 +00:00

Compare

delliott changed title from ~~WIP: remove-css-style~~ to remove-css-style

2024-08-23 10:33:04 +00:00

delliott commented

2024-08-23 10:43:12 +00:00

So, the goal of this pr was to remove in file <style> classes
At the moment we still have

The following files contain <style> class:
about/statement-20201220.en.xhtml
about/timeline.en.xhtml
about/timeline.it.xhtml
about/timeline.nl.xhtml
freesoftware/standards/eifv2-01.el.xhtml
freesoftware/standards/eifv2-01.en.xhtml
freesoftware/standards/eifv2-01.fr.xhtml
internal/bc.en.xhtml
internal/nt.en.xhtml
internal/pd-result.en.xhtml
internal/pd.en.xhtml
internal/pt.en.xhtml
internal/rc.en.xhtml
13 files contain style class

Remaining.

Not sure what to do about the statement. It seems right to not have a topbanner or share buttons on it, but doing so using <style> does not seem correct.

Timeline files are resolved in #4337

The standards page is linked from nowhere and uses quite a lot of weird css that makes no sense to have global. That file has been replaced by freesoftware/standards/eifv2-01 and should maybe be removed.

And the internal pages also use weird css that should not be global. Also they are not for the public, so consistency is less important. I considered moving all of their css to internal/internal.css, but was not sure that was a good idea. It would break with the standard css patterns we have at the moment.

So, the goal of this pr was to remove in file \<style\> classes At the moment we still have ``` The following files contain <style> class: about/statement-20201220.en.xhtml about/timeline.en.xhtml about/timeline.it.xhtml about/timeline.nl.xhtml freesoftware/standards/eifv2-01.el.xhtml freesoftware/standards/eifv2-01.en.xhtml freesoftware/standards/eifv2-01.fr.xhtml internal/bc.en.xhtml internal/nt.en.xhtml internal/pd-result.en.xhtml internal/pd.en.xhtml internal/pt.en.xhtml internal/rc.en.xhtml 13 files contain style class ``` Remaining. Not sure what to do about the statement. It seems right to not have a topbanner or share buttons on it, but doing so using \<style\> does not seem correct. Timeline files are resolved in https://git.fsfe.org/FSFE/fsfe-website/pulls/4337 The standards page is linked from nowhere and uses quite a lot of weird css that makes no sense to have global. That file has been replaced by freesoftware/standards/eifv2-01 and should maybe be removed. And the internal pages also use weird css that should not be global. Also they are not for the public, so consistency is less important. I considered moving all of their css to internal/internal.css, but was not sure that was a good idea. It would break with the standard css patterns we have at the moment.

delliott commented

2024-08-23 10:46:09 +00:00

I would like to make including <style> in a page a critical ci fail to prevent reintroduction. The only files that I think need to be fixed before this can happen are the internal pages.

I would like to make including \<style\> in a page a critical ci fail to prevent reintroduction. The only files that I think need to be fixed before this can happen are the internal pages.

👍 1

tobiasd commented

2024-08-23 10:52:36 +00:00

I'll have a look into the internal pages.

👍 1

delliott force-pushed remove-css-style from 283eb30f40 to 2bc171d7de

2024-08-23 11:52:34 +00:00

Compare

delliott commented

2024-08-23 11:54:20 +00:00

So,
It was decided to have the css for internal pages in an internal.css file, and to just remove the css form the statement.

This leaves the following files that contain <style> class:

about/timeline.en.xhtml
about/timeline.it.xhtml
about/timeline.nl.xhtml
freesoftware/standards/eifv2-01.el.xhtml
freesoftware/standards/eifv2-01.en.xhtml
freesoftware/standards/eifv2-01.fr.xhtml

As previously mentioned, timeline is resolved in another pr. So what to do about eifv2-1?

So, It was decided to have the css for internal pages in an internal.css file, and to just remove the css form the statement. This leaves the following files that contain \<style\> class: ``` about/timeline.en.xhtml about/timeline.it.xhtml about/timeline.nl.xhtml freesoftware/standards/eifv2-01.el.xhtml freesoftware/standards/eifv2-01.en.xhtml freesoftware/standards/eifv2-01.fr.xhtml ``` As previously mentioned, timeline is resolved in another pr. So what to do about eifv2-1?

delliott requested review from tobiasd 2024-08-23 13:02:29 +00:00

tobiasd approved these changes 2024-08-25 08:23:37 +00:00

delliott merged commit e4baa83a2a into master

2024-08-26 07:33:47 +00:00

delliott referenced this issue from a commit

2024-08-26 07:33:49 +00:00

Merge pull request 'remove-css-style' (#4393) from remove-css-style into master

delliott deleted branch remove-css-style

2024-08-26 07:33:49 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#4393