html-timeline #4337
Reference in New Issue
Block a user
Delete Branch "html-timeline"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This pull request continues on the work completed by @nico.rikken in #1768
055506bd41to0e1d5f92cf0e1d5f92cfto7eaebb08007eaebb0800tofad560b2d9fad560b2d9to476c1a0379Status: Currently functional.
In order to be suitable to merge I need to extract the translations of the old svg version for dutch, and use those for the new html dutch timeline.
Ideally some work would be done to beautify the timeline before merging. This should be quite easy as it has been refactored into xml+xsl.
There appears to be some doubts among the team the about the usefulness of having a timeline, so this is on hold until those discussions are resolved.
Oh, should also do some sedding to redirect links to the new position
476c1a0379toea8a158088ea8a158088to1a47c53a03All translations from the SVG timeline have now been ported across.
Must still be
1a47c53a03to78a40fe4c078a40fe4c0to5cf8a87cd75cf8a87cd7to20c874adb320c874adb3to51c02ae29fStill working on it actually looking nice.
Not sure how to source new info for the timeline?
51c02ae29ftod3ba003d24Now looks not awful, but still not great.
The boxes with title and description are quite large, it might be nice to hide the descriptions unless clicked?
This can be done with <details>, but not sure how it will interact with flexbox alignment.
d3ba003d24toc191f31f2fc191f31f2fto3b273ed0853b273ed085toffd20c895bffd20c895btoa2340eeaa5a2340eeaa5toef2eb53487ef2eb53487tod64b4b2781d64b4b2781to37c1b4d67cUsing details looked real weird, as suspected, so no good.
I am syncing the test branch to this at the moment, so https://test.fsfe.org/about/timeline/ shows what it looks like at least quite recently.
The css is improving, still have not sourced any further content.
37c1b4d67ctoa7ff79193aa7ff79193ato1fa4d684d21fa4d684d2to7b13f7db377b13f7db37to8e85537c352de3d8e420to6ac6bd3d206ac6bd3d20to1b59e86d221b59e86d22to1b61955e421b61955e42to6c2ca9e3576c2ca9e357tob7735ba8a6b7735ba8a6toce0ed5681ace0ed5681atob6b393e21fb6b393e21ftod662c357efd662c357efto403b56a22d403b56a22dto27f62e0dfe27f62e0dfeto219901977aFor clarity here is some feedback from @max.mehl on the mailing list
I have changed the title text, removed the month, removed the borders in favour of low tint backgrounds, fixed the title box height across all boxes.
I have made some changes to colors. I would like to stick to using variables for brand colors instead of defining arbitrary colors, and there aren't that many branch color variables, so I am a little bit limited. I have changed the public color to @brand-warning which is semantically not right but looks better.
The emoji issue is a little odd, and needs further investigation.
All emojis are correct on firefox on debian, but I can confirm that they aren't right on android. I believe we should be using the fonts in this repo
/fontsfor all webpage fonts, so the fonts on device shouldn't matter. I suspect then the the emojis we are using actually don't have a monochrome variant defined our webpage fonts, and it just happens that the next default font on debian has them defined? But android should fallback to noto and it has enormous emoji support. Anyway, I will investigate further.Yep, just investigated and we are falling back to browser fonts for emoji most of the time. We dont seem to have defined a list of fallback fonts in the css, just one per type. So the solution to the emoji is probably to do some work on the font css for the whole site. I think its probably best to do that in a separate PR.
556e374c91tobcf5a61641Fixed fonts in #4396
bcf5a61641to23f14ddb1723f14ddb17toa42b73419aa42b73419atob5216417d7b5216417d7tof9235f4a0cSo, status report on this PR:
The technical details of moving from svg to html+css are complete. This pr can be seen rendered at https://test.fsfe.org/about/timeline/.
I am sure that some further work could be done on the Styling, but I am satisfied with its appearance, and all major concerns raised at time of writing have been addressed.
The only thing left to do therefore is update it with new content.
The FSFE Italy group has compiled a list of notable events that can be included here: https://share.fsfe.org/s/agXLXiweecHK9wc
f9235f4a0ctof1b31d928ef1b31d928eto80bb24e9e7So after some discussion with @mk it was decided that this pr will just be for the technical overhaul, and the new content will come in a later PR.
At least that was my understanding of the resolution.
80bb24e9e7tob69c8f4f5bb69c8f4f5bto8916908954I have put this on test again, see it here: https://test.fsfe.org/about/timeline/index.en.html
I have a recollection of there being something blocking this being merged, but frankly have forgotten what.
Are we able to move forward?
8916908954to2e3100eafc2e3100eafcto46955db2ac46955db2actodb5bd1d51b@tobiasd I thought about this work today. Is it good to merge, so we can close this chapter and overhaul the content from here, in time for our upcoming 25 year celebration?
db5bd1d51bto5d3153f5395d3153f539to939cd5159d939cd5159dto580e0f081dSo, we think this is good to merge? And update the content later? @tobiasd
CI is failing
So, I had a look at the contrast of the text and the background colors after tweaking them there, changes not deployed on test as its in use for other stuff.
Using https://webaim.org/resources/contrastchecker/ I seem to get that all text has at least 8.5 contrast. which exceeds pretty much all accessibility requirements?
I will not pretend to be a frontend dev, but it seems fine to me, probably?
d96fa9373dto788bb2d0c92628eb1a89toe1244323ffe1244323ffto38b6517b14Is there a draft for content on the new timeline? It looks the same (content-wise) as ever! (I helped design it in commit #740 during my internship). I would happily make it my homework to research timeline events since 2017 @mk. Am going through everything a bit, anyway!
Agreed @delliott it now looks very passable and imo nice / easier to read / less scrunched!
Hey!
I am afraid there is no new content in this PR.
The goal of this PR was just to get the timeline refactored and functional, and then update content in a later one.
Unfortunately it got a little bogged down in some stuff, but now its moving on.
There is currently some discussion on what the categories should be, but once that is resolved it should be possible to move ahead with getting this in place in time to start adding content.
It is of course possible to start finding events to put in the timeline now, but it would be very conflict inducing to try and update the XML's of data before we iron out categories.
@georgebs at the moment this PR is only the rework of the old non-responsive timeline. @anaghz will work on the content for the timeline - if you want to contribute, best contact her.
9d3447cc88toeb2e21370deb2e21370dtod84d9f2ad4d84481b858toff70494bc8ff70494bc8to222e9c7338e4a44db8e1toe679e04f22e679e04f22to5b400737255b40073725toca77b2ddf9ca77b2ddf9to4b9691aca74b9691aca7to333840ce23333840ce23tob9566a6a41b9566a6a41to4b020fd7354b020fd735toc1ee364e9fc1ee364e9ftoed56c415da@@ -0,0 +33,4 @@<xsl:when test="@type = 'policy-advocacy'">🏛︎</xsl:when><xsl:when test="@type = 'legal-support'">⚖︎</xsl:when><xsl:when test="@type = 'public-awareness'">📣︎</xsl:when><xsl:otherwise>???</xsl:otherwise>Means we need to find a nice confused emoticon for the otherwise case?
@delliott thank you so much!!! I checked how it looks now and I'm very impressed how well it looks, how it is mobile-friendly and how it can be kept up to date and be translated. Thank you so much!!