#400 Updates to jquery 3 and tidies up the console output

Merged
max.mehl merged 1 commits from mweimann/fsfe-website:FSFE/fsfe-website#396 into test 2 years ago
mweimann commented 2 years ago
Collaborator

There are some console warnings, errors and debug messages on the current page (see screenshot). This PR

  • Adds data-cycle-log="false" that silences the front page carousel output
  • Removes hljs stuff from fsfe_head.xsl since the highlight js isn't loaded there (leads to an error)
  • Removes the link to the missing source maps of the jquery.cycle2.min.js script

And finally I upgraded to jquery 3:

  • I removed the previous jquery versions
  • Tested the supporter and event form - still working
  • Added jquery 3 min version and the source maps

This PR goes into test to see if everything is still working.

There are some console warnings, errors and debug messages on the current page (see screenshot). This PR * Adds `data-cycle-log="false"` that silences the front page carousel output * Removes `hljs` stuff from `fsfe_head.xsl` since the highlight js isn't loaded there (leads to an error) * Removes the link to the missing source maps of the `jquery.cycle2.min.js` script And finally I upgraded to jquery 3: * I removed the previous jquery versions * Tested the supporter and event form - still working * Added jquery 3 min version and the source maps This PR goes into test to see if everything is still working.
max.mehl was assigned by mweimann 2 years ago
max.mehl closed this pull request 2 years ago
max.mehl commented 2 years ago
Poster
Owner

Looks good at first sight, wouldn't you say?

Looks good at first sight, wouldn't you say?
mweimann commented 2 years ago
Poster
Collaborator

Jep - see #398 .
Just want do double check when it's live..

Jep - see #398 . Just want do double check when it's live..
The pull request has been merged as 8e1feed765.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.