#40 Update FreeYourAndroid pages

Merged
max.mehl merged 38 commits from :update/freeyourandroid into master 3 years ago
max.mehl commented 3 years ago
Owner

Our FYA pages are utterly out of date. During the Community Meeting 2017 we identified many outdated and wrong facts and easy steps how to improve the layout and user friendlyness.

This PR is work in progress.

Our [FYA](freeyourandroid.org) pages are utterly out of date. During the Community Meeting 2017 we identified many outdated and wrong facts and easy steps how to improve the layout and user friendlyness. This PR is work in progress.
Poster

@max.mehl For some reason I can't create a merge request against your branch in your repository. So consider this a pull request:

https://git.fsfe.org/carmenbianca/fsfe-website/src/branch/update/freeyourandroid

Contains a lot of commits with tiny fixes. Revert the ones that you don't like. I'd say it's easiest do this:

git remote add carmenbianca git@git.fsfe.org:carmenbianca/fsfe-website.git
git fetch carmenbianca
git checkout -b carmenbianca-fya-pr carmenbianca/update/freeyourandroid

And then using something like gitk, magit (worth using Emacs just for magit, honestly) or git-cola to review each individual commit. That should be much faster than checking via the website.

Looks good!

@max.mehl For some reason I can't create a merge request against your branch in your repository. So consider this a pull request: https://git.fsfe.org/carmenbianca/fsfe-website/src/branch/update/freeyourandroid Contains a lot of commits with tiny fixes. Revert the ones that you don't like. I'd say it's easiest do this: ``` git remote add carmenbianca git@git.fsfe.org:carmenbianca/fsfe-website.git git fetch carmenbianca git checkout -b carmenbianca-fya-pr carmenbianca/update/freeyourandroid ``` And then using something like `gitk`, `magit` (worth using Emacs just for magit, honestly) or `git-cola` to review each individual commit. That should be much faster than checking via the website. Looks good!
max.mehl self-assigned this 3 years ago
max.mehl commented 3 years ago
Poster
Owner

Thanks a bunch, very helpful! I cherry-picked most of your suggestions and will send the result to android@

Thanks a bunch, very helpful! I cherry-picked most of your suggestions and will send the result to android@
Poster

Thanks.

Can you give me a reason why the following commits aren't cherry-picked?

a5195cbeff - Current language is far too weak. Really needs to be changed.

c5bae8f17d - Sentences don't flow well currently. Simple past especially doesn't work.

463bea031b - I believe 'mailing list' is the canonical spelling? I could be wrong though.

004fc8da7a - This rephrasing is really needed.

f002b78de0 - "Made good experiences with" is not valid English.

If some of them are a case of simply forgetting to cherry-pick: In the future, merge, then revert :)

Thanks. Can you give me a reason why the following commits aren't cherry-picked? https://git.fsfe.org/carmenbianca/fsfe-website/commit/a5195cbeff420a1b1f5a66798efa4662070cb536 - Current language is far too weak. Really needs to be changed. https://git.fsfe.org/carmenbianca/fsfe-website/commit/c5bae8f17d75438e9d2381b04e6d895318c76b39 - Sentences don't flow well currently. Simple past especially doesn't work. https://git.fsfe.org/carmenbianca/fsfe-website/commit/463bea031b64a2ec4b4a42d4f1802e1959368244 - I believe 'mailing list' is the canonical spelling? I could be wrong though. https://git.fsfe.org/carmenbianca/fsfe-website/commit/004fc8da7a8d1741137d6d6c8399c00df05a1656 - This rephrasing is really needed. https://git.fsfe.org/carmenbianca/fsfe-website/commit/f002b78de049f9aeca3c5e440b9e97366c4c266d - "Made good experiences with" is not valid English. If some of them are a case of simply forgetting to cherry-pick: In the future, merge, then revert :)
max.mehl commented 3 years ago
Poster
Owner
  1. Do you know the full interest of the user? If it was about freedom, I'd agree, but assuming the interest of all users is not our task
  2. Missed that, will pick later
  3. Missed that, too
  4. That too (wtf?)
  5. I don't want to use "recommendation" as it is a term that we usually want to avoid in this campaign. Can you think of a way to fix my original intention?
1. Do you know the full interest of the user? If it was about freedom, I'd agree, but assuming the interest of all users is not our task 2. Missed that, will pick later 3. Missed that, too 4. That too (wtf?) 5. I don't want to use "recommendation" as it is a term that we usually want to avoid in this campaign. Can you think of a way to fix my original intention?
Poster

In re (1): We are the Free Software Foundation Europe :) It is our stance that anything that doesn't respect the user's freedoms works against the users. "[...] that usually do not work in the full interest of the user" is very, very weak language coming from us.

At the very least, it could be rephrased to "that often work against the full interest of the user", which is basically my suggestion, with "often" added.

In re (5): I can see where you're coming from. In that case, avoid mentioning "we" at all. So:

"However, this sections aims to present a small selection of apps which are fitting for starters."

Maybe also remove "however". It fits very strangely.

In re (1): We are the Free Software Foundation Europe :) It is our stance that anything that doesn't respect the user's freedoms works against the users. "[...] that usually do not work in the full interest of the user" is very, very weak language coming from us. At the very least, it could be rephrased to "that *often* work against the full interest of the user", which is basically my suggestion, with "often" added. In re (5): I can see where you're coming from. In that case, avoid mentioning "we" at all. So: "However, this sections aims to present a small selection of apps which are fitting for starters." Maybe also remove "however". It fits very strangely.
Poster

Thanks for updating these pages. This was long overdue! :)

Unfortunately, I can't comment on the changes directly, so I'll do it here:

Thanks for updating these pages. This was long overdue! :) Unfortunately, I can't comment on the changes directly, so I'll do it here: * there's an outdated link to https://market.android.com/ * typo: `detailled`
max.mehl commented 3 years ago
Poster
Owner

Included all open suggestions here, thanks!

Included all open suggestions here, thanks!
max.mehl closed this pull request 3 years ago
max.mehl deleted branch update/freeyourandroid 3 years ago
The pull request has been merged as b12aea102d.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.