Upgrades jquery to version 3 and silences console outputs #398

mweimann · 2018-07-11T19:48:27Z

mweimann commented

2018-07-11 19:48:27 +00:00

As far as I tested #400 (merge to test) looked successful.

@max.mehl could we coordinate the release of this PR?
I want to do some checks after release, since it's more than just tiny text changes.

There are some console warnings, errors and debug messages on the current page (see screenshot). This PR

Adds data-cycle-log="false" that silences the front page carousel output
Removes hljs stuff from fsfe_head.xsl since the highlight js isn't loaded there (leads to an error)
Removes the link to the missing source maps of the jquery.cycle2.min.js script

And finally I upgraded to jquery 3:

I removed the previous jquery versions
Tested the supporter and event form - still working
Added jquery 3 min version and the source maps

(!) we should test the important forms after release

closes FSFE/fsfe-website#396

As far as I tested #400 (merge to test) looked successful. @max.mehl could we coordinate the release of this PR? I want to do some checks after release, since it's more than just tiny text changes. --------------- There are some console warnings, errors and debug messages on the current page (see screenshot). This PR * Adds `data-cycle-log="false"` that silences the front page carousel output * Removes `hljs` stuff from `fsfe_head.xsl` since the highlight js isn't loaded there (leads to an error) * Removes the link to the missing source maps of the `jquery.cycle2.min.js` script And finally I upgraded to jquery 3: * I removed the previous jquery versions * Tested the supporter and event form - still working * Added jquery 3 min version and the source maps (!) we should test the important forms after release closes FSFE/fsfe-website#396

Screenshot from 2018-07-11 21-18-51.png

41 KiB

mweimann closed this pull request

2018-07-12 08:31:46 +00:00

mweimann reopened this pull request

2018-07-12 08:31:49 +00:00

mweimann changed title from ~~Upgrades jquery to version 3 and silences console outputs~~ to WIP: Upgrades jquery to version 3 and silences console outputs

2018-07-12 08:32:01 +00:00

mweimann commented

2018-07-12 14:59:35 +00:00

We do a merge into test first.

mweimann closed this pull request

2018-07-12 14:59:35 +00:00

mweimann reopened this pull request

2018-07-14 13:04:45 +00:00

mweimann changed title from ~~WIP: Upgrades jquery to version 3 and silences console outputs~~ to Upgrades jquery to version 3 and silences console outputs

2018-07-14 13:05:03 +00:00

max.mehl was assigned by mweimann

2018-07-14 13:12:45 +00:00

max.mehl commented

2018-07-16 15:55:27 +00:00

Great, thanks for testing this first. Will merge!

max.mehl closed this pull request

2018-07-16 15:55:52 +00:00

max.mehl referenced this issue from a commit

2018-08-29 16:01:24 +00:00

Upgrades jquery to version 3 and silences console outputs (#398)

Sign in to join this conversation.