#398 Upgrades jquery to version 3 and silences console outputs

Merged
max.mehl merged 1 commits from mweimann/fsfe-website:FSFE/fsfe-website#396 into master 2 years ago
mweimann commented 2 years ago
Collaborator

As far as I tested #400 (merge to test) looked successful.

@max.mehl could we coordinate the release of this PR?
I want to do some checks after release, since it's more than just tiny text changes.


There are some console warnings, errors and debug messages on the current page (see screenshot). This PR

  • Adds data-cycle-log="false" that silences the front page carousel output
  • Removes hljs stuff from fsfe_head.xsl since the highlight js isn't loaded there (leads to an error)
  • Removes the link to the missing source maps of the jquery.cycle2.min.js script

And finally I upgraded to jquery 3:

  • I removed the previous jquery versions
  • Tested the supporter and event form - still working
  • Added jquery 3 min version and the source maps

(!) we should test the important forms after release

closes FSFE/fsfe-website#396

As far as I tested #400 (merge to test) looked successful. @max.mehl could we coordinate the release of this PR? I want to do some checks after release, since it's more than just tiny text changes. --------------- There are some console warnings, errors and debug messages on the current page (see screenshot). This PR * Adds `data-cycle-log="false"` that silences the front page carousel output * Removes `hljs` stuff from `fsfe_head.xsl` since the highlight js isn't loaded there (leads to an error) * Removes the link to the missing source maps of the `jquery.cycle2.min.js` script And finally I upgraded to jquery 3: * I removed the previous jquery versions * Tested the supporter and event form - still working * Added jquery 3 min version and the source maps (!) we should test the important forms after release closes FSFE/fsfe-website#396
mweimann closed this pull request 2 years ago
mweimann reopened this pull request 2 years ago
mweimann changed title from Upgrades jquery to version 3 and silences console outputs to WIP: Upgrades jquery to version 3 and silences console outputs 2 years ago
mweimann commented 2 years ago
Poster
Collaborator

We do a merge into test first.

We do a merge into test first.
mweimann closed this pull request 2 years ago
mweimann reopened this pull request 2 years ago
mweimann changed title from WIP: Upgrades jquery to version 3 and silences console outputs to Upgrades jquery to version 3 and silences console outputs 2 years ago
max.mehl was assigned by mweimann 2 years ago
max.mehl commented 2 years ago
Poster
Owner

Great, thanks for testing this first. Will merge!

Great, thanks for testing this first. Will merge!
max.mehl closed this pull request 2 years ago
The pull request has been merged as 6da0681c2d.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.