Labels Milestones

task/change-donationelement-color #2969

Merged

tobiasd merged 6 commits from task/change-donationelement-color into master 6 months ago

Conversation 3 Commits 6 Files Changed 4

tobiasd commented 6 months ago

Collaborator

This PR makes it possible to change the color of the donation elements on the homepage. To do so, change the brand-donation value in the look/bootstrap/variables.less file.

This PR makes it possible to change the color of the *donation elements* on the homepage. To do so, change the `brand-donation` value in the `look/bootstrap/variables.less` file.

Donation-Elements-in-Orange.jpg

224 KiB

tobiasd added 2 commits 6 months ago

262ed08760 add brand-donation and brand-donation-border to the color definition in variable.less

c3130dddd3 use the brand-donation color for the donation elements as background and border color

linus commented 6 months ago

Owner

Looks very good to me. Thanks for implementing this so quickly and effectively. 👍

Looks very good to me. Thanks for implementing this so quickly and effectively. 👍

linus requested review from mk 6 months ago

tobiasd added 1 commit 6 months ago

3311c0b0ef darken the button color slightly on mouse over

tobiasd added 2 commits 6 months ago

b1d044752a make the campaign banner react on mouse over as well

fc6d8e23d9 go with green for the PR

tobiasd added 1 commit 6 months ago

3cd692ae89 use the correct green

mk commented 6 months ago

Owner

Thanks @tobiasd . Looks good to me. Can be applied without changing the current colour (sticking to green at the moment).

To make sure, if I want to change I just have to change what is commented out and what not, and after the next rebuild it is implemented? Or would I have to run some command for bootstrap as well?

Thanks @tobiasd . Looks good to me. Can be applied without changing the current colour (sticking to green at the moment). To make sure, if I want to change I just have to change what is commented out and what not, and after the next rebuild it is implemented? Or would I have to run some command for bootstrap as well?

tobiasd commented 6 months ago

Poster

Collaborator

Yes, the CSS will be generated during the build of the webpage.

Yes, the CSS will be generated during the build of the webpage.

tobiasd changed title from [WIP] task/change-donationelement-color to task/change-donationelement-color 6 months ago

tobiasd merged commit 9164e051b0 into master 6 months ago

tobiasd referenced this issue from a commit 6 months ago

Merge pull request 'task/change-donationelement-color' (#2969) from task/change-donationelement-color into master

tobiasd deleted branch task/change-donationelement-color 6 months ago

Reviewers

mk was requested for review 6 months ago

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as 9164e051b0.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

mk

Labels

Apply labels

Clear labels   

bug

  

build

  

cgi Scripting

  

design

  

disruptive

Requires careful coordination and documentation changes   

documentation

  

duplicate

  

easy

  

feature-request

  

help wanted

  

javascript

  

priority/low

  

question

  

system-hackers

  

tagging

  

text

  

translations

  

wait/bugfix

  

wait/inprogress

  

wait/misc

  

wait/proofread

  

wontfix

  

xsl

No Label

bug

build

cgi Scripting

design

disruptive

documentation

duplicate

easy

feature-request

help wanted

javascript

priority/low

question

system-hackers

tagging

text

translations

wait/bugfix

wait/inprogress

wait/misc

wait/proofread

wontfix

xsl

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#2969

Write Preview

Loading…

Cancel

Save

There is no content yet.