WIP: Remove absolute links to fsfe.org #2812

Draft
fbn_bmns wants to merge 1 commits from fbn_bmns/fsfe-website:remove_absolute_links into master
Contributor

This is a rather big pull request, I'm sorry.

I used the following command to remove all absolute links to fsfe.org. (starting from the root of the repository)

grep -rl "<a href=\"https://fsfe.org/" . | xargs sed -i -e 's|<a href="https://fsfe.org/|<a href="/|g'

Please check and give feedback, thank you :)

This is a rather big pull request, I'm sorry. I used the following command to remove all absolute links to fsfe.org. (starting from the root of the repository) ``` grep -rl "<a href=\"https://fsfe.org/" . | xargs sed -i -e 's|<a href="https://fsfe.org/|<a href="/|g' ``` Please check and give feedback, thank you :)
fbn_bmns force-pushed remove_absolute_links from c16f1ed3d9 to f9043c2967 2022-10-07 18:57:30 +00:00 Compare
fbn_bmns force-pushed remove_absolute_links from f9043c2967 to e4de70e9ee 2022-10-07 19:00:17 +00:00 Compare
bonnie requested review from linus 2022-10-12 08:41:37 +00:00
bonnie requested changes 2022-10-12 08:47:39 +00:00
bonnie left a comment
Member

Hej, just some small mistakes with the link for the front page

Hej, just some small mistakes with the link for the front page
@ -34,3 +34,3 @@
-->
<p><a href="https://fsfe.org/">Free Software Foundation Europe</a>
<p><a href="/">Free Software Foundation Europe</a>
Member

This should look different and should be changed to: /index.html

This should look different and should be changed to: /index.html
bonnie marked this conversation as resolved
@ -35,3 +35,3 @@
-->
<p><a href="https://fsfe.org/">Free Software Foundation
<p><a href="/">Free Software Foundation
Member

should also be changed to: /index.html

should also be changed to: /index.html
bonnie marked this conversation as resolved
Member

@fbn_bmns: Thank you very much for this PR!

@fbn_bmns: Thank you very much for this PR!
fbn_bmns force-pushed remove_absolute_links from e4de70e9ee to a866f9bada 2022-10-14 16:13:16 +00:00 Compare
fbn_bmns force-pushed remove_absolute_links from a866f9bada to 3c780bd741 2022-10-14 16:18:10 +00:00 Compare
fbn_bmns force-pushed remove_absolute_links from 3c780bd741 to 596d17fbfa 2022-10-14 18:04:18 +00:00 Compare
Author
Contributor

Now I'm getting some critical warnings regarding some filenames:

The following 17 file(s) in your commit do not follow the naming

scheme for news and events:

  • news/2001/article-24.9.2001.de.xhtml
  • news/2002/article-30.9.2002.de.xhtml
  • news/2002/article2002-01-18-01.en.xhtml
  • news/2004/cw-interview.de.xhtml
  • news/2005/letter-20050511-it-mep.it.xhtml
  • news/2008/freedom-not-fear.nl.xhtml
  • news/2008/gnu-25-years.fr.xhtml
  • news/2008/gnu-25-years.it.xhtml
  • news/2008/gnu-25-years.nl.xhtml
  • news/2009/ga2009.el.xhtml
  • news/2009/ga2009.en.xhtml
  • news/2009/ga2009.es.xhtml
  • news/2009/ga2009.fr.xhtml
  • news/2009/ga2009.nl.xhtml
  • news/2009/nyr.de.xhtml
  • news/2009/nyr.it.xhtml
  • news/2010/th-eulogy-20100508.de.xhtml

As most of the filenames are not compatible with the new scheme, how should I rename them? Is there some explanation somewhere? :/

Now I'm getting some critical warnings regarding some filenames: The following 17 file(s) in your commit do not follow the naming scheme for news and events: - news/2001/article-24.9.2001.de.xhtml - news/2002/article-30.9.2002.de.xhtml - news/2002/article2002-01-18-01.en.xhtml - news/2004/cw-interview.de.xhtml - news/2005/letter-20050511-it-mep.it.xhtml - news/2008/freedom-not-fear.nl.xhtml - news/2008/gnu-25-years.fr.xhtml - news/2008/gnu-25-years.it.xhtml - news/2008/gnu-25-years.nl.xhtml - news/2009/ga2009.el.xhtml - news/2009/ga2009.en.xhtml - news/2009/ga2009.es.xhtml - news/2009/ga2009.fr.xhtml - news/2009/ga2009.nl.xhtml - news/2009/nyr.de.xhtml - news/2009/nyr.it.xhtml - news/2010/th-eulogy-20100508.de.xhtml As most of the filenames are not compatible with the new scheme, how should I rename them? Is there some explanation somewhere? :/
Member

Good morning @fbn_bmns

I am unsure about the renaming. Could you ask on the web mailing list what they think might be the best option?

Thank you very much for your help.

Good morning @fbn_bmns I am unsure about the renaming. Could you ask on the web mailing list what they think might be the best option? Thank you very much for your help.
Member

Hej @fbn_bmns, I am very sorry that it takes so long to merge this PR. As we currently have no reasonable solution how about we separate the PRs? We could delete those old articles from this PR and create a new one for them? I know this is not the best solution but changing the names of those old articles might also break some links.

Let me know what you think.
Best
Bonnie

Hej @fbn_bmns, I am very sorry that it takes so long to merge this PR. As we currently have no reasonable solution how about we separate the PRs? We could delete those old articles from this PR and create a new one for them? I know this is not the best solution but changing the names of those old articles might also break some links. Let me know what you think. Best Bonnie
Member

Hej @fbn_bmns,

I have now commited the files with the correct naming scheme and excluded the old ones in PR #2858

Thank you very much for your help in removing and replacing the absolute links. I would say we leave this PR open till we find a solution for the older files.

Best,
Bonnie

Hej @fbn_bmns, I have now commited the files with the correct naming scheme and excluded the old ones in PR #2858 Thank you very much for your help in removing and replacing the absolute links. I would say we leave this PR open till we find a solution for the older files. Best, Bonnie
bonnie changed title from Remove absolute links to fsfe.org to WIP: Remove absolute links to fsfe.org 2022-11-02 09:25:35 +00:00
Member

@tobiasd, maybe you have an idea about the old file names? As they do not fit our current naming-scheme we can't update those files.

@tobiasd, maybe you have an idea about the old file names? As they do not fit our current naming-scheme we can't update those files.
Owner

I think it would be best if the files are excluded from the PR.

However I noticed other problems with the global removal of https://fsfe.org from all the links in the repository, as it does not only contain the main website, but also others like https://pdfreader.org or https://drm.info. When the explicit links are removed, those pages don't work correctly anymore. So the changes to the drm.info directory and the pdfreader.org directory have to be reverted. I think for the other domains there is only a rewrite to the full URL at fsfe.org.

I think it would be best if the files are excluded from the PR. However I noticed other problems with the global removal of `https://fsfe.org` from all the links in the repository, as it does not only contain the main website, but also others like `https://pdfreader.org` or `https://drm.info`. When the explicit links are removed, those pages don't work correctly anymore. So the changes to the `drm.info` directory and the `pdfreader.org` directory have to be reverted. I think for the other domains there is only a rewrite to the full URL at fsfe.org.
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
This pull request has changes conflicting with the target branch.
  • news/2009/ga2009.el.xhtml
  • news/2009/ga2009.en.xhtml
  • news/2009/ga2009.es.xhtml
  • news/2009/ga2009.fr.xhtml
  • news/2009/ga2009.nl.xhtml
  • news/nl/nl-201110.es.xhtml
  • news/nl/nl-201110.fr.xhtml
  • news/nl/nl-201112.en.xhtml
  • news/nl/nl-201201.en.xhtml
  • news/nl/nl-201201.es.xhtml
Sign in to join this conversation.
No description provided.