FSFE
/
fsfe-website
28
26
Fork 74
Code Issues 64 Pull Requests 10 Releases Wiki Activity
Labels Milestones

WIP: Remove absolute links to fsfe.org #2812

Draft
fbn_bmns wants to merge 1 commits from fbn_bmns/fsfe-website:remove_absolute_links into master
Conversation 5 Commits 1 Files Changed 597
fbn_bmns commented 4 months ago

This is a rather big pull request, I'm sorry.

I used the following command to remove all absolute links to fsfe.org. (starting from the root of the repository)

grep -rl "<a href=\"https://fsfe.org/" . | xargs sed -i -e 's|<a href="https://fsfe.org/|<a href="/|g'

Please check and give feedback, thank you :)

This is a rather big pull request, I'm sorry. I used the following command to remove all absolute links to fsfe.org. (starting from the root of the repository) ``` grep -rl "<a href=\"https://fsfe.org/" . | xargs sed -i -e 's|<a href="https://fsfe.org/|<a href="/|g' ``` Please check and give feedback, thank you :)
fbn_bmns force-pushed remove_absolute_links from c16f1ed3d9 to f9043c2967 4 months ago
fbn_bmns force-pushed remove_absolute_links from f9043c2967 to e4de70e9ee 4 months ago
bonnie requested review from linus 4 months ago
bonnie requested changes 4 months ago
bonnie left a comment
Collaborator

Hej, just some small mistakes with the link for the front page

Hej, just some small mistakes with the link for the front page
pdfreaders/about.nb.xhtml Outdated
-->
<p><a href="https://fsfe.org/">Free Software Foundation Europe</a>
<p><a href="/">Free Software Foundation Europe</a>
bonnie commented 4 months ago
Collaborator

This should look different and should be changed to: /index.html

This should look different and should be changed to: /index.html
bonnie marked this conversation as resolved
pdfreaders/about.nn.xhtml Outdated
-->
<p><a href="https://fsfe.org/">Free Software Foundation
<p><a href="/">Free Software Foundation
bonnie commented 4 months ago
Collaborator

should also be changed to: /index.html

should also be changed to: /index.html
bonnie marked this conversation as resolved
bonnie commented 4 months ago
Collaborator

@fbn_bmns: Thank you very much for this PR!

@fbn_bmns: Thank you very much for this PR!
fbn_bmns force-pushed remove_absolute_links from e4de70e9ee to a866f9bada 4 months ago
fbn_bmns force-pushed remove_absolute_links from a866f9bada to 3c780bd741 4 months ago
fbn_bmns force-pushed remove_absolute_links from 3c780bd741 to 596d17fbfa 4 months ago
fbn_bmns commented 4 months ago
Poster

Now I'm getting some critical warnings regarding some filenames:

The following 17 file(s) in your commit do not follow the naming

scheme for news and events:

  • news/2001/article-24.9.2001.de.xhtml
  • news/2002/article-30.9.2002.de.xhtml
  • news/2002/article2002-01-18-01.en.xhtml
  • news/2004/cw-interview.de.xhtml
  • news/2005/letter-20050511-it-mep.it.xhtml
  • news/2008/freedom-not-fear.nl.xhtml
  • news/2008/gnu-25-years.fr.xhtml
  • news/2008/gnu-25-years.it.xhtml
  • news/2008/gnu-25-years.nl.xhtml
  • news/2009/ga2009.el.xhtml
  • news/2009/ga2009.en.xhtml
  • news/2009/ga2009.es.xhtml
  • news/2009/ga2009.fr.xhtml
  • news/2009/ga2009.nl.xhtml
  • news/2009/nyr.de.xhtml
  • news/2009/nyr.it.xhtml
  • news/2010/th-eulogy-20100508.de.xhtml

As most of the filenames are not compatible with the new scheme, how should I rename them? Is there some explanation somewhere? :/

Now I'm getting some critical warnings regarding some filenames: The following 17 file(s) in your commit do not follow the naming scheme for news and events: - news/2001/article-24.9.2001.de.xhtml - news/2002/article-30.9.2002.de.xhtml - news/2002/article2002-01-18-01.en.xhtml - news/2004/cw-interview.de.xhtml - news/2005/letter-20050511-it-mep.it.xhtml - news/2008/freedom-not-fear.nl.xhtml - news/2008/gnu-25-years.fr.xhtml - news/2008/gnu-25-years.it.xhtml - news/2008/gnu-25-years.nl.xhtml - news/2009/ga2009.el.xhtml - news/2009/ga2009.en.xhtml - news/2009/ga2009.es.xhtml - news/2009/ga2009.fr.xhtml - news/2009/ga2009.nl.xhtml - news/2009/nyr.de.xhtml - news/2009/nyr.it.xhtml - news/2010/th-eulogy-20100508.de.xhtml As most of the filenames are not compatible with the new scheme, how should I rename them? Is there some explanation somewhere? :/
bonnie commented 4 months ago
Collaborator

Good morning @fbn_bmns

I am unsure about the renaming. Could you ask on the web mailing list what they think might be the best option?

Thank you very much for your help.

Good morning @fbn_bmns I am unsure about the renaming. Could you ask on the web mailing list what they think might be the best option? Thank you very much for your help.
bonnie commented 4 months ago
Collaborator

Hej @fbn_bmns, I am very sorry that it takes so long to merge this PR. As we currently have no reasonable solution how about we separate the PRs? We could delete those old articles from this PR and create a new one for them? I know this is not the best solution but changing the names of those old articles might also break some links.

Let me know what you think.
Best
Bonnie

Hej @fbn_bmns, I am very sorry that it takes so long to merge this PR. As we currently have no reasonable solution how about we separate the PRs? We could delete those old articles from this PR and create a new one for them? I know this is not the best solution but changing the names of those old articles might also break some links. Let me know what you think. Best Bonnie
bonnie commented 3 months ago
Collaborator

Hej @fbn_bmns,

I have now commited the files with the correct naming scheme and excluded the old ones in PR #2858

Thank you very much for your help in removing and replacing the absolute links. I would say we leave this PR open till we find a solution for the older files.

Best,
Bonnie

Hej @fbn_bmns, I have now commited the files with the correct naming scheme and excluded the old ones in PR #2858 Thank you very much for your help in removing and replacing the absolute links. I would say we leave this PR open till we find a solution for the older files. Best, Bonnie
bonnie changed title from Remove absolute links to fsfe.org to WIP: Remove absolute links to fsfe.org 3 months ago

Reviewers

linus was requested for review 4 months ago
bonnie requested changes 4 months ago
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
This pull request has changes conflicting with the target branch.
about/principles.fr.xhtml
about/principles.nl.xhtml
activities/agnula/agnula.en.xhtml
about/principles.ru.xhtml
activities/agnula/agnula.ca.xhtml
activities/agnula/agnula.de.xhtml
activities/agnula/agnula.it.xhtml
about/principles.de.xhtml
about/principles.en.xhtml
about/principles.pt.xhtml
Sign in to join this conversation.
Reviewers
Request review
No reviewers
linus
bonnie
Labels
Apply labels
Clear labels
bug build cgi Scripting design disruptive
Requires careful coordination and documentation changes documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
No Label bug build cgi Scripting design disruptive documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#2812
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fbn_bmns/fsfe-website:remove_absolute_links'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes