Add bidirectional text support #2755

2022-08-25T11:59:00Z

mskf1383 commented

2022-08-25 11:59:00 +00:00

Some languages like Persian and Arabic are right-to-left. This is the current behavior of https://drm.info (Its wrong):

With this chages, it become this (Its true):

This changes does not affect LTR texts (I didn't find any difference. The direction of body only reversed when text (or more accurate, the H1 content) is RTL).

Please merge this.
Thanks!

Some languages like Persian and Arabic are right-to-left. This is the current behavior of https://drm.info (Its wrong): ![drm.info showing a RTL text](https://git.fsfe.org/attachments/fb9d9ea8-6144-4135-ac5a-ae238b981381) With this chages, it become this (Its true): ![drm.info shing a RTL text after changes](https://git.fsfe.org/attachments/cc108022-08a3-42cb-84c4-428350529e4f) This changes does not affect LTR texts (I didn't find any difference. The direction of body only reversed when text *(or more accurate, the H1 content)* is RTL). Please merge this. Thanks!

نماگرفت از 2022-08-25 16-19-13.png

389 KiB

نماگرفت از 2022-08-25 16-19-33.png

390 KiB

max.mehl commented

2022-08-25 14:10:20 +00:00

Thank you. Just to confirm: is this only wrong on drm.info or also on fsfe.org or pdfreaders.org?

mskf1383 commented

2022-08-26 06:19:10 +00:00

Thank you. Just to confirm: is this only wrong on drm.info or also on fsfe.org or pdfreaders.org?

I checked pdfreaders.org with its Arabic translation. Its become completely RTL (a dir="rtl" added to <html> automaticly), and don't have any problem. (I hope this do not happen for drm.info. Because its header is not localisable, and its always LTR. Just the <div id="body"> should become RTL).
fsfe.org has problem.

> Thank you. Just to confirm: is this only wrong on drm.info or also on fsfe.org or pdfreaders.org? I checked pdfreaders.org with its Arabic translation. Its become completely RTL (a `dir="rtl"` added to `<html>` automaticly), and don't have any problem. (I hope this do not happen for drm.info. Because its header is not localisable, and its always LTR. Just the `<div id="body">` should become RTL). fsfe.org has problem.

max.mehl added the bug design labels 2022-08-26 10:29:11 +00:00

mskf1383 force-pushed master from 305525d1ba to f67fefe238

2022-09-03 12:09:43 +00:00

Compare

mskf1383 force-pushed master from f67fefe238 to ce80a8bb92

2022-09-03 12:32:24 +00:00

Compare

lucas.lasota manually merged commit 858debd660 into master

2022-09-03 12:32:24 +00:00

mskf1383 referenced this pull request

2022-09-03 12:44:28 +00:00

Add bidirectional text support #2765