FSFE/fsfe-website
28
32
Fork 92
Code Issues 64 Pull Requests 17 Wiki Activity

WIP: Follow-up boxes: change default and overhaul #2542

Draft
max.mehl wants to merge 3 commits from followup-default-mail into master
pull from: followup-default-mail
merge into: FSFE:master
Conversation 1 Commits 3 Files Changed 6 +133 -89
max.mehl commented 2022-04-06 11:42:01 +00:00
Owner
Copy Link

Fixes #2405

It also sorts a few things in the XSL files, adds some documentation, and removes outdated info.

The newly introduced follow-up box for the mail signup still needs work and thoughts.

Fixes #2405 It also sorts a few things in the XSL files, adds some documentation, and removes outdated info. The newly introduced follow-up box for the mail signup still needs work and thoughts.
max.mehl self-assigned this 2022-04-06 11:42:01 +00:00
max.mehl added 3 commits 2022-04-06 11:42:03 +00:00
move all follow-up box logic to fsfe_followupsection.xsl 5d01cd2cab
remove support box that features a deprecated activity c648a8b3b2
basic setup for a subscribe-emails followup box
All checks were successful
continuous-integration/drone/pr Build is passing
Details
5d906b78cc 
far from perfect. it would be great to re-use texts from modules to avoid duplicating them in texts.*.eml
tobiasd commented 2022-12-27 13:29:11 +00:00
Owner
Copy Link

What is the state of this @max.mehl ?

What is the state of this @max.mehl ?
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details
This pull request has changes conflicting with the target branch.
  • build/xslt/fsfe_followupsection.xsl
  • build/xslt/static-elements.xsl
  • drm.info/xslt/drm_info_body.xsl
  • global/data/texts/texts.en.xml
  • news/newsletter.xsl
  • pdfreaders/xslt/pdfreaders_body.xsl
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin followup-default-mail:followup-default-mail
git checkout followup-default-mail
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bonnie cryptie dario delliott dfajfer dmaphy doczkal eal egnun eventregbot fi fkobi floriansnow gabriel.ku guido hl hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard renovate-bot repentinus schiessle sofiaritz tobiasd vincent
No Assignees max.mehl
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#2542
Delete Branch "followup-default-mail"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?