Updated German translation of freesoftware.de.xhtml #2366

jotceem · 2021-12-20T21:44:06Z

jotceem commented

2021-12-20 21:44:06 +00:00

WIP:
This is my very first PR at FSFE and git as well. I hope I'm doing it right.
Bonnie gave great support to me in learning git (thanking her very much for her patience and explanations).

The page was marked "outdated" so I did an update to the translation including additions and some minor wordings which I think are more appropriate in their contexts.

The branch in my origin is referred, thus do not upload any file here. Hoping that this is correct :-)

WIP: This is my very first PR at FSFE and git as well. I hope I'm doing it right. Bonnie gave great support to me in learning git (thanking her very much for her patience and explanations). The page was marked "outdated" so I did an update to the translation including additions and some minor wordings which I think are more appropriate in their contexts. The branch in my origin is referred, thus do not upload any file here. Hoping that this is correct :-)

jotceem added 1 commit 2021-12-20 21:44:18 +00:00

continuous-integration/drone/pr Build is passing Details

e92b446b20 Updated German translation of freesoftware.de.xhtml

bonnie added the

translations

label 2021-12-21 09:10:15 +00:00

bonnie requested changes 2021-12-21 09:54:45 +00:00

bonnie left a comment

Dear Jens,

Thank you very much for your kind words and this dearly needed update of the Free Software page.
It looks very good two me, I only spotted two minor issues (but as the file is too large for the diff view I have two write them down here :/)

version needs to be set to 6 not 5: 6
In the last paragraph it should be:
Patentinhaberinnen und den Patentinhabern
Softwareentwicklerinnen und Softwareentwicklern

(as we have used the feminine and masculine version in the rest of the text this should be consistent)

Best wishes,
Bonnie

Dear Jens, Thank you very much for your kind words and this dearly needed update of the Free Software page. It looks very good two me, I only spotted two minor issues (but as the file is too large for the diff view I have two write them down here :/) 1. version needs to be set to 6 not 5: <version>6</version> 2. In the last paragraph it should be: Patentinhaberinnen und den Patentinhabern Softwareentwicklerinnen und Softwareentwicklern (as we have used the feminine and masculine version in the rest of the text this should be consistent) Best wishes, Bonnie

jotceem added 1 commit 2021-12-21 21:06:50 +00:00

continuous-integration/drone/pr Build is passing Details

c11d3de77e Changes acc. PR-comments (Version+last paragraph)

jotceem requested review from bonnie 2021-12-21 21:14:59 +00:00

bonnie approved these changes 2021-12-22 10:36:44 +00:00

bonnie commented

2021-12-22 10:38:17 +00:00

Thank you Jens! I will merge the PR now.

Best regards and a merry X-mas,
Bonnie

Thank you Jens! I will merge the PR now. Best regards and a merry X-mas, Bonnie

bonnie merged commit cb4964a704 into master

2021-12-22 10:38:28 +00:00