FSFE
/
fsfe-website
28
27
Fork 74
Code Issues 61 Pull Requests 16 Releases Wiki Activity
Labels Milestones

FSFE20 pages #1917

Merged
max.mehl merged 13 commits from nico.rikken/fsfe-website:feature/fsfe20-recovery into master 2 years ago
Conversation 0 Commits 13 Files Changed 11
nico.rikken commented 2 years ago
Collaborator

Commit of generic FSFE20 pages, which also aggregate related articles. This pull request replaces the earlier pull request #1905

Commit of generic FSFE20 pages, which also aggregate related articles. This pull request replaces the earlier pull request https://git.fsfe.org/FSFE/fsfe-website/pulls/1905
nico.rikken added 12 commits 2 years ago
continuous-integration/drone/pr Build is passing Details
3f89005dab update 20 years page text in English
continuous-integration/drone/pr Build is passing Details
68d40b4460 add italian and german translations
continuous-integration/drone/pr Build is passing Details
3cf2168cc7 update sources to exclude newsletters
continuous-integration/drone/pr Build is passing Details
b880d6fe46 add fsfe about sidebar
continuous-integration/drone/pr Build is passing Details
33c6b8237e fsfe20 video instead of image
continuous-integration/drone/pr Build is passing Details
3d7e82db9e move from about/ to activities/20years
continuous-integration/drone/pr Build is passing Details
5f1a509ad8 update English 20 years title
continuous-integration/drone/pr Build is passing Details
291a0f5ccb fix: correct video URLs
max.mehl approved these changes 2 years ago
max.mehl left a comment
Owner

LGTM, thank you!

One question from my side, but I leave it to you to decide this.

LGTM, thank you! One question from my side, but I leave it to you to decide this.
activities/20years/20years.sources Outdated
news/2021/*:[fsfe20]
max.mehl commented 2 years ago
Owner

Why do you limit it to these two years? Usually, we wildcard this, shouldn't be a huge performance loss AFAIK.

Why do you limit it to these two years? Usually, we wildcard this, shouldn't be a huge performance loss AFAIK.
reinhard commented 2 years ago
Collaborator

FWIW, for news it is a measurable performance loss, because it means that very many XML files have to be parsed.

FWIW, for news it *is* a measurable performance loss, because it means that very many XML files have to be parsed.
max.mehl commented 2 years ago
Owner

Ah, good to know! I thought this wasn't intensive.

Silly side question: is it possible to give it a range, like 2019-*? In this case, we could surely identify some tags that only start to exist after the first 15 years of news items and events ;)

Ah, good to know! I thought this wasn't intensive. Silly side question: is it possible to give it a range, like `2019-*`? In this case, we could surely identify some tags that only start to exist after the first 15 years of news items and events ;)
reinhard commented 2 years ago
Collaborator

No, there's only shell globbing, so what you could do maybe was have 2 lines with 2019 and 202*, which will work for the upcoming 8.5 years.

No, there's only shell globbing, so what you could do maybe was have 2 lines with `2019` and `202*`, which will work for the upcoming 8.5 years.
max.mehl commented 2 years ago
Owner

That sounds reasonable!

@nico.rikken would it be possible for you to implement that? This would avoid the risk that we may have an article tagged with this in 2022, which could well happen in a restrospective or so.

That sounds reasonable! @nico.rikken would it be possible for you to implement that? This would avoid the risk that we may have an article tagged with this in 2022, which could well happen in a restrospective or so.
nico.rikken commented 2 years ago
Poster
Collaborator

Sure I will. I found another .sources file somewhere also having a limited date scope. Nothing in 2019 or 2020 was tagged with fsfe20, so 202* will do just fine. I just assumed nothing would be written after 2022. I'll convert it to a globbing line then.

Sure I will. I found another `.sources` file somewhere also having a limited date scope. Nothing in 2019 or 2020 was tagged with `fsfe20`, so `202*` will do just fine. I just assumed nothing would be written after 2022. I'll convert it to a globbing line then.
nico.rikken marked this conversation as resolved
nico.rikken added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
2f5c0db304 chore: simplify sources file using globbing
max.mehl merged commit ee070018ae into master 2 years ago
max.mehl referenced this issue from a commit 2 years ago
FSFE20 pages (#1917)

Reviewers

max.mehl approved these changes 2 years ago
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as ee070018ae.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
max.mehl
Labels
Apply labels
Clear labels
bug build cgi Scripting design disruptive
Requires careful coordination and documentation changes documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
No Label bug build cgi Scripting design disruptive documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1917
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'nico.rikken/fsfe-website:feature/fsfe20-recovery'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes