FSFE
/
fsfe-website
29
30
Fork 85
Code Issues 61 Pull Requests 14 Wiki Activity

FSFE20 pages #1917

Merged
max.mehl merged 13 commits from nico.rikken/fsfe-website:feature/fsfe20-recovery into master 2021-05-19 11:04:05 +00:00
Conversation 0 Commits 13 Files Changed 11 +170 -7
nico.rikken commented 2021-05-12 20:42:42 +00:00
Member
Copy Link

Commit of generic FSFE20 pages, which also aggregate related articles. This pull request replaces the earlier pull request #1905

Commit of generic FSFE20 pages, which also aggregate related articles. This pull request replaces the earlier pull request https://git.fsfe.org/FSFE/fsfe-website/pulls/1905
nico.rikken added 12 commits 2021-05-12 20:42:46 +00:00
continuous-integration/drone/pr Build is passing Details
3f89005dab update 20 years page text in English
continuous-integration/drone/pr Build is passing Details
68d40b4460 add italian and german translations
continuous-integration/drone/pr Build is passing Details
3cf2168cc7 update sources to exclude newsletters
continuous-integration/drone/pr Build is passing Details
b880d6fe46 add fsfe about sidebar
continuous-integration/drone/pr Build is passing Details
33c6b8237e fsfe20 video instead of image
continuous-integration/drone/pr Build is passing Details
3d7e82db9e move from about/ to activities/20years
continuous-integration/drone/pr Build is passing Details
5f1a509ad8 update English 20 years title
continuous-integration/drone/pr Build is passing Details
291a0f5ccb fix: correct video URLs
max.mehl approved these changes 2021-05-17 12:35:24 +00:00
max.mehl left a comment
Owner
Copy Link

LGTM, thank you!

One question from my side, but I leave it to you to decide this.

LGTM, thank you! One question from my side, but I leave it to you to decide this.
activities/20years/20years.sources Outdated
@ -0,0 +1,6 @@
news/2021/*:[fsfe20]
max.mehl commented 2021-05-17 12:17:03 +00:00
Owner
Copy Link

Why do you limit it to these two years? Usually, we wildcard this, shouldn't be a huge performance loss AFAIK.

Why do you limit it to these two years? Usually, we wildcard this, shouldn't be a huge performance loss AFAIK.
reinhard commented 2021-05-17 12:40:53 +00:00
Member
Copy Link

FWIW, for news it is a measurable performance loss, because it means that very many XML files have to be parsed.

FWIW, for news it *is* a measurable performance loss, because it means that very many XML files have to be parsed.
max.mehl commented 2021-05-17 13:00:21 +00:00
Owner
Copy Link

Ah, good to know! I thought this wasn't intensive.

Silly side question: is it possible to give it a range, like 2019-*? In this case, we could surely identify some tags that only start to exist after the first 15 years of news items and events ;)

Ah, good to know! I thought this wasn't intensive. Silly side question: is it possible to give it a range, like `2019-*`? In this case, we could surely identify some tags that only start to exist after the first 15 years of news items and events ;)
reinhard commented 2021-05-17 14:22:48 +00:00
Member
Copy Link

No, there's only shell globbing, so what you could do maybe was have 2 lines with 2019 and 202*, which will work for the upcoming 8.5 years.

No, there's only shell globbing, so what you could do maybe was have 2 lines with `2019` and `202*`, which will work for the upcoming 8.5 years.
max.mehl commented 2021-05-17 14:27:24 +00:00
Owner
Copy Link

That sounds reasonable!

@nico.rikken would it be possible for you to implement that? This would avoid the risk that we may have an article tagged with this in 2022, which could well happen in a restrospective or so.

That sounds reasonable! @nico.rikken would it be possible for you to implement that? This would avoid the risk that we may have an article tagged with this in 2022, which could well happen in a restrospective or so.
nico.rikken commented 2021-05-17 16:47:57 +00:00
Author
Member
Copy Link

Sure I will. I found another .sources file somewhere also having a limited date scope. Nothing in 2019 or 2020 was tagged with fsfe20, so 202* will do just fine. I just assumed nothing would be written after 2022. I'll convert it to a globbing line then.

Sure I will. I found another `.sources` file somewhere also having a limited date scope. Nothing in 2019 or 2020 was tagged with `fsfe20`, so `202*` will do just fine. I just assumed nothing would be written after 2022. I'll convert it to a globbing line then.
nico.rikken marked this conversation as resolved
nico.rikken added 1 commit 2021-05-17 16:55:22 +00:00
continuous-integration/drone/pr Build is passing Details
2f5c0db304 chore: simplify sources file using globbing
max.mehl merged commit ee070018ae into master 2021-05-19 11:03:22 +00:00
max.mehl referenced this issue from a commit 2021-05-19 11:03:23 +00:00
FSFE20 pages (#1917)
Sign in to join this conversation.
Reviewers
No reviewers
max.mehl
Labels
Clear labels   
bug

   
build

   
cgi Scripting

   
design

   
disruptive

Requires careful coordination and documentation changes

  
documentation

   
duplicate

   
easy

   
feature-request

   
help wanted

   
javascript

   
priority/low

   
question

   
system-hackers

   
tagging

   
text

   
translations

   
wait/bugfix

   
wait/inprogress

   
wait/misc

   
wait/proofread

   
wontfix

   
xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1917
No description provided.
Delete Branch "nico.rikken/fsfe-website:feature/fsfe20-recovery"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?