FSFE
/
fsfe-website
20
23
Fork 52
Code Issues 55 Pull Requests 10 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#1721 WIP: Add social media to the footer

Open
fbn_bmns wants to merge 2 commits from fbn_bmns/fsfe-website:issue_1617 into master
Conversation 3 Commits 2 Files Changed 2
fbn_bmns commented 5 months ago

Fixes #1617.

Please have a look and give some feedback :)

Fixes #1617. Please have a look and give some feedback :)
doczkal commented 5 months ago
Collaborator

Thanks for your contribution. I really like the buttons.

I noticed two thinks I would like to raise for discussion.

  1. I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order.
  2. For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly?

What do you think? I'd like to involve @max.mehl as I remember him actively contributing to the discussion.

Thanks for your contribution. I really like the buttons. I noticed two thinks I would like to raise for discussion. 1. I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order. 1. For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. [Learn more](https://wiki.fsfe.org/Advocacy/ProprietaryWebServices)." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly? What do you think? I'd like to involve @max.mehl as I remember him actively contributing to the discussion.
reinhard commented 2 months ago
Collaborator

FWIW, I don't understand the background of the change in texts-en.xml - was this only accidentally?

FWIW, I don't understand the background of the change in `texts-en.xml` - was this only accidentally?
max.mehl commented 2 months ago
Owner

Another FWIW:

I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order.

I agree that having Mastodon first makes sense.

For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly?

Here I disagree. Adding even more text there rather defeats the purpose IMHO. It would bloat up the whole footer. We could hide it in a mouse-over or so, perhaps similar to how we do it on https://fsfe.org/order/order.html

Also, it may make sense to also add Peertube and Youtube. You can see our typical channels here: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/global/data/modules/social-media.en.xml

Another FWIW: > I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order. I agree that having Mastodon first makes sense. > For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly? Here I disagree. Adding even more text there rather defeats the purpose IMHO. It would bloat up the whole footer. We could hide it in a mouse-over or so, perhaps similar to how we do it on https://fsfe.org/order/order.html Also, it may make sense to also add Peertube and Youtube. You can see our typical channels here: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/global/data/modules/social-media.en.xml
fbn_bmns added 1 commit 2 months ago
All checks were successful
continuous-integration/drone/pr Build is passing
Details
This pull request is marked as a work in progress. Remove the WIP: prefix from the title when it's ready
This branch is out-of-date with the base branch
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug build cgi Scripting design disruptive
Requires careful coordination and documentation changes documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fbn_bmns/fsfe-website:issue_1617'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes