FSFE
/
fsfe-website
28
27
Fork 74
Code Issues 62 Pull Requests 14 Releases Wiki Activity
Labels Milestones

Add social media to the footer #1721

Merged
max.mehl merged 7 commits from fbn_bmns/fsfe-website:issue_1617 into master 11 months ago
Conversation 5 Commits 7 Files Changed 6
fbn_bmns commented 2 years ago

Fixes #1617.

Please have a look and give some feedback :)

Fixes #1617. Please have a look and give some feedback :)
doczkal commented 2 years ago
Collaborator

Thanks for your contribution. I really like the buttons.

I noticed two thinks I would like to raise for discussion.

  1. I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order.
  2. For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly?

What do you think? I'd like to involve @max.mehl as I remember him actively contributing to the discussion.

Thanks for your contribution. I really like the buttons. I noticed two thinks I would like to raise for discussion. 1. I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order. 1. For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. [Learn more](https://wiki.fsfe.org/Advocacy/ProprietaryWebServices)." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly? What do you think? I'd like to involve @max.mehl as I remember him actively contributing to the discussion.
reinhard commented 2 years ago
Collaborator

FWIW, I don't understand the background of the change in texts-en.xml - was this only accidentally?

FWIW, I don't understand the background of the change in `texts-en.xml` - was this only accidentally?
max.mehl commented 2 years ago
Owner

Another FWIW:

I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order.

I agree that having Mastodon first makes sense.

For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly?

Here I disagree. Adding even more text there rather defeats the purpose IMHO. It would bloat up the whole footer. We could hide it in a mouse-over or so, perhaps similar to how we do it on https://fsfe.org/order/order.html

Also, it may make sense to also add Peertube and Youtube. You can see our typical channels here: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/global/data/modules/social-media.en.xml

Another FWIW: > I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order. I agree that having Mastodon first makes sense. > For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly? Here I disagree. Adding even more text there rather defeats the purpose IMHO. It would bloat up the whole footer. We could hide it in a mouse-over or so, perhaps similar to how we do it on https://fsfe.org/order/order.html Also, it may make sense to also add Peertube and Youtube. You can see our typical channels here: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/global/data/modules/social-media.en.xml
fbn_bmns added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
ea3a7b3caa Merge branch 'master' into issue_1617
max.mehl added 1 commit 1 year ago
continuous-integration/drone/pr Build is passing Details
40d790e9df Merge branch 'master' into issue_1617
max.mehl added 1 commit 11 months ago
continuous-integration/drone/pr Build is passing Details
5ef7d8897a
remove unused string again
max.mehl commented 11 months ago
Owner

FWIW, I don't understand the background of the change in texts-en.xml - was this only accidentally?

I just removed this as it really wasn't used in the PR. Will implement some hover texts manually as they do not have to be translated.

> FWIW, I don't understand the background of the change in `texts-en.xml` - was this only accidentally? I just removed this as it really wasn't used in the PR. Will implement some hover texts manually as they do not have to be translated.
max.mehl added 2 commits 11 months ago
max.mehl force-pushed issue_1617 from abb8fcea01 to 8c892127db 11 months ago
max.mehl changed title from WIP: Add social media to the footer to Add social media to the footer 11 months ago
max.mehl commented 11 months ago
Owner

This should be good to go. Phew, this was an old issue!

This should be good to go. Phew, this was an old issue!
max.mehl merged commit 28ad8bdd71 into master 11 months ago
max.mehl referenced this issue from a commit 11 months ago
Add social media to the footer (#1721)
max.mehl deleted branch issue_1617 11 months ago
vincent referenced this issue from a commit 9 months ago
Add social media to the footer (#1721)
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as 28ad8bdd71.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug build cgi Scripting design disruptive
Requires careful coordination and documentation changes documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
No Label bug build cgi Scripting design disruptive documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1721
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fbn_bmns/fsfe-website:issue_1617'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes