Add social media to the footer #1721

2020-11-27T19:06:14Z

fbn_bmns commented

2020-11-27 19:06:14 +00:00

Fixes #1617.

Please have a look and give some feedback :)

Fixes #1617. Please have a look and give some feedback :)

doczkal commented

2020-11-28 15:28:17 +00:00

Thanks for your contribution. I really like the buttons.

I noticed two thinks I would like to raise for discussion.

I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order.
For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly?

What do you think? I'd like to involve @max.mehl as I remember him actively contributing to the discussion.

Thanks for your contribution. I really like the buttons. I noticed two thinks I would like to raise for discussion. 1. I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order. 1. For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. [Learn more](https://wiki.fsfe.org/Advocacy/ProprietaryWebServices)." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly? What do you think? I'd like to involve @max.mehl as I remember him actively contributing to the discussion.

reinhard commented

2021-02-21 19:36:53 +00:00

FWIW, I don't understand the background of the change in texts-en.xml - was this only accidentally?

FWIW, I don't understand the background of the change in `texts-en.xml` - was this only accidentally?

max.mehl commented

2021-02-23 16:02:32 +00:00

Another FWIW:

I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order.

I agree that having Mastodon first makes sense.

For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly?

Here I disagree. Adding even more text there rather defeats the purpose IMHO. It would bloat up the whole footer. We could hide it in a mouse-over or so, perhaps similar to how we do it on https://fsfe.org/order/order.html

Also, it may make sense to also add Peertube and Youtube. You can see our typical channels here: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/global/data/modules/social-media.en.xml

Another FWIW: > I think in a lenghty discussion we agreed to order the share buttons in order of 'services that respect your freedom before services that may be free software unfriendly'. Which in return would mean the buttons should be in opposite order. I agree that having Mastodon first makes sense. > For the 'Share and support' footer we have a Text "Some services may be Free Software unfriendly and harm your privacy. Learn more." Maybe we should add a similar text here. As we have two buttons only maybe we can name twitter expecitly? Here I disagree. Adding even more text there rather defeats the purpose IMHO. It would bloat up the whole footer. We could hide it in a mouse-over or so, perhaps similar to how we do it on https://fsfe.org/order/order.html Also, it may make sense to also add Peertube and Youtube. You can see our typical channels here: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/global/data/modules/social-media.en.xml

fbn_bmns added 1 commit 2021-02-24 19:21:36 +00:00

Merge branch 'master' into issue_1617

continuous-integration/drone/pr Build is passing

Details

ea3a7b3caa

max.mehl added 1 commit 2022-03-14 11:31:09 +00:00

Merge branch 'master' into issue_1617

continuous-integration/drone/pr Build is passing

Details

40d790e9df

max.mehl added 1 commit 2022-04-22 14:46:48 +00:00

remove unused string again

continuous-integration/drone/pr Build is passing

Details

5ef7d8897a

max.mehl commented

2022-04-22 14:47:28 +00:00

FWIW, I don't understand the background of the change in texts-en.xml - was this only accidentally?

I just removed this as it really wasn't used in the PR. Will implement some hover texts manually as they do not have to be translated.

> FWIW, I don't understand the background of the change in `texts-en.xml` - was this only accidentally? I just removed this as it really wasn't used in the PR. Will implement some hover texts manually as they do not have to be translated.

max.mehl added 2 commits 2022-04-22 15:17:50 +00:00

update/add peertube/youtube graphics 0ff68d3a8f

add peertube and youtube, and alt/title attributes add1658407

max.mehl force-pushed issue_1617 from abb8fcea01 to 8c892127db

2022-04-22 15:20:33 +00:00

Compare

max.mehl marked the pull request as ready for review 2022-04-22 15:20:49 +00:00

max.mehl commented

2022-04-22 15:21:41 +00:00

This should be good to go. Phew, this was an old issue!

max.mehl merged commit 28ad8bdd71 into master

2022-04-22 15:22:43 +00:00