Add social media to the footer #1721
Merged
max.mehl
merged 7 commits from fbn_bmns/fsfe-website:issue_1617
into master
11 months ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'fbn_bmns/fsfe-website:issue_1617'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Fixes #1617.
Please have a look and give some feedback :)
Thanks for your contribution. I really like the buttons.
I noticed two thinks I would like to raise for discussion.
What do you think? I'd like to involve @max.mehl as I remember him actively contributing to the discussion.
FWIW, I don't understand the background of the change in
texts-en.xml
- was this only accidentally?Another FWIW:
I agree that having Mastodon first makes sense.
Here I disagree. Adding even more text there rather defeats the purpose IMHO. It would bloat up the whole footer. We could hide it in a mouse-over or so, perhaps similar to how we do it on https://fsfe.org/order/order.html
Also, it may make sense to also add Peertube and Youtube. You can see our typical channels here: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/global/data/modules/social-media.en.xml
I just removed this as it really wasn't used in the PR. Will implement some hover texts manually as they do not have to be translated.
abb8fcea01
to8c892127db
11 months agoWIP: Add social media to the footerto Add social media to the footer 11 months agoThis should be good to go. Phew, this was an old issue!
28ad8bdd71
into master 11 months ago28ad8bdd71
.