FSFE
/
fsfe-website
25
26
Fork 67
Code Issues 63 Pull Requests 5 Releases Wiki Activity
Labels Milestones

chore: unify FSFE URLs in drm.info and pdfreaders #1424

Merged
reinhard merged 2 commits from nico.rikken/fsfe-website:feature/convert-absolute-links-2 into master 2 years ago
Conversation 4 Commits 2 Files Changed 16
nico.rikken commented 2 years ago
Collaborator

Unifies the URLs for drm.info and pdfreaders sections to be https://fsfe.org style.
This was achieved by running the following commands:

cd drm.info/
find . -iname '*.xml' -exec perl -pi -e 's/href=\"http(s)?:\/\/(www\.)?fsfe(urope)?\.org/href=\"https:\/\/fsfe.org/g' {} \;
find . -iname '*.xhtml' -exec perl -pi -e 's/href=\"http(s)?:\/\/(www\.)?fsfe(urope)?\.org/href=\"https:\/\/fsfe.org/g' {} \;
cd ../pdfreaders/
find . -iname '*.xml' -exec perl -pi -e 's/href=\"http(s)?:\/\/(www\.)?fsfe(urope)?\.org/href=\"https:\/\/fsfe.org/g' {} \;
find . -iname '*.xhtml' -exec perl -pi -e 's/href=\"http(s)?:\/\/(www\.)?fsfe(urope)?\.org/href=\"https:\/\/fsfe.org/g' {} \;

Note that in this case the match on the trailing slash / is ommitted in order to match http://fsfe.org for example.

Unifies the URLs for drm.info and pdfreaders sections to be `https://fsfe.org` style. This was achieved by running the following commands: ``` cd drm.info/ find . -iname '*.xml' -exec perl -pi -e 's/href=\"http(s)?:\/\/(www\.)?fsfe(urope)?\.org/href=\"https:\/\/fsfe.org/g' {} \; find . -iname '*.xhtml' -exec perl -pi -e 's/href=\"http(s)?:\/\/(www\.)?fsfe(urope)?\.org/href=\"https:\/\/fsfe.org/g' {} \; cd ../pdfreaders/ find . -iname '*.xml' -exec perl -pi -e 's/href=\"http(s)?:\/\/(www\.)?fsfe(urope)?\.org/href=\"https:\/\/fsfe.org/g' {} \; find . -iname '*.xhtml' -exec perl -pi -e 's/href=\"http(s)?:\/\/(www\.)?fsfe(urope)?\.org/href=\"https:\/\/fsfe.org/g' {} \; ``` Note that in this case the match on the trailing slash `/` is ommitted in order to match `http://fsfe.org` for example.
doczkal commented 2 years ago
Collaborator

Should we change this for www.wikipedia.org and other domains as well?

Should we change this for www.wikipedia.org and other domains as well?
doczkal approved these changes 2 years ago
doczkal left a comment
Collaborator

I can't see any negative impacts running this change.

I can't see any negative impacts running this change.
max.mehl requested changes 2 years ago
pdfreaders/pdfreaders.hu.xhtml Outdated
<h2>Szerezz be egy szabad PDF olvasót!</h2>
<p>A Portable Document Format (PDF) egy népszerű formátum formázott szöveg és dokumentumok létrehozásához. Több különböző verziója létezik, néhány közülük <a href="http://www.fsfeurope.org/projects/os/def.en.html">Nyílt szabvány</a>, néhány <a href="http://www.iso.org">ISO</a> minősített és néhány <a href="http://fsfeurope.org/projects/swpat/background.en.html">szoftverszabadalmakkal</a> terhelt. Érdemes előnyben részesíteni a nyílt szabványú verziókat, mert a Nyílt szabványok garantálják az együttműködő rendszereket, a szabad versenyt és a szabad választást. <a href="http://www.fsfeurope.org/projects/os/os.en.html">Bővebben...</a></p>
<p>A Portable Document Format (PDF) egy népszerű formátum formázott szöveg és dokumentumok létrehozásához. Több különböző verziója létezik, néhány közülük <a href="https://fsfe.org/projects/os/def.en.html">Nyílt szabvány</a>, néhány <a href="http://www.iso.org">ISO</a> minősített és néhány <a href="https://fsfe.org/projects/swpat/background.en.html">szoftverszabadalmakkal</a> terhelt. Érdemes előnyben részesíteni a nyílt szabványú verziókat, mert a Nyílt szabványok garantálják az együttműködő rendszereket, a szabad versenyt és a szabad választást. <a href="https://fsfe.org/projects/os/os.en.html">Bővebben...</a></p>
max.mehl commented 2 years ago
Owner

@niko.rikken would it be possible for you to remove the static links to the English version in the links here and in the next paragraph? So e.g. https://fsfe.org/projects/os/def.en.html to https://fsfe.org/projects/os/def.html

@niko.rikken would it be possible for you to remove the static links to the English version in the links here and in the next paragraph? So e.g. `https://fsfe.org/projects/os/def.en.html` to `https://fsfe.org/projects/os/def.html`
nico.rikken commented 2 years ago
Poster
Collaborator

Sure I will. How does this relate to other FSFE language-specific URL's. I noticed .de.html and .en.html links for example.

Sure I will. How does this relate to other FSFE language-specific URL's. I noticed `.de.html` and `.en.html` links for example.
reinhard commented 2 years ago
Collaborator

Should we change this for www.wikipedia.org and other domains as well?

@doczkal I don't understand, could you rephrase?

> Should we change this for www.wikipedia.org and other domains as well? @doczkal I don't understand, could you rephrase?
nico.rikken commented 2 years ago
Poster
Collaborator

Should we change this for www.wikipedia.org and other domains as well?

@doczkal I don't understand, could you rephrase?

I assume this relates to the FSFE sourcecode, and so this would be about ensuring https on links to major websites. There are links to wikipedia.org, google.com, gnu.org, documentfreedom.org. Am I right?

Also I noticed links to blogs.fsfe.org and planet.fsfe.org that are still http only.

> > Should we change this for www.wikipedia.org and other domains as well? > > @doczkal I don't understand, could you rephrase? I assume this relates to the FSFE sourcecode, and so this would be about ensuring `https` on links to major websites. There are links to `wikipedia.org`, `google.com`, `gnu.org`, `documentfreedom.org`. Am I right? Also I noticed links to `blogs.fsfe.org` and `planet.fsfe.org` that are still `http` only.
nico.rikken commented 2 years ago
Poster
Collaborator

Perhaps we can keep the discussion on additional improvements on the issue #1378 , so I can check them off there.

Perhaps we can keep the discussion on additional improvements on the issue #1378 , so I can check them off there.
reinhard closed this pull request 2 years ago
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as c3966e5b9c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug build cgi Scripting design disruptive
Requires careful coordination and documentation changes documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
No Label bug build cgi Scripting design disruptive documentation duplicate easy feature-request help wanted javascript priority/low question system-hackers tagging text translations wait/bugfix wait/inprogress wait/misc wait/proofread wontfix xsl
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'nico.rikken/fsfe-website:feature/convert-absolute-links-2'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes