FSFE/fsfe-website
25
31
Fork 92
Code Issues 65 Pull Requests 5 Wiki Activity

feature/convert-absolute-links #1383

Manually merged
reinhard merged 12 commits from nico.rikken/fsfe-website:feature/convert-absolute-links into master 2020-05-16 11:48:47 +00:00
Conversation 3 Commits 12 Files Changed 649 +2072 -2072
nico.rikken commented 2020-05-13 18:39:20 +00:00
Member
Copy Link

To tackle #1378 by converting absolute links to relative links.

Commands used for this conversion:

Get information on the files with absolute links:

ag -c "href=\"https://fsfe.org/"
grep -r -c -e "href=\"https://fsfe.org"

To replace the strings based on file types:

find . -iname '*.xhtml' -exec perl -pi -e 's/href=\"https:\/\/fsfe\.org\//href=\"\//g' {} \;

The current remaining list of detected files, as I wasn't sure if I should change them as well:

$ ag -c "href=\"https://fsfe.org/"
pdfreaders/pdfreaders.en.xhtml:4
pdfreaders/pdfreaders.pl.xhtml:4
pdfreaders/about.he.xhtml:5
pdfreaders/about.cs.xhtml:5
pdfreaders/pdfreaders.sv.xhtml:5
pdfreaders/about.zh.xhtml:4
pdfreaders/pdfreaders.et.xhtml:4
pdfreaders/os.tr.xhtml:1
pdfreaders/about.tr.xhtml:5
pdfreaders/about.fr.xhtml:5
pdfreaders/os.he.xhtml:1
pdfreaders/pdfreaders.hr.xhtml:4
pdfreaders/pdfreaders.fa.xhtml:4
pdfreaders/about.ro.xhtml:5
pdfreaders/about.ar.xhtml:4
pdfreaders/about.nn.xhtml:4
pdfreaders/os.zh.xhtml:1
pdfreaders/os.pl.xhtml:1
pdfreaders/os.cs.xhtml:1
pdfreaders/os.es.xhtml:1
pdfreaders/about.gl.xhtml:3
pdfreaders/pdfreaders.es.xhtml:4
pdfreaders/about.el.xhtml:4
pdfreaders/pdfreaders.nl.xhtml:4
pdfreaders/pdfreaders.fi.xhtml:4
pdfreaders/os.gl.xhtml:1
pdfreaders/about.es.xhtml:4
pdfreaders/os.fr.xhtml:1
pdfreaders/os.fa.xhtml:1
pdfreaders/os.ro.xhtml:1
pdfreaders/about.ru.xhtml:2
pdfreaders/os.el.xhtml:1
pdfreaders/os.en.xhtml:1
pdfreaders/os.pt.xhtml:1
pdfreaders/os.sl.xhtml:1
pdfreaders/pdfreaders.de.xhtml:4
pdfreaders/about.en.xhtml:2
pdfreaders/about.sv.xhtml:4
pdfreaders/os.nb.xhtml:1
pdfreaders/os.hr.xhtml:1
pdfreaders/os.ar.xhtml:1
pdfreaders/pdfreaders.el.xhtml:4
pdfreaders/about.de.xhtml:5
pdfreaders/about.eo.xhtml:3
pdfreaders/about.hr.xhtml:5
pdfreaders/os.de.xhtml:1
pdfreaders/os.sv.xhtml:1
pdfreaders/os.nl.xhtml:1
pdfreaders/pdfreaders.it.xhtml:4
pdfreaders/os.et.xhtml:1
pdfreaders/os.ru.xhtml:1
pdfreaders/pdfreaders.ar.xhtml:5
pdfreaders/about.nb.xhtml:4
pdfreaders/about.et.xhtml:5
pdfreaders/pdfreaders.fr.xhtml:5
pdfreaders/pdfreaders.tr.xhtml:4
pdfreaders/about.sl.xhtml:5
pdfreaders/os.eo.xhtml:1
pdfreaders/pdfreaders.nb.xhtml:5
pdfreaders/about.nl.xhtml:2
pdfreaders/os.it.xhtml:1
pdfreaders/pdfreaders.ro.xhtml:5
pdfreaders/pdfreaders.gl.xhtml:5
pdfreaders/pdfreaders.sl.xhtml:4
pdfreaders/pdfreaders.cs.xhtml:4
pdfreaders/about.fi.xhtml:6
pdfreaders/about.pl.xhtml:2
pdfreaders/os.fi.xhtml:1
pdfreaders/pdfreaders.ru.xhtml:4
pdfreaders/pdfreaders.pt.xhtml:5
pdfreaders/os.nn.xhtml:1
pdfreaders/about.it.xhtml:2
pdfreaders/about.hu.xhtml:4
pdfreaders/os.hu.xhtml:1
pdfreaders/pdfreaders.zh.xhtml:5
pdfreaders/about.fa.xhtml:5
pdfreaders/about.pt.xhtml:5
pdfreaders/pdfreaders.nn.xhtml:5
pdfreaders/pdfreaders.he.xhtml:4
drm.info/creativity.es.xhtml:1
drm.info/act-now.es.xhtml:2
timeline/timeline.it.svg:37
timeline/timeline.nl.svg:36
timeline/timeline.svg:37
news/podcast.rss.xsl:1
To tackle #1378 by converting absolute links to relative links. Commands used for this conversion: Get information on the files with absolute links: ``` ag -c "href=\"https://fsfe.org/" grep -r -c -e "href=\"https://fsfe.org" ``` To replace the strings based on file types: ``` find . -iname '*.xhtml' -exec perl -pi -e 's/href=\"https:\/\/fsfe\.org\//href=\"\//g' {} \; ``` The current remaining list of detected files, as I wasn't sure if I should change them as well: ``` $ ag -c "href=\"https://fsfe.org/" pdfreaders/pdfreaders.en.xhtml:4 pdfreaders/pdfreaders.pl.xhtml:4 pdfreaders/about.he.xhtml:5 pdfreaders/about.cs.xhtml:5 pdfreaders/pdfreaders.sv.xhtml:5 pdfreaders/about.zh.xhtml:4 pdfreaders/pdfreaders.et.xhtml:4 pdfreaders/os.tr.xhtml:1 pdfreaders/about.tr.xhtml:5 pdfreaders/about.fr.xhtml:5 pdfreaders/os.he.xhtml:1 pdfreaders/pdfreaders.hr.xhtml:4 pdfreaders/pdfreaders.fa.xhtml:4 pdfreaders/about.ro.xhtml:5 pdfreaders/about.ar.xhtml:4 pdfreaders/about.nn.xhtml:4 pdfreaders/os.zh.xhtml:1 pdfreaders/os.pl.xhtml:1 pdfreaders/os.cs.xhtml:1 pdfreaders/os.es.xhtml:1 pdfreaders/about.gl.xhtml:3 pdfreaders/pdfreaders.es.xhtml:4 pdfreaders/about.el.xhtml:4 pdfreaders/pdfreaders.nl.xhtml:4 pdfreaders/pdfreaders.fi.xhtml:4 pdfreaders/os.gl.xhtml:1 pdfreaders/about.es.xhtml:4 pdfreaders/os.fr.xhtml:1 pdfreaders/os.fa.xhtml:1 pdfreaders/os.ro.xhtml:1 pdfreaders/about.ru.xhtml:2 pdfreaders/os.el.xhtml:1 pdfreaders/os.en.xhtml:1 pdfreaders/os.pt.xhtml:1 pdfreaders/os.sl.xhtml:1 pdfreaders/pdfreaders.de.xhtml:4 pdfreaders/about.en.xhtml:2 pdfreaders/about.sv.xhtml:4 pdfreaders/os.nb.xhtml:1 pdfreaders/os.hr.xhtml:1 pdfreaders/os.ar.xhtml:1 pdfreaders/pdfreaders.el.xhtml:4 pdfreaders/about.de.xhtml:5 pdfreaders/about.eo.xhtml:3 pdfreaders/about.hr.xhtml:5 pdfreaders/os.de.xhtml:1 pdfreaders/os.sv.xhtml:1 pdfreaders/os.nl.xhtml:1 pdfreaders/pdfreaders.it.xhtml:4 pdfreaders/os.et.xhtml:1 pdfreaders/os.ru.xhtml:1 pdfreaders/pdfreaders.ar.xhtml:5 pdfreaders/about.nb.xhtml:4 pdfreaders/about.et.xhtml:5 pdfreaders/pdfreaders.fr.xhtml:5 pdfreaders/pdfreaders.tr.xhtml:4 pdfreaders/about.sl.xhtml:5 pdfreaders/os.eo.xhtml:1 pdfreaders/pdfreaders.nb.xhtml:5 pdfreaders/about.nl.xhtml:2 pdfreaders/os.it.xhtml:1 pdfreaders/pdfreaders.ro.xhtml:5 pdfreaders/pdfreaders.gl.xhtml:5 pdfreaders/pdfreaders.sl.xhtml:4 pdfreaders/pdfreaders.cs.xhtml:4 pdfreaders/about.fi.xhtml:6 pdfreaders/about.pl.xhtml:2 pdfreaders/os.fi.xhtml:1 pdfreaders/pdfreaders.ru.xhtml:4 pdfreaders/pdfreaders.pt.xhtml:5 pdfreaders/os.nn.xhtml:1 pdfreaders/about.it.xhtml:2 pdfreaders/about.hu.xhtml:4 pdfreaders/os.hu.xhtml:1 pdfreaders/pdfreaders.zh.xhtml:5 pdfreaders/about.fa.xhtml:5 pdfreaders/about.pt.xhtml:5 pdfreaders/pdfreaders.nn.xhtml:5 pdfreaders/pdfreaders.he.xhtml:4 drm.info/creativity.es.xhtml:1 drm.info/act-now.es.xhtml:2 timeline/timeline.it.svg:37 timeline/timeline.nl.svg:36 timeline/timeline.svg:37 news/podcast.rss.xsl:1 ```
nico.rikken commented 2020-05-13 18:57:59 +00:00
Author
Member
Copy Link

As I got many errors from the webhooks, I disabled them to make these commits. The state shouldn't be worse than previously, but just something to take note of.

As I got many errors from the webhooks, I disabled them to make these commits. The state shouldn't be worse than previously, but just something to take note of.
reinhard commented 2020-05-13 19:29:15 +00:00
Member
Copy Link

This looks good to me. A second pair of eyes would be appreciated.

This looks good to me. A second pair of eyes would be appreciated.
max.mehl commented 2020-05-15 11:39:07 +00:00
Owner
Copy Link

I just skimmed them randomly and quickly, and didn't see an issue. For a deeper inspection from my side, you would have to wait until Monday, but I think you could also merge safely :)

I just skimmed them randomly and quickly, and didn't see an issue. For a deeper inspection from my side, you would have to wait until Monday, but I think you could also merge safely :)
reinhard closed this pull request 2020-05-16 11:48:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bonnie cryptie dario delliott dmaphy doczkal eal egnun eventregbot fi floriansnow gabriel.ku guido hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard repentinus schiessle sofiaritz tobiasd vincent
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1383
No description provided.
Delete Branch "nico.rikken/fsfe-website:feature/convert-absolute-links"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?