FSFE/fsfe-website
25
30
Fork 86
Code Issues 61 Pull Requests 21 Wiki Activity

WIP: Overhaul of Promo page (clean) #1125

Closed
max.mehl wants to merge 10 commits from feature/stw-overhaul-clean into master
pull from: feature/stw-overhaul-clean
merge into: FSFE:master
Conversation 8 Commits 10 Files Changed 17 +710 -773
max.mehl commented 2019-10-21 17:20:23 +00:00
Owner
Copy Link

Successor of #1101 which edited a lot of files only format-wise. This PR only tackles the design and structure changes.

  • Change design of /contribute/spreadtheword
  • Change design of /contribute/promotion-materials-archive
  • Change a few strings in texts-en.xml for the better
  • Reorder some promo items to reduce number of categories

Screenshot: https://framapic.org/zoLNLOMMJZzP/A16KFQOIhWPL.png

Successor of #1101 which edited a lot of files only format-wise. This PR only tackles the design and structure changes. - Change design of /contribute/spreadtheword - Change design of /contribute/promotion-materials-archive - Change a few strings in texts-en.xml for the better - Reorder some promo items to reduce number of categories Screenshot: https://framapic.org/zoLNLOMMJZzP/A16KFQOIhWPL.png
👍 1
max.mehl added the
design
xsl
 labels 2019-10-21 17:20:23 +00:00
mweimann commented 2019-10-21 18:22:34 +00:00
Member
Copy Link

Looks much better.

Here are some thoughts about the rounded corners:

  • For the posters there is now a missing edge (see attachment).
  • The stickers are now presented as if they have rounded corners. In reality they are square.

I would give the single items a bit more space between so that they are cleaner to distinguish.

Lets call stock, author etc. the info section of each item. It looks noisy. I think with some alignment at this place it could be better.

For the radio buttons you could use https://getbootstrap.com/docs/3.3/components/#btn-groups (hope that's in the included bootstrap version). The current solution has filthy edges.

Looks much better. Here are some thoughts about the rounded corners: * For the posters there is now a missing edge (see attachment). * The stickers are now presented as if they have rounded corners. In reality they are square. I would give the single items a bit more space between so that they are cleaner to distinguish. Lets call *stock*, *author* etc. the *info section* of each item. It looks noisy. I think with some alignment at this place it could be better. For the radio buttons you could use https://getbootstrap.com/docs/3.3/components/#btn-groups (hope that's in the included bootstrap version). The current solution has filthy edges.
rounded.png
128 KiB
noisy.png
42 KiB
radio.png
12 KiB
rounded.png noisy.png radio.png
max.mehl commented 2019-10-21 23:00:22 +00:00
Author
Owner
Copy Link

Thanks for the feedback, @mweimann!

For the posters there is now a missing edge (see attachment).
The stickers are now presented as if they have rounded corners. In reality they are square.

True. I don't have a good solution to that, especially because of the second point you've raised. So drop rounded corners altogether?

I would give the single items a bit more space between so that they are cleaner to distinguish.

Good point, will do.

Lets call stock, author etc. the info section of each item. It looks noisy. I think with some alignment at this place it could be better.

Yeah, I've noticed that as well. I tried separating them on 2 columns but that didn't look good either since the texts are of very different length. Perhaps the left column text-right?

For the radio buttons you could use https://getbootstrap.com/docs/3.3/components/#btn-groups (hope that’s in the included bootstrap version). The current solution has filthy edges.

Ah, interesting, will try! Will the active button's value be sent with the form (probably yes)?

And is there a possibility to make one button basically an input field but at the same time a radio button (so it deactivates the predefined values)?

Thanks for the feedback, @mweimann! > For the posters there is now a missing edge (see attachment). > The stickers are now presented as if they have rounded corners. In reality they are square. True. I don't have a good solution to that, especially because of the second point you've raised. So drop rounded corners altogether? > I would give the single items a bit more space between so that they are cleaner to distinguish. Good point, will do. > Lets call stock, author etc. the info section of each item. It looks noisy. I think with some alignment at this place it could be better. Yeah, I've noticed that as well. I tried separating them on 2 columns but that didn't look good either since the texts are of very different length. Perhaps the left column text-right? > For the radio buttons you could use https://getbootstrap.com/docs/3.3/components/#btn-groups (hope that’s in the included bootstrap version). The current solution has filthy edges. Ah, interesting, will try! Will the active button's value be sent with the form (probably yes)? And is there a possibility to make one button basically an input field but at the same time a radio button (so it deactivates the predefined values)?
bonnie commented 2019-12-12 15:41:54 +00:00
Member
Copy Link

Hello,

as was agreed on this is the new country list where we are able to ship pm-packages to.

I also attached the message for the webiste in German and English.

Cheers
Bonnie

Hello, as was agreed on this is the new country list where we are able to ship pm-packages to. I also attached the message for the webiste in German and English. Cheers Bonnie
country_codes.txt
384 B
pm-message_for_changed_countries.txt
369 B
max.mehl changed title from Overhaul of Promo page (clean) to WIP: Overhaul of Promo page (clean) 2020-04-30 12:52:15 +00:00
kreyren commented 2021-01-25 00:21:55 +00:00
First-time contributor
Copy Link

Looks like stale merge request to me?

Looks like stale merge request to me?
doczkal commented 2021-02-22 10:27:16 +00:00
Member
Copy Link

Yeah, not sure what shall happen with this PR

Yeah, not sure what shall happen with this PR
suhrj commented 2021-02-22 20:27:46 +00:00
First-time contributor
Copy Link

It's something I could have a look at if @max.mehl gives me the go ahead.

It's something I could have a look at if @max.mehl gives me the go ahead.
max.mehl commented 2021-02-23 15:55:30 +00:00
Author
Owner
Copy Link

Sorry, yes, I was stuck more or less after writing #1125 (comment). It's a completely different design, and the question is whether we want to use that or rather go back to a more traditional checkbox/radio buttons design.

Would be happy if someone else took over. However, a rebase would be required first I guess ;)

Sorry, yes, I was stuck more or less after writing https://git.fsfe.org/FSFE/fsfe-website/pulls/1125#issuecomment-7250. It's a completely different design, and the question is whether we want to use that or rather go back to a more traditional checkbox/radio buttons design. Would be happy if someone else took over. However, a rebase would be required first I guess ;)
max.mehl commented 2022-03-14 11:02:25 +00:00
Author
Owner
Copy Link

Closing this for now

Closing this for now
max.mehl closed this pull request 2022-03-14 11:02:28 +00:00
max.mehl deleted branch feature/stw-overhaul-clean 2022-03-14 11:20:16 +00:00
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
build

   
cgi Scripting

   
design

   
disruptive

Requires careful coordination and documentation changes

  
documentation

   
duplicate

   
easy

   
feature-request

   
help wanted

   
javascript

   
priority/low

   
question

   
system-hackers

   
tagging

   
text

   
translations

   
wait/bugfix

   
wait/inprogress

   
wait/misc

   
wait/proofread

   
wontfix

   
xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1125
No description provided.
Delete Branch "feature/stw-overhaul-clean"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?