#1125 WIP: Overhaul of Promo page (clean)

Open
max.mehl wants to merge 10 commits from feature/stw-overhaul-clean into master
max.mehl commented 1 year ago
Owner

Successor of #1101 which edited a lot of files only format-wise. This PR only tackles the design and structure changes.

  • Change design of /contribute/spreadtheword
  • Change design of /contribute/promotion-materials-archive
  • Change a few strings in texts-en.xml for the better
  • Reorder some promo items to reduce number of categories

Screenshot: https://framapic.org/zoLNLOMMJZzP/A16KFQOIhWPL.png

Successor of #1101 which edited a lot of files only format-wise. This PR only tackles the design and structure changes. - Change design of /contribute/spreadtheword - Change design of /contribute/promotion-materials-archive - Change a few strings in texts-en.xml for the better - Reorder some promo items to reduce number of categories Screenshot: https://framapic.org/zoLNLOMMJZzP/A16KFQOIhWPL.png
max.mehl added the
design
label 1 year ago
max.mehl added the
xsl
label 1 year ago
mweimann commented 1 year ago
Collaborator

Looks much better.

Here are some thoughts about the rounded corners:

  • For the posters there is now a missing edge (see attachment).
  • The stickers are now presented as if they have rounded corners. In reality they are square.

I would give the single items a bit more space between so that they are cleaner to distinguish.

Lets call stock, author etc. the info section of each item. It looks noisy. I think with some alignment at this place it could be better.

For the radio buttons you could use https://getbootstrap.com/docs/3.3/components/#btn-groups (hope that's in the included bootstrap version). The current solution has filthy edges.

Looks much better. Here are some thoughts about the rounded corners: * For the posters there is now a missing edge (see attachment). * The stickers are now presented as if they have rounded corners. In reality they are square. I would give the single items a bit more space between so that they are cleaner to distinguish. Lets call *stock*, *author* etc. the *info section* of each item. It looks noisy. I think with some alignment at this place it could be better. For the radio buttons you could use https://getbootstrap.com/docs/3.3/components/#btn-groups (hope that's in the included bootstrap version). The current solution has filthy edges.
max.mehl commented 1 year ago
Poster
Owner

Thanks for the feedback, @mweimann!

For the posters there is now a missing edge (see attachment).
The stickers are now presented as if they have rounded corners. In reality they are square.

True. I don't have a good solution to that, especially because of the second point you've raised. So drop rounded corners altogether?

I would give the single items a bit more space between so that they are cleaner to distinguish.

Good point, will do.

Lets call stock, author etc. the info section of each item. It looks noisy. I think with some alignment at this place it could be better.

Yeah, I've noticed that as well. I tried separating them on 2 columns but that didn't look good either since the texts are of very different length. Perhaps the left column text-right?

For the radio buttons you could use https://getbootstrap.com/docs/3.3/components/#btn-groups (hope that’s in the included bootstrap version). The current solution has filthy edges.

Ah, interesting, will try! Will the active button's value be sent with the form (probably yes)?

And is there a possibility to make one button basically an input field but at the same time a radio button (so it deactivates the predefined values)?

Thanks for the feedback, @mweimann! > For the posters there is now a missing edge (see attachment). > The stickers are now presented as if they have rounded corners. In reality they are square. True. I don't have a good solution to that, especially because of the second point you've raised. So drop rounded corners altogether? > I would give the single items a bit more space between so that they are cleaner to distinguish. Good point, will do. > Lets call stock, author etc. the info section of each item. It looks noisy. I think with some alignment at this place it could be better. Yeah, I've noticed that as well. I tried separating them on 2 columns but that didn't look good either since the texts are of very different length. Perhaps the left column text-right? > For the radio buttons you could use https://getbootstrap.com/docs/3.3/components/#btn-groups (hope that’s in the included bootstrap version). The current solution has filthy edges. Ah, interesting, will try! Will the active button's value be sent with the form (probably yes)? And is there a possibility to make one button basically an input field but at the same time a radio button (so it deactivates the predefined values)?
bonnie commented 1 year ago
Collaborator

Hello,

as was agreed on this is the new country list where we are able to ship pm-packages to.

I also attached the message for the webiste in German and English.

Cheers
Bonnie

Hello, as was agreed on this is the new country list where we are able to ship pm-packages to. I also attached the message for the webiste in German and English. Cheers Bonnie
max.mehl changed title from Overhaul of Promo page (clean) to WIP: Overhaul of Promo page (clean) 12 months ago
kreyren commented 3 months ago

Looks like stale merge request to me?

Looks like stale merge request to me?
doczkal commented 2 months ago
Collaborator

Yeah, not sure what shall happen with this PR

Yeah, not sure what shall happen with this PR
suhrj commented 2 months ago

It's something I could have a look at if @max.mehl gives me the go ahead.

It's something I could have a look at if @max.mehl gives me the go ahead.
Poster
Owner

Sorry, yes, I was stuck more or less after writing https://git.fsfe.org/FSFE/fsfe-website/pulls/1125#issuecomment-7250. It's a completely different design, and the question is whether we want to use that or rather go back to a more traditional checkbox/radio buttons design.

Would be happy if someone else took over. However, a rebase would be required first I guess ;)

Sorry, yes, I was stuck more or less after writing https://git.fsfe.org/FSFE/fsfe-website/pulls/1125#issuecomment-7250. It's a completely different design, and the question is whether we want to use that or rather go back to a more traditional checkbox/radio buttons design. Would be happy if someone else took over. However, a rebase would be required first I guess ;)
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
This pull request has changes conflicting with the target branch.
contribute/spreadtheword.en.xhtml
contribute/spreadtheword.xsl
look/style.less
contribute/promoitems/active-items.en.xml
contribute/promotion-materials-archive.en.xhtml
contribute/promotion-materials-archive.xsl
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
6 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.