#1088 Adds an e-mail share button

Merged
mweimann merged 5 commits from feature/22-mail-share-link into master 11 months ago

This PR adds an e-mail share button (see screenshot).

I’ve used the exslt encode-uri function. We should test whether this extension is also available on the build machine.

closes #22

This PR adds an e-mail share button (see screenshot). I've used the exslt `encode-uri` function. We should test whether this extension is also available on the build machine. closes #22
max.mehl was assigned by mweimann 11 months ago
mweimann commented 11 months ago
Poster

@max.mehl please check this one and merge if you’re happy with it. Once done please close the issue and remove the branch. Thanks :)

@max.mehl please check this one and merge if you're happy with it. Once done please close the issue and remove the branch. Thanks :)
max.mehl commented 11 months ago
Owner

That worked very fine, thank you!

However, I wondered whether we can also add a short text of the page to the email. We already used this “extraction” in fsfe_head.xsl to display the twitter/og meta elements, but this was rather unaccessible for sharebuttons.xsl. So I moved it to fsfe.xsl to make it available for all XSL templates.

Since this is a big change, could you please test and confirm that both the share buttons and the meta elements work as expected?

That worked very fine, thank you! However, I wondered whether we can also add a short text of the page to the email. We already used this "extraction" in fsfe_head.xsl to display the twitter/og meta elements, but this was rather unaccessible for sharebuttons.xsl. So I moved it to fsfe.xsl to make it available for all XSL templates. Since this is a big change, could you please test and confirm that both the share buttons and the meta elements work as expected?
mweimann commented 11 months ago
Poster

Thanks for the update :)
Everything looks working fine.

Thanks for the update :) Everything looks working fine.
mweimann closed this pull request 11 months ago
mweimann deleted branch feature/22-mail-share-link 11 months ago
The pull request has been merged as 8a67f4b596.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.