#1042 Layout tweaks for the 2019-08-06 news

Merged
eal merged 3 commits from fix-news-20190806-01 into master 1 month ago
mweimann commented 1 month ago

Go through the commits for details

Some notes:

An image in a figure always takes all the available space. I tried to limit this by setting some col-x classes.

An ordered list (numbers before items) has a grey line on the top. That’s defined by the FSFE styles. If we want to change this we can do. But then all ols are affected.

Go through the commits for details Some notes: An image in a `figure` always takes all the available space. I tried to limit this by setting some `col-x` classes. An ordered list (numbers before items) has a grey line on the top. That's defined by the FSFE styles. If we want to change this we can do. But then all `ol`s are affected.
eal was assigned by mweimann 1 month ago
mweimann added the
design
label 1 month ago
max.mehl commented 1 month ago
Owner

Thank you!

@eal Would you like to test this? Not sure whether I find time for it before my vacation.

An ordered list (numbers before items) has a grey line on the top. That’s defined by the FSFE styles. If we want to change this we can do. But then all ols are affected.

Really? I don’t see that here. If there were a line though, I would also prefer to remove it.

Thank you! @eal Would you like to test this? Not sure whether I find time for it before my vacation. > An ordered list (numbers before items) has a grey line on the top. That’s defined by the FSFE styles. If we want to change this we can do. But then all ols are affected. Really? I don't see that [here](https://fsfe.org/news/2019/news-20190807-01.html). If there were a line though, I would also prefer to remove it.
mweimann commented 1 month ago
Poster

This is the matcher: h2#fn+ol so it depends on where the list is. Weird. Should we kick that out?

This is the matcher: `h2#fn+ol` so it depends on where the list is. Weird. Should we kick that out?
max.mehl commented 1 month ago
Owner

Ah, that’s for the footnotes, e.g. here: https://fsfe.org/about/basics/freesoftware.en.html

So I think it’s fine if it doesn’t have any wrong matches

Ah, that's for the footnotes, e.g. here: https://fsfe.org/about/basics/freesoftware.en.html So I think it's fine if it doesn't have any wrong matches
eal commented 1 month ago
Collaborator

Hi @mweimann thanks a lot for working on this! One question about the commit “Removes unnecessary figure classes”: I actually wanted the picture to be on the right side as I think this makes reading more easy, how do I achieve that?

Hi @mweimann thanks a lot for working on this! One question about the commit "Removes unnecessary figure classes": I actually wanted the picture to be on the right side as I think this makes reading more easy, how do I achieve that?
mweimann commented 1 month ago
Poster

I actually wanted the picture to be on the right side as I think this makes reading more easy, how do I achieve that?

The grid thing is already in use (row/cols). I suggest using that. If you want to have the image on the other side, just flip the columns.

Otherwise it’s a little bit mixed up. Rows/cols are used for positioning. Same for float but in another way. There sould be only one in place.

> I actually wanted the picture to be on the right side as I think this makes reading more easy, how do I achieve that? The grid thing is already in use (row/cols). I suggest using that. If you want to have the image on the other side, just flip the columns. Otherwise it's a little bit mixed up. Rows/cols are used for positioning. Same for `float` but in another way. There sould be only one in place.
eal commented 1 month ago
Collaborator

hm, not sure how to flip the columns. merging now, so I can possibly try it out on my local built.

hm, not sure how to flip the columns. merging now, so I can possibly try it out on my local built.
eal commented 1 month ago
Collaborator

thanks for working on this!

thanks for working on this!
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.